DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] pci: do not log false failures for non-whitelisted devices
@ 2017-04-04 14:59 Andrew Rybchenko
  2017-04-06 21:15 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Rybchenko @ 2017-04-04 14:59 UTC (permalink / raw)
  To: dev; +Cc: Anatoly Burakov, Aaron Conole

If probe of the whitelisted PCI device fails, reset ret to zero
to silently skip non-whitelisted PCI devices.

Fixes: 10f6c93cea38 ("eal: do not panic on PCI failures")

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 lib/librte_eal/common/eal_common_pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
index a0fc980..1ab92c9 100644
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -443,6 +443,7 @@ rte_eal_pci_probe(void)
 				 dev->addr.devid, dev->addr.function);
 			rte_errno = errno;
 			failed++;
+			ret = 0;
 		}
 	}
 
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] pci: do not log false failures for non-whitelisted devices
  2017-04-04 14:59 [dpdk-dev] [PATCH] pci: do not log false failures for non-whitelisted devices Andrew Rybchenko
@ 2017-04-06 21:15 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2017-04-06 21:15 UTC (permalink / raw)
  To: Andrew Rybchenko; +Cc: dev, Anatoly Burakov, Aaron Conole

2017-04-04 15:59, Andrew Rybchenko:
> If probe of the whitelisted PCI device fails, reset ret to zero
> to silently skip non-whitelisted PCI devices.
> 
> Fixes: 10f6c93cea38 ("eal: do not panic on PCI failures")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-06 21:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-04 14:59 [dpdk-dev] [PATCH] pci: do not log false failures for non-whitelisted devices Andrew Rybchenko
2017-04-06 21:15 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).