DPDK patches and discussions
 help / color / mirror / Atom feed
From: Eli Britstein <elibr@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>,
	ferruh.yigit@intel.com, arybchenko@solarflare.com,
	orika@mellanox.com, thomas@monjalon.net
Cc: asafp@mellanox.com, matan@mellanox.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item
Date: Tue, 4 Aug 2020 18:47:10 +0300
Message-ID: <3730207f-8882-094e-16f8-3680c80096c1@mellanox.com> (raw)
In-Reply-To: <6e8b7c61a92b51749b11ac3bfae5c0201352f9b3.1596550675.git.dekelp@mellanox.com>


On 8/4/2020 6:36 PM, Dekel Peled wrote:
> In existing code the match on tagged/untagged packets is not explicit.
> Recent documentation update [1] describes the different patterns and
> clarifies the intended use of different patterns.
>
> This patch proposes an update to ETH item struct, to clearly define the
> required characteristic of a packet, and enable precise match criteria.
>
> [1] http://mails.dpdk.org/archives/dev/2020-May/166257.html
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
>   lib/librte_ethdev/rte_flow.h | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index cf0eccb..345feb5 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -726,11 +726,20 @@ struct rte_flow_item_raw {
>    * If the @p ETH item is the only item in the pattern, and the @p type field
>    * is not specified, then both tagged and untagged packets will match the
>    * pattern.
> + * The fields @p cvlan_exist and @p svlan_exist can be used to match specific
> + * packet types, instead of using the @p type field. This can be used to match
> + * on packets that do/don't contain either cvlan, svlan, or both.
> + * The field @p num_of_vlans can be used to match packets by the exact number
> + * of VLANs in header.
>    */
>   struct rte_flow_item_eth {
>   	struct rte_ether_addr dst; /**< Destination MAC. */
>   	struct rte_ether_addr src; /**< Source MAC. */
>   	rte_be16_t type; /**< EtherType or TPID. */
> +	uint32_t cvlan_exist:1; /**< C-tag VLAN exist in header. */
> +	uint32_t svlan_exist:1; /**< S-tag VLAN exist in header. */
> +	uint32_t reserved:14; /**< Reserved, must be zero. */
> +	uint32_t num_of_vlans:16; /**< Number of VLANs in header. */
We can deduct from num_of_vlans the values of cvlan_exist/svlan_exist, 
so those are redundant fields. Keeping them introduce a conflicting 
match. For example num_of_vlans=0 and cvlan_exist=1.
>   };
>   
>   /** Default mask for RTE_FLOW_ITEM_TYPE_ETH. */

  reply	other threads:[~2020-08-06 10:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04 15:36 Dekel Peled
2020-08-04 15:47 ` Eli Britstein [this message]
2020-08-05  6:53   ` Dekel Peled
2020-08-05  7:04     ` Matan Azrad
2020-09-07 16:13       ` Maxime Leroy
2020-09-07 18:21         ` Dekel Peled
2020-08-04 16:22 ` Stephen Hemminger
2020-08-05  6:48   ` Dekel Peled
2020-08-06 10:36 ` [dpdk-dev] [RFC v2] ethdev: add VLAN attributes to ETH and VLAN items Dekel Peled
2020-09-08  9:30   ` Maxime Leroy
2020-09-30 15:59     ` Matan Azrad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3730207f-8882-094e-16f8-3680c80096c1@mellanox.com \
    --to=elibr@mellanox.com \
    --cc=arybchenko@solarflare.com \
    --cc=asafp@mellanox.com \
    --cc=dekelp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=matan@mellanox.com \
    --cc=orika@mellanox.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git