DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] i40e: bug fix of querying reta
@ 2014-12-09  0:53 Helin Zhang
  2014-12-10  3:10 ` [dpdk-dev] [PATCH v2] " Helin Zhang
  0 siblings, 1 reply; 3+ messages in thread
From: Helin Zhang @ 2014-12-09  0:53 UTC (permalink / raw)
  To: dev

There is a bug in querying reta, of storing the data to the correct entry.
Code changes is straightforward for this bug.

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
 lib/librte_pmd_i40e/i40e_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
index 899cb42..008d62c 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -1924,7 +1924,7 @@ i40e_dev_rss_reta_query(struct rte_eth_dev *dev,
 		lut = I40E_READ_REG(hw, I40E_PFQF_HLUT(i >> 2));
 		for (j = 0; j < I40E_4_BIT_WIDTH; j++) {
 			if (mask & (0x1 << j))
-				reta_conf[idx].reta[shift] = ((lut >>
+				reta_conf[idx].reta[shift + j] = ((lut >>
 					(CHAR_BIT * j)) & I40E_8_BIT_MASK);
 		}
 	}
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-dev] [PATCH v2] i40e: bug fix of querying reta
  2014-12-09  0:53 [dpdk-dev] [PATCH] i40e: bug fix of querying reta Helin Zhang
@ 2014-12-10  3:10 ` Helin Zhang
  2014-12-11  1:05   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Helin Zhang @ 2014-12-10  3:10 UTC (permalink / raw)
  To: dev

There is a bug in querying reta, of storing the data to the correct entry.
Code changes is straightforward for this bug.

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
 lib/librte_pmd_i40e/i40e_ethdev.c    | 2 +-
 lib/librte_pmd_i40e/i40e_ethdev_vf.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

v2 changes:
* Added the fix for the same issue in i40e VF driver.

diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
index 899cb42..008d62c 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -1924,7 +1924,7 @@ i40e_dev_rss_reta_query(struct rte_eth_dev *dev,
 		lut = I40E_READ_REG(hw, I40E_PFQF_HLUT(i >> 2));
 		for (j = 0; j < I40E_4_BIT_WIDTH; j++) {
 			if (mask & (0x1 << j))
-				reta_conf[idx].reta[shift] = ((lut >>
+				reta_conf[idx].reta[shift + j] = ((lut >>
 					(CHAR_BIT * j)) & I40E_8_BIT_MASK);
 		}
 	}
diff --git a/lib/librte_pmd_i40e/i40e_ethdev_vf.c b/lib/librte_pmd_i40e/i40e_ethdev_vf.c
index 7ef7d58..fe46cf1 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev_vf.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev_vf.c
@@ -1760,7 +1760,7 @@ i40evf_dev_rss_reta_query(struct rte_eth_dev *dev,
 		lut = I40E_READ_REG(hw, I40E_VFQF_HLUT(i >> 2));
 		for (j = 0; j < I40E_4_BIT_WIDTH; j++) {
 			if (mask & (0x1 << j))
-				reta_conf[idx].reta[shift] =
+				reta_conf[idx].reta[shift + j] =
 					((lut >> (CHAR_BIT * j)) &
 						I40E_8_BIT_MASK);
 		}
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v2] i40e: bug fix of querying reta
  2014-12-10  3:10 ` [dpdk-dev] [PATCH v2] " Helin Zhang
@ 2014-12-11  1:05   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2014-12-11  1:05 UTC (permalink / raw)
  To: Helin Zhang; +Cc: dev

> There is a bug in querying reta, of storing the data to the correct entry.
> Code changes is straightforward for this bug.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> ---
>  lib/librte_pmd_i40e/i40e_ethdev.c    | 2 +-
>  lib/librte_pmd_i40e/i40e_ethdev_vf.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> v2 changes:
> * Added the fix for the same issue in i40e VF driver.

Applied

Thanks
-- 
Thomas

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-12-11  1:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-09  0:53 [dpdk-dev] [PATCH] i40e: bug fix of querying reta Helin Zhang
2014-12-10  3:10 ` [dpdk-dev] [PATCH v2] " Helin Zhang
2014-12-11  1:05   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git