From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C8CF723D for ; Wed, 31 Oct 2018 17:11:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 630F222150; Wed, 31 Oct 2018 12:11:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 31 Oct 2018 12:11:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=zaIxlO40KJeHsQ0MhG/v90fErZj+x5rryjiOlFgbXHg=; b=e5qTX4ybvI8j IWq8/ENN/+hMA6DASdTU8skjxqUIUCcNXSp/d6OOBi0O4FXgjASCsb9Eu/jQ3pwA 18YKgkGl3KPAzDhzNoUkZ2moxMzARF9rbNDUC1DJiUpzS/YFNQlqfTF+fRDMQTdO 4A4vWAHXpbPjQ9WCzFHqYSZvN51acqA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=zaIxlO40KJeHsQ0MhG/v90fErZj+x5rryjiOlFgbX Hg=; b=GE5glgtWekKMiUIZnFKDu/k51Ne8d434xE4ruQvNDBT+AbgCkVMlcRRxf DwC/H7sDvXJHCoEO4emo11vSlB1B50Hd7HWvZARcJW+zfz0JyURR2zM8E8kcCSR7 +DwGZnFsMLlb8RkAz6+D6weFhNcYXWmEP7n7SEUqU/MLYHzvjK+VT/8PruDNfpdZ btFfUlZCwRg7ZXH3zEBVX7vTb9PwshjkZz92lcF8TVN5erSJ3pvYhjVjnbmaX7AJ lIvV8gbwyXxVd2xZ8WfAULAyNghm6tF4VDb9aiOWciOjRBstLXlp0pwaM7YvbSgH x+gNdUOrfS47Pfg70yowkZmJBTOMg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AB24F1030E; Wed, 31 Oct 2018 12:11:13 -0400 (EDT) From: Thomas Monjalon To: Radu Nicolau Cc: dev@dpdk.org, declan.doherty@intel.com, chas3@att.com, ferruh.yigit@intel.com, arybchenko@solarflare.com Date: Wed, 31 Oct 2018 17:11:19 +0100 Message-ID: <3736462.5cob8yss4D@xps> In-Reply-To: <1541001008-13498-1-git-send-email-radu.nicolau@intel.com> References: <1540994346-17532-1-git-send-email-radu.nicolau@intel.com> <1541001008-13498-1-git-send-email-radu.nicolau@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] net/bonding: fix segfault when creating bonded device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2018 16:11:16 -0000 31/10/2018 16:50, Radu Nicolau: > After the patch below the call to rte_eth_bond_8023ad_agg_selection_set > from probe() segfaults; there is no need to call the function, just set > the mode directly. > Also, reverted 1620175b400e. > > Fixes: 391797f04208 ("drivers/bus: move driver assignment to end of probing") > Fixes: 1620175b400e ("net/bonding: fix invalid port id") > > Signed-off-by: Radu Nicolau I cannot ack because I do not master this PMD, but it looks good to me.