From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 5C5BC2C08 for <dev@dpdk.org>; Thu, 24 Mar 2016 17:49:36 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id p65so74557228wmp.0 for <dev@dpdk.org>; Thu, 24 Mar 2016 09:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=qsh0LpAtBiI0KfZCVpBvQrgcZbCw3rNXsMKenb6oX/Y=; b=AfAee1lnF+qTRjZUpzTKLJMDXpnfBRa+BP24tRq8gn27HIrSp2nJhVDrFjBYkPCJLG GSwd1wDP9lUWmqg3iy8cpeQpPdg2M7Jaqu6Mi6uZ4IbitdXLCuXlETM8uHdB6VSGvk2y eLFdNB/W7Hp+XQRzYJmkFlhOroCerWs4OzjXobtUxd30DMgcY0Q5J84RrPGff+7nwqyb ldQx0+UEXkcxsEVec+ZklvY5TSFFR48ruZiFRNh8hRsGBwrNG5840sSJDj3rj6Zmzmia I5FvTx0EjfMM23Kh+DLXZFmG0YFo0Ty13qwzieecmTGx9xvfwJldi3YHLkQJc6SHRidi LHiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=qsh0LpAtBiI0KfZCVpBvQrgcZbCw3rNXsMKenb6oX/Y=; b=jIBN0cVBpXxM5jhA8tDr6kGww5R0Yy8pfxcY3/BsPbktBtkLbq3t6uY+htP1GuZbpd uKnGlILOOx6v5FL7xX59VJkYCCLn1AQW0x+1vfSQOUJ8lZTL+c5NOyqNMgv1cDWzomv/ b7yE2MDpksempgRDaXobfVf+gXHq+35FfFuj0YFkii+V7Xh5GsjkcTpDX5HXBKAPwI7p Ygao0VerWpFIgrYK+StTTxE0Y/a8OX9zF3EZN9bL5wI3loUI9wN32PIZ9vudJt0y5THX XcGj8GzEpmQ7KdYG1iuCCALSCj20rhiis/r26BwRlQCqEiGdTLgShPF/xzDMxWGKu/WT jIJg== X-Gm-Message-State: AD7BkJLFfjvgRND+mcVwPdsn4xrbZAWDBPVjJtOfzQwR7JZaEQeT1idYW+cs5aJMWyUyLRa0 X-Received: by 10.194.81.103 with SMTP id z7mr10829233wjx.25.1458838176155; Thu, 24 Mar 2016 09:49:36 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id hx10sm8143971wjb.25.2016.03.24.09.49.35 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 24 Mar 2016 09:49:35 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Jan Viktorin <viktorin@rehivetech.com> Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, tomaszx.kulasek@intel.com, jianbo.liu@linaro.org, david.marchand@6wind.com Date: Thu, 24 Mar 2016 17:47:51 +0100 Message-ID: <37407375.t09mPlLbzH@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1458417485-29436-1-git-send-email-viktorin@rehivetech.com> References: <1458379590-18618-1-git-send-email-viktorin@rehivetech.com> <1458417485-29436-1-git-send-email-viktorin@rehivetech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 0/4] arm: detect NEON by RTE_MACHINE_CPUFLAG_NEON flag only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 24 Mar 2016 16:49:36 -0000 2016-03-19 20:58, Jan Viktorin: > Hello, > > finally, I've broken the original patch into 4 pieces as it solves more issues > and not just a single one. > > * As Thomas have already mentioned, the CONFIG_RTE_ARCH_ARM_NEON is confusing. > So, I've decided to remove it entirely and provide another option for a more > specific purpose: CONFIG_RTE_ARCH_ARM_NEON_MEMCPY. > > * The RTE_MACHINE_CPUFLAG_NEON detection is now based on __ARM_NEON as only > this compiler definition gives us the arm_neon.h and is compatible with > arm64. In DPDK, the RTE_MACHINE_CPUFLAG_NEON should be prefered over the > __ARM_NEON. I'd recommend the same for x86 code (__SSE2__)... > > History: > v2 > * fix l3fwm_em.c to refer RTE_MACHINE_CPUFLAG_NEON instead of __ARM_NEON > > v3 > * divided into 4 patches as there are more independent problems > * compiles well for armv7 > * (probably) fixes RTE_MACHINE_CPUFLAG_NEON detection on arm64 Applied with discussed changes.