From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93DA3A0C52; Wed, 24 Nov 2021 14:52:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B140426F1; Wed, 24 Nov 2021 14:52:05 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 6F4C741233; Wed, 24 Nov 2021 14:52:04 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 00BB432004ED; Wed, 24 Nov 2021 08:52:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 24 Nov 2021 08:52:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= xklUy9piMJ8x4dtoQtkR9iXNN5NN+coZq4paeGHDOmI=; b=ml//YgBS3ZfdeOru 7si7U72oqJ9koadNU453Ed3wmt4lw34CyJvVOqQsPH5Uk860QnBtBAIpQES/MUjq FczVxVUHJfZjv6iN0+bQ5r38WZv3NVNdLZKl6jD0w+c8PwqtFXX6zfld2dNMWYZn QdR7wjyDPnZyH8CRGPUAg9cZoNZUtyFh94dB74H1VM8+68WT/XIGbPa+wyYwkoX0 r4siTJg3CxkB1D4VDfZxtUAJQhvm38LY6PZU/3IifPC1xMszr7hp4JF0xQm+SdiR QeQSKE1WKDW37AzlkS7R0/urD1+d4I+6uxrMypxeGHpX6xbvJ9hITk1AXWInxRJJ CxckmQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=xklUy9piMJ8x4dtoQtkR9iXNN5NN+coZq4paeGHDO mI=; b=mOsaMNFV3E+nOlHPCO4gdlKtofmcXsVKneHF9PBKGDnY8kscEYv/rQy4D CX78CHfTX3s2wih26NHqGTAkADmRVNU+ejSZFIjPpBq0A5Fc2pAOkhocPg5lvYGt P3ydU3qfhmPk/WXRYPvoCkrsYsGwvG6hsOHknM6mjGVr1dLv8TmHBJnw0llBlDb9 EyiSSiEgA9XBAhJc+1q8qUbNQL00MIOqzkIicF3X9GbxDVTclJFwMLSKckdCSnBQ n+nsAWH4GMTq33snRSfRzt1BySbZfRStLLvIBTwWdEM1ksno8kFsLHuRYOMYkS82 4XaHyemnEYDG+hB6+4sD1M9pFO2OA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeekgdehkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 Nov 2021 08:51:59 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: David Marchand , Elad Nachman , Ferruh Yigit , dev@dpdk.org, stable@dpdk.org, Igor Ryzhov , Eric Christian , Stephen Hemminger , Sahithi Singam Subject: Re: [PATCH v2] kni: restrict bifurcated device support Date: Wed, 24 Nov 2021 14:51:57 +0100 Message-ID: <3741185.2VLPbhnIhI@thomas> In-Reply-To: <20211123164618.3585878-1-ferruh.yigit@intel.com> References: <20211008235830.127167-1-ferruh.yigit@intel.com> <20211123164618.3585878-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/11/2021 17:46, Ferruh Yigit: > To enable bifurcated device support, rtnl_lock is released before calling > userspace callbacks and asynchronous requests are enabled. > > But these changes caused more issues, like bug #809, #816. To reduce the > scope of the problems, the bifurcated device support related changes are > only enabled when it is requested explicitly with new 'enable_bifurcated' > module parameter. > And bifurcated device support is disabled by default. > > So the bifurcated device related problems are isolated and they can be > fixed without impacting all use cases. > > Bugzilla ID: 816 > Fixes: 631217c76135 ("kni: fix kernel deadlock with bifurcated device") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > Acked-by: Igor Ryzhov This approach looks pragmatic. BTW, I'm not sure there is a strong need for KNI with bifurcated device. Applied, thanks.