From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5A2C7914 for ; Thu, 30 Jun 2016 10:14:56 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 30 Jun 2016 01:14:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,551,1459839600"; d="scan'208";a="727250723" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.221.26]) ([10.237.221.26]) by FMSMGA003.fm.intel.com with ESMTP; 30 Jun 2016 01:14:54 -0700 To: "Elo, Matias (Nokia - FI/Espoo)" , "dev@dpdk.org" References: Cc: "ferruh.yigit@intel.com" , "damarion@cisco.com" From: Sergio Gonzalez Monroy Message-ID: <3745bde4-f539-21d4-51e4-369d35697e57@intel.com> Date: Thu, 30 Jun 2016 09:14:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] weak functions in some drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 08:14:56 -0000 On 29/06/2016 14:26, Elo, Matias (Nokia - FI/Espoo) wrote: >>> What is not clear to me is motivation to use weak here instead of simply using >CONFIG_RTE_I40E_INC_VECTOR >>> macro to exclude stubs in i40e_rxtx.c. It will make library smaller and avoid issues like this one >>> which are quite hard to troubleshoot. >> Since this issue seen in fd.io, I didn't investigated more, but I don't >> want to clock your valid question, this is an attempt to resurrect the >> question ... > Hi, > > We are having exactly the same problem. For us the aforementioned workaround doesn't seem to work and vector mode is always disabled with the i40e drivers. If I modify i40e_rxtx.c and exclude the stub functions using CONFIG_RTE_I40E_INC_VECTOR everything works as expected. > > We are building DPDK with the CONFIG_RTE_BUILD_COMBINE_LIBS option enabled and link DPDK library to our application. > > Any other ideas how this could be fixed? > > Regards, > Matias > So you have tried to link a combined static lib with --whole-archive -ldpdk --no-whole-archive and still get the wrong/weak function definition? Sergio