From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 1329D1B4AE for ; Thu, 22 Nov 2018 18:15:19 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8447322109; Thu, 22 Nov 2018 12:15:18 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 22 Nov 2018 12:15:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=+JC+Wehe4Nr6O6G6A1FH/quc2LE7ywPJVXdI5EeSEaU=; b=bnI94Rah+//0 Hux2qxta6qocM7HXbqByh5JPAAZscKEsPi9LZ8OxWSfuL/l+6y0Y+6HvYl3oJcLI NJ3ITt2ShqODV/VYiFcNidXRe8rI/I4GJ8HLB4gFJ0TZBtMdIC4H/tUYa/MZDqr3 UYRrU0THsR4LS+AqNwL91mNEsmDRh84= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=+JC+Wehe4Nr6O6G6A1FH/quc2LE7ywPJVXdI5EeSE aU=; b=J6Y4gTnmz+Hqt1+vAKqRjU2i4bXkdguPERGO5wlMWywbNBKLU5KVIBRTz 2WPOUapQG+MSVSCcEtAaQwF2FELnPnkH/B6y2cjK5GKFvcRDBy3jfBuAgF3Nh3zv 1MpnraFjwA9b4qz+Qb+u1voq52/OgBNS8KxRkRJdLMQF/lHcRRCWkV3HRfgzCD+M KYmGHg9dGcs3OgwiCN9IH8xKphzdsU5zZIs0j6KJNy7DUkjqg9Ait7YrfVNqEJFQ h+NR/8DTLq7zdCjIBfFpGhRI2rohkGJLLpQaqLu09AzPybdg0Y6IC8lUuEbplneJ AR8AtzwHIMx/+MKsZE0FsLfu5YFfQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 136BCE48FA; Thu, 22 Nov 2018 12:15:16 -0500 (EST) From: Thomas Monjalon To: Ian Stokes Cc: dev@dpdk.org, Ferruh Yigit , stephen@networkplumber.org, arybchenko@solarflare.com Date: Thu, 22 Nov 2018 18:15:16 +0100 Message-ID: <3746356.gW38syhklm@xps> In-Reply-To: <0abfa3f0-0f58-3265-d156-4d8d9b670830@intel.com> References: <1542888549-24656-1-git-send-email-ian.stokes@intel.com> <0abfa3f0-0f58-3265-d156-4d8d9b670830@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 1/1] doc: announce ethdev ABI change for rte_eth_dev_info. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 17:15:19 -0000 22/11/2018 13:11, Ferruh Yigit: > On 11/22/2018 12:09 PM, Ian Stokes wrote: > > Maximum and minimum MTU values vary between hardware devices. In > > hardware agnostic DPDK applications access to such information would > > allow a more accurate way of validating and setting supported MTU values on > > a per device basis rather than using a defined default for all devices. > > > > The following solution was proposed: > > > > http://mails.dpdk.org/archives/dev/2018-September/110959.html > > > > This patch adds a depreciation notice for ``rte_eth_dev_info`` as new > > members will be added to represent min and max MTU values. These can be > > added to fit a hole in the existing structure for amd64 but not for 32 bit, > > as such ABI change will occur as size of the structure will be impacted. > > > > Signed-off-by: Ian Stokes > > Acked-by: Ferruh Yigit Acked-by: Thomas Monjalon [...] > > +* ethdev: Maximum and minimum MTU values vary between hardware devices. In > > + hardware agnostic DPDK applications access to such information would allow > > + a more accurate way of validating and setting supported MTU values on a per > > + device basis rather than using a defined default for all devices. To > > + resolve this, the following members will be added to ``rte_eth_dev_info``. > > + Note: these can be added to fit a hole in the existing structure for amd64 > > + but not for 32 bit, as such ABI change will occur as size of the structure > > + will increase. > > + > > + - Member ``uint16_t min_mtu`` the minimum MTU allowed. > > + - Member ``uint16_t max_mtu`` the maximum MTU allowed. > > +