From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id B8D687E1F for ; Fri, 5 Dec 2014 17:14:24 +0100 (CET) Received: by mail-wi0-f171.google.com with SMTP id bs8so1907808wib.4 for ; Fri, 05 Dec 2014 08:14:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=j3vOM63drprxznd+RKN9vE2MbowZjv+sXULuDLM+X40=; b=SDV805Mj1C168h/vzNBp6ejaGBodIJyMhM0ZLoHavE+2Ld8bZlnUYT0XI0cP+pqFqK 1trLVibVV82TgkodtFa6S/9lQnca530qCZ4wAqjqJLpEttHW/dA+Su7Ej8CFjGt/IW4M BMad1cG4rH/Qm60T1Uomr1cxWH2D9fNiTeB2r52egNwtNPRgSAy0rTJYPadoQtWlr5BW 42ig81XpsFEbAiJMqa3xPzkpnGlsk/VRXSYOiyh6hzj40qRohQSwTNANwZKbR1NHY4nL /7JHW1kjZdjXSWbiO9fCCXycQlarCMFlT9DjG0wPPll7mXS/pNhIuXmEwDpc77M7Haeq +SyQ== X-Gm-Message-State: ALoCoQkyu2tlmVSFwHw2Ga+pXTa/R9IEfPYBi5XgsEpfy/9rKZly4HhJkU6doldARroHKuyeAWeR X-Received: by 10.194.95.10 with SMTP id dg10mr25732442wjb.82.1417796064411; Fri, 05 Dec 2014 08:14:24 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id p15sm28080047wjr.18.2014.12.05.08.14.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Dec 2014 08:14:23 -0800 (PST) From: Thomas Monjalon To: "Wu, Jingjing" Date: Fri, 05 Dec 2014 17:13:58 +0100 Message-ID: <3752546.1FjpsJa7G7@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <1417707623-25777-1-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH]i40e: move the fdir_setup from dev_init to dev_configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Dec 2014 16:14:25 -0000 > > In order not to affect the FVL's performance by default setting, this patch moves > > the flow director initialization from i40e_pf_setup to i40e_dev_configure > > according to the mode in fdir configure info. > > Then the resources used for flow director will be only setup if it is enabled. > > > > Signed-off-by: jingjing.wu > > Acked-by: Helin Zhang Applied A lot of commit titles need rewording. This one is a good example to explain. We don't need to see the function or structure names in a title. The global idea is a lot more interesting and easy to read. Here, I changed i40e: move the fdir_setup from dev_init to dev_configure to i40e: setup flow director only if enabled Thanks -- Thomas