From: Thomas Monjalon <thomas@monjalon.net>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org, Jan Blunck <jblunck@infradead.org>
Subject: Re: [dpdk-dev] [PATCH v4 2/9] bus: add device iterator
Date: Wed, 21 Jun 2017 13:55:39 +0200 [thread overview]
Message-ID: <3755201.Yc0g0bYsoq@xps> (raw)
In-Reply-To: <24f6e244a99903f543925067aa52baafe10cfc84.1497999601.git.gaetan.rivet@6wind.com>
21/06/2017 01:29, Gaetan Rivet:
> +/**
> + * Device comparison function.
> + *
> + * @param dev
> + * Device handle.
> + *
> + * @param data
> + * Data to compare against.
> + *
> + * @return
> + * 0 if the device matches the data.
> + * !0 if the device does not match.
> + * <0 if ordering is possible and the device is lower than the data.
> + * >0 if ordering is possible and the device is greater than the data.
> + */
> +typedef int (*rte_dev_cmp_t)(const struct rte_device *dev, const void *data);
data is really abstract.
Maybe a comment is missing to explain that data is better specified
in bus implementations?
Why not implement it for PCI?
next prev parent reply other threads:[~2017-06-21 11:55 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 15:04 [dpdk-dev] [PATCH 0/9] bus: attach / detach API Gaetan Rivet
2017-05-24 15:04 ` [dpdk-dev] [PATCH 1/9] bus: add bus iterator to find a particular bus Gaetan Rivet
2017-05-24 15:04 ` [dpdk-dev] [PATCH 2/9] bus: add device iterator Gaetan Rivet
2017-05-24 15:04 ` [dpdk-dev] [PATCH 3/9] bus: add helper to find bus for a particular device Gaetan Rivet
2017-05-24 15:04 ` [dpdk-dev] [PATCH 4/9] bus: add bus helper iterator to find " Gaetan Rivet
2017-05-24 15:04 ` [dpdk-dev] [PATCH 5/9] bus: introduce attach/detach functionality Gaetan Rivet
2017-05-24 15:04 ` [dpdk-dev] [PATCH 6/9] vdev: implement find_device bus operation Gaetan Rivet
2017-05-24 15:04 ` [dpdk-dev] [PATCH 7/9] vdev: implement detach " Gaetan Rivet
2017-05-24 15:05 ` [dpdk-dev] [PATCH 8/9] eal: make virtual driver probe and remove take rte_vdev_device Gaetan Rivet
2017-05-24 15:05 ` [dpdk-dev] [PATCH 9/9] ethdev: Use embedded rte_device to detach driver Gaetan Rivet
2017-05-31 13:17 ` [dpdk-dev] [PATCH v2 00/11] bus: attach / detach API Gaetan Rivet
2017-05-31 13:17 ` [dpdk-dev] [PATCH v2 01/11] bus: add bus iterator to find a particular bus Gaetan Rivet
2017-06-07 7:06 ` Shreyansh Jain
2017-06-07 13:27 ` Gaëtan Rivet
2017-06-07 16:55 ` Jan Blunck
2017-06-08 4:34 ` Shreyansh Jain
2017-06-08 8:05 ` Gaëtan Rivet
2017-05-31 13:17 ` [dpdk-dev] [PATCH v2 02/11] bus: add device iterator Gaetan Rivet
2017-05-31 13:17 ` [dpdk-dev] [PATCH v2 03/11] bus: add helper to find bus for a particular device Gaetan Rivet
2017-05-31 13:17 ` [dpdk-dev] [PATCH v2 04/11] bus: add bus helper iterator to find " Gaetan Rivet
2017-06-07 16:41 ` Jan Blunck
2017-06-07 20:12 ` Gaëtan Rivet
2017-05-31 13:17 ` [dpdk-dev] [PATCH v2 05/11] bus: introduce hotplug functionality Gaetan Rivet
2017-05-31 13:17 ` [dpdk-dev] [PATCH v2 06/11] vdev: implement find_device bus operation Gaetan Rivet
2017-05-31 13:17 ` [dpdk-dev] [PATCH v2 07/11] vdev: implement hotplug functionality Gaetan Rivet
2017-05-31 13:17 ` [dpdk-dev] [PATCH v2 08/11] vdev: implement unplug bus operation Gaetan Rivet
2017-05-31 13:17 ` [dpdk-dev] [PATCH v2 09/11] eal: make virtual driver probe and remove take rte_vdev_device Gaetan Rivet
2017-05-31 13:17 ` [dpdk-dev] [PATCH v2 10/11] ethdev: Use embedded rte_device to detach driver Gaetan Rivet
2017-05-31 13:17 ` [dpdk-dev] [PATCH v2 11/11] net/ring: fix dev handle in eth_dev Gaetan Rivet
2017-05-31 15:34 ` [dpdk-dev] [PATCH v2 00/11] bus: attach / detach API Stephen Hemminger
2017-06-26 0:27 ` Gaëtan Rivet
2017-06-07 23:53 ` [dpdk-dev] [PATCH v3 00/10] " Gaetan Rivet
2017-06-07 23:53 ` [dpdk-dev] [PATCH v3 01/10] bus: add bus iterator to find a particular bus Gaetan Rivet
2017-06-10 8:58 ` Jan Blunck
2017-06-11 19:59 ` Gaëtan Rivet
2017-06-07 23:53 ` [dpdk-dev] [PATCH v3 02/10] bus: add device iterator Gaetan Rivet
2017-06-07 23:53 ` [dpdk-dev] [PATCH v3 03/10] bus: add helper to find bus for a particular device Gaetan Rivet
2017-06-07 23:53 ` [dpdk-dev] [PATCH v3 04/10] bus: add bus helper iterator to find " Gaetan Rivet
2017-06-07 23:53 ` [dpdk-dev] [PATCH v3 05/10] bus: introduce hotplug functionality Gaetan Rivet
2017-06-07 23:53 ` [dpdk-dev] [PATCH v3 06/10] vdev: implement find_device bus operation Gaetan Rivet
2017-06-07 23:53 ` [dpdk-dev] [PATCH v3 07/10] vdev: implement hotplug functionality Gaetan Rivet
2017-06-07 23:53 ` [dpdk-dev] [PATCH v3 08/10] eal: make virtual driver probe and remove take rte_vdev_device Gaetan Rivet
2017-06-07 23:53 ` [dpdk-dev] [PATCH v3 09/10] ethdev: use embedded rte_device to detach driver Gaetan Rivet
2017-06-07 23:53 ` [dpdk-dev] [PATCH v3 10/10] net/ring: fix dev handle in eth_dev Gaetan Rivet
2017-06-20 23:29 ` [dpdk-dev] [PATCH v4 0/9] bus: attach / detach API Gaetan Rivet
2017-06-20 23:29 ` [dpdk-dev] [PATCH v4 1/9] bus: add bus iterator to find a particular bus Gaetan Rivet
2017-06-21 12:12 ` Thomas Monjalon
2017-06-20 23:29 ` [dpdk-dev] [PATCH v4 2/9] bus: add device iterator Gaetan Rivet
2017-06-21 11:55 ` Thomas Monjalon [this message]
2017-06-21 12:15 ` Gaëtan Rivet
2017-06-20 23:29 ` [dpdk-dev] [PATCH v4 3/9] bus: add helper to find bus for a particular device Gaetan Rivet
2017-06-21 12:11 ` Thomas Monjalon
2017-06-20 23:29 ` [dpdk-dev] [PATCH v4 4/9] bus: add bus helper iterator to find " Gaetan Rivet
2017-06-21 12:21 ` Thomas Monjalon
2017-06-20 23:29 ` [dpdk-dev] [PATCH v4 5/9] bus: introduce hotplug functionality Gaetan Rivet
2017-06-20 23:29 ` [dpdk-dev] [PATCH v4 6/9] vdev: implement find_device bus operation Gaetan Rivet
2017-06-20 23:29 ` [dpdk-dev] [PATCH v4 7/9] vdev: implement hotplug functionality Gaetan Rivet
2017-06-20 23:29 ` [dpdk-dev] [PATCH v4 8/9] eal: make virtual driver probe and remove take rte_vdev_device Gaetan Rivet
2017-06-20 23:29 ` [dpdk-dev] [PATCH v4 9/9] ethdev: use embedded rte_device to detach driver Gaetan Rivet
2017-06-21 14:33 ` Thomas Monjalon
2017-06-21 14:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3755201.Yc0g0bYsoq@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=jblunck@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).