From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96368A034F; Mon, 22 Mar 2021 10:01:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DE86140E0C; Mon, 22 Mar 2021 10:01:58 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 0E9F5140DF9 for ; Mon, 22 Mar 2021 10:01:56 +0100 (CET) IronPort-SDR: 48THu9wTFXCJswMoPaBWgwCu0PuhIBmyeUwxMt/s+QMzY6AGkKeQdMYF3YVZE1SGLVTFuxslF+ FbhAGPo3S/QQ== X-IronPort-AV: E=McAfee;i="6000,8403,9930"; a="254228674" X-IronPort-AV: E=Sophos;i="5.81,268,1610438400"; d="scan'208";a="254228674" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 02:01:55 -0700 IronPort-SDR: Pu1VPK8qIcLCDrS4wUALCJXC4ioSH0tEfh9mYanWyXxIrnOJ5zzEttQtE7rZzNDwc8g/E6ur7p AhgaUq5nRQrg== X-IronPort-AV: E=Sophos;i="5.81,268,1610438400"; d="scan'208";a="451666387" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.14.44]) ([10.252.14.44]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 02:01:54 -0700 To: Andrew Rybchenko , Ivan Malov , dev@dpdk.org Cc: Andy Moreton , Ori Kam , Thomas Monjalon References: <20210312093143.28186-1-ivan.malov@oktetlabs.ru> <20210312110745.31721-1-ivan.malov@oktetlabs.ru> <0e5845a3-a06a-b335-959b-77cddee206ee@intel.com> <8b23c0d4-a5c8-8a18-c856-1719730181cc@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy Message-ID: <375db290-6bd1-a620-b74b-3590f5c81326@intel.com> Date: Mon, 22 Mar 2021 09:01:51 +0000 MIME-Version: 1.0 In-Reply-To: <8b23c0d4-a5c8-8a18-c856-1719730181cc@oktetlabs.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 01/10] ethdev: reuse header definition in flow pattern item ETH X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/17/2021 6:40 AM, Andrew Rybchenko wrote: > On 3/16/21 8:38 PM, Ferruh Yigit wrote: >> On 3/12/2021 11:07 AM, Ivan Malov wrote: >>> One ought to reuse existing header structs in flow items. >>> This particular item contains non-header fields, so it's >>> important to keep the header fields in a separate struct. >>> >> >> Hi Ivan, Andrew, Thanks for following this up and updates. >> >> For record, existing deprecation note is: >> https://git.dpdk.org/dpdk/tree/doc/guides/rel_notes/deprecation.rst?h=v21.02#n99 >> >> >> Ori, Andrew, >> >> Is there any struct left not updated after this patch? > > As I understand the following flow items corresponding to > network protocols, but still define own fields. Sometimes > corresponding network protocols do not have definitions in > DPDK, but it is not an excuse and definitions should be > simply added: > rte_flow_item_e_tag > rte_flow_item_nvgre > rte_flow_item_mpls > rte_flow_item_gre > rte_flow_item_gtp > rte_flow_item_geneve > rte_flow_item_vxlan_gpe > rte_flow_item_arp_eth_ipv4 > rte_flow_item_icmp6 > rte_flow_item_icmp6_nd_ns > rte_flow_item_icmp6_nd_na > rte_flow_item_icmp6_nd_opt > rte_flow_item_icmp6_nd_opt_sla_eth > rte_flow_item_icmp6_nd_opt_tla_eth > rte_flow_item_gtp_psc > rte_flow_item_pppoe > rte_flow_item_pppoe_proto_id > rte_flow_item_l2tpv3oip > rte_flow_item_nsh > rte_flow_item_igmp > rte_flow_item_ah > rte_flow_item_pfcp > rte_flow_item_geneve_opt > > The list is composed very quickly so may be I oversight > something, but it definitely answers the question - yes, > more flow items remain. > Ahh, I was thinking the problematic ones, the ones adding extra fields than the protocol header, 'rte_flow_item_eth', 'rte_flow_item_vlan' and there was one more I guess, but you are right, all needs be updated. So there are more to be updated, are you planning to work on any more of them in this release? btw, thanks again for addressing this issue. >> >>> Signed-off-by: Ivan Malov >>> Reviewed-by: Andrew Rybchenko >>> Reviewed-by: Andy Moreton >> >> <...> >