DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Sexton, Rory" <rory.sexton@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Hunt, David" <david.hunt@intel.com>,
	"Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [dpdk-dev] [v4 1/3] examples/vm_power_manager: Make branch ratio	threshold per core
Date: Fri, 17 Jul 2020 14:40:17 +0200
Message-ID: <3764076.3kGO6qlCEv@thomas> (raw)
In-Reply-To: <BN6PR11MB12821AAE804D713E77C0718CFF7E0@BN6PR11MB1282.namprd11.prod.outlook.com>

15/07/2020 17:08, Pattan, Reshma:
> From: Rory Sexton
> > 
> > This modification allows for the branch ratio threshold to be set per core rather
> > than system wide. This gives greater flexibility to the branch ration monitoring
> 
> Small typo ration ->ratio
> 
> > Signed-off-by: Rory Sexton <rory.sexton@intel.com>
> > Reviewed-by: David Hunt <david.hunt@intel.com>
> 
> >---
> >v4: adding upper limit of 100.0 to branch ratio
> >---
> 
> The upper limit changes looks fine to  me.
> 
> Small nitpick that the commit headline should be in lower case, same applicable to other patches.
> You can take care this next time if you are spinning the another version and keep my ack.
> 
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>

Series applied with minor changes and doc squashed.

2 more comments for next contributions:
- use a cover letter if there are multiple patches
- please use --in-reply-to to thread all versions with the first one



  reply	other threads:[~2020-07-17 12:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 16:01 Rory Sexton
2020-07-14 16:01 ` [dpdk-dev] [v4 2/3] examples/vm_power_manager: Allowing power managing of idle cores Rory Sexton
2020-07-15 15:09   ` Pattan, Reshma
2020-07-14 16:02 ` [dpdk-dev] [v4 3/3] doc: update vm_power_manager cmdline options in doc Rory Sexton
2020-07-15 15:15   ` Pattan, Reshma
2020-07-17 12:31   ` Thomas Monjalon
2020-07-15 15:08 ` [dpdk-dev] [v4 1/3] examples/vm_power_manager: Make branch ratio threshold per core Pattan, Reshma
2020-07-17 12:40   ` Thomas Monjalon [this message]
2020-07-20 10:26     ` Sexton, Rory

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3764076.3kGO6qlCEv@thomas \
    --to=thomas@monjalon.net \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=reshma.pattan@intel.com \
    --cc=rory.sexton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git