From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0103A053B; Fri, 17 Jul 2020 14:40:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 106CD1C0D8; Fri, 17 Jul 2020 14:40:20 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 4AE431C0D7 for ; Fri, 17 Jul 2020 14:40:19 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id D62EA5C01C7; Fri, 17 Jul 2020 08:40:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 17 Jul 2020 08:40:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= wOWxNl9qpx9WsTrbR3YRPqnplO6bzwJoJjwgQ02AciA=; b=VV00Fyd7Xucc3/wi jzHAchVIGai1HkunNaeveXPtPygVNkUsIDrq3qXJCPWXTnEN9eo6NY9LLSoR60L8 XIecOZvIkWfujlkFF9zLi7ek9NeKH9Ol9is3rRiY8sEsSgRI0+zMProAJXDM/RVi h8l3md26T9x2f3bIFwWEMB0JYIsltNKDxJYMhLniVUFflSC2tyMkh1186tL06UCV Kh9tafhRJSy4k9pMs2/I95zIDJ2X7cB8K7hAMB02GtMdNidFOtsS3Je2eaS0yPJT N3/HEH5BGz7Jkc+xR0UTwTMNssK28gYicbwhLWehWN/eesaHct649mEBdI3KVa9u 8RHYrw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=wOWxNl9qpx9WsTrbR3YRPqnplO6bzwJoJjwgQ02Ac iA=; b=KigRV0FmvAP3zFnkjopYT7BoT9xpb6bxPW2kb/ah4ZoI2JNF8jqE9z4Uo UQzA3np1NxbvWdEiVHi7IjVsIS20CJezruu6lxMxRu1yhLakBKLqR+7aP6ooM24Q 2A1/8rRC2l8ZI34ZjNz/znTWkS47ShCyBB1ur+XcWP4xSzZs3aR6+pRq0CQQRArp MbqOIe3NQON1eKylHHiLWeVYlkhdy6oKgaLQht0J8Pnq2rbjCejFLRsMKU3wtllx hWFWnt+2+RIgey9vvxQcRjBAz55MsyV2Ll/WV8ljuOuI9QAOp5Fw55xxK1WXqBtk aFETWauJ/0dK8ORTmmM9LfG4uIxpw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfeeigdehfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 212AD30600DC; Fri, 17 Jul 2020 08:40:18 -0400 (EDT) From: Thomas Monjalon To: "Sexton, Rory" Cc: "dev@dpdk.org" , "Hunt, David" , "Pattan, Reshma" Date: Fri, 17 Jul 2020 14:40:17 +0200 Message-ID: <3764076.3kGO6qlCEv@thomas> In-Reply-To: References: <20200714160200.1727417-1-rory.sexton@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [v4 1/3] examples/vm_power_manager: Make branch ratio threshold per core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/07/2020 17:08, Pattan, Reshma: > From: Rory Sexton > > > > This modification allows for the branch ratio threshold to be set per core rather > > than system wide. This gives greater flexibility to the branch ration monitoring > > Small typo ration ->ratio > > > Signed-off-by: Rory Sexton > > Reviewed-by: David Hunt > > >--- > >v4: adding upper limit of 100.0 to branch ratio > >--- > > The upper limit changes looks fine to me. > > Small nitpick that the commit headline should be in lower case, same applicable to other patches. > You can take care this next time if you are spinning the another version and keep my ack. > > Acked-by: Reshma Pattan Series applied with minor changes and doc squashed. 2 more comments for next contributions: - use a cover letter if there are multiple patches - please use --in-reply-to to thread all versions with the first one