From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 38E751B2E7; Tue, 13 Feb 2018 17:03:42 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B73F920C90; Tue, 13 Feb 2018 11:03:41 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 13 Feb 2018 11:03:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=nTi4Ymo0FP7QcIahONHlfT1ylO Gv7yyulA/v57NsXBg=; b=dWM4dClvJ2NizYxJoPgA+jpof8XQpk2NcfBICto66d 6b9Bd3DfUIpK/QeT/MEXKORUfaOy9m5+T0QntPf2fikpBAm8CxcnCvuNIjN4No6W dmEWEL+IcpMzVhgLxa7G4fILku9CrU0an21erO/lFBbPuxod/wCuKf37PSwcFOy8 Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=nTi4Ym o0FP7QcIahONHlfT1ylOGv7yyulA/v57NsXBg=; b=ikPABQBaT9IVVPPAiiqhs9 XhUAgdutNAiN/wWQx0Qv7PKuDs7hOGzWDiwlSCfnd6o273w513eGfWEiBZVBC90a 1VJ86gPDmSzz5tOefYZVaCHWorSkhQVUVZbnDO8ae3ZrTmnLtVUwZz48RrGQh6sN JEdz0y4KAqybA2lUlNHrDgBEgv0r2VpJLIbfXqzEPYsE7WCBXjfCqUrZ7fgMSrxK BL84i+WvOnNpmG2R/D/VCQwNpCKy4fh39wHFzkEMogPbtatLejw94uK4grpElGuc xU3JLz4likUANCXh6ypCsBZ24yI0rQmRK7E7l2lQSwkv/Bd434UZA1dBvGAzwkjw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 56F1E240DB; Tue, 13 Feb 2018 11:03:41 -0500 (EST) From: Thomas Monjalon To: Shahaf Shuler Cc: dev@dpdk.org, =?ISO-8859-1?Q?N=E9lio?= Laranjeiro , adrien.mazarguil@6wind.com, yskoh@mellanox.com, rasland@mellanox.com, stable@dpdk.org Date: Tue, 13 Feb 2018 17:03:31 +0100 Message-ID: <3777397.EmTq4m18zT@xps> In-Reply-To: <20180213124104.x4qjimmomzmivxmb@laranjeiro-vm.dev.6wind.com> References: <20180213123155.44183-1-shahafs@mellanox.com> <20180213124104.x4qjimmomzmivxmb@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH] net/mlx5: revert multicast rule Verbs flow type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 16:03:42 -0000 13/02/2018 13:41, N=E9lio Laranjeiro: > On Tue, Feb 13, 2018 at 02:31:55PM +0200, Shahaf Shuler wrote: > > This is to revert the following commits: > > commit da646bd93888 ("net/mlx5: fix all multi verification code positio= n") > > commit 0a40a1363a4d ("net/mlx5: fix flow type for allmulti rules") > >=20 > > The last one introduced a bug in the following diff: > > @ -1262,6 +1274,7 @@ struct ibv_spec_header { > > eth.val.ether_type &=3D eth.mask.ether_type; > > } > > mlx5_flow_create_copy(parser, ð, eth_size); > > + parser->allmulti =3D eth.val.dst_mac[0] & 1; > > return 0; > > } > >=20 > > As broadcast rules will be considered of type allmulti as well. > >=20 > > The patch was originally intended to enable VF to receive all multicast > > traffic by using the IBV_FLOW_ATTR_MC_DEFAULT flow type. > > Since the support was removed from the kernel there is no point with > > fixing this issue, hence the revert. > >=20 > > Cc: nelio.laranjeiro@6wind.com > > Cc: rasland@mellanox.com > > Cc: stable@dpdk.org > >=20 > > Signed-off-by: Shahaf Shuler >=20 > Acked-by: Nelio Laranjeiro Applied, thanks