DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jijiang Liu <jijiang.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e
Date: Thu, 16 Oct 2014 21:56:39 +0200	[thread overview]
Message-ID: <3781474.dkZOSRuQuF@xps13> (raw)
In-Reply-To: <1413006935-22535-3-git-send-email-jijiang.liu@intel.com>

2014-10-11 13:55, Jijiang Liu:
>  #
> +# Compile tunneling UDP port support
> +#
> +CONFIG_RTE_LIBRTE_TUNNEL_UDP_PORT=4789
> +
> +#

1) this option is not to "Compile tunneling UDP port support"
2) why is it a compile time option? should it be an API parameter or
a runtime option?

> +	uint16_t packet_type;     /**< Packet type, which indicates packet format */

It's not very clear what packet type is.
There is maybe a more precise description, or is it hardware dependent?

>  static struct i40e_veb *i40e_veb_setup(struct i40e_pf *pf,
> -						struct i40e_vsi *vsi);
> +					struct i40e_vsi *vsi);

It's not related to VXLAN.

-- 
Thomas

  parent reply	other threads:[~2014-10-16 19:49 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-11  5:55 [dpdk-dev] [PATCH v5 0/8]Support VxLAN on Fortville Jijiang Liu
2014-10-11  5:55 ` [dpdk-dev] [PATCH v5 1/8]i40e:support VxLAN packet identification in librte_ether Jijiang Liu
2014-10-16 17:07   ` Thomas Monjalon
2014-10-11  5:55 ` [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e Jijiang Liu
2014-10-13 16:12   ` De Lara Guarch, Pablo
2014-10-16 10:19     ` De Lara Guarch, Pablo
2014-10-16 19:56   ` Thomas Monjalon [this message]
2014-10-17  5:58     ` Liu, Jijiang
2014-10-17  7:39       ` Thomas Monjalon
2014-10-20  1:25         ` Liu, Jijiang
2014-10-11  5:55 ` [dpdk-dev] [PATCH v5 3/8]app/test-pmd:test VxLAN packet identification Jijiang Liu
2014-10-16 20:01   ` Thomas Monjalon
2014-10-17  5:23     ` Liu, Jijiang
2014-10-17  7:41       ` Thomas Monjalon
2014-10-11  5:55 ` [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API Jijiang Liu
2014-10-15 16:01   ` De Lara Guarch, Pablo
2014-10-16  1:24     ` Liu, Jijiang
2014-10-16 12:41   ` De Lara Guarch, Pablo
2014-10-16 20:09   ` Thomas Monjalon
2014-10-17  6:53     ` Liu, Jijiang
2014-10-17  7:47       ` Thomas Monjalon
2014-10-20  1:22         ` Liu, Jijiang
2014-10-11  5:55 ` [dpdk-dev] [PATCH v5 5/8]i40e:implement API of VxLAN packet filter in librte_pmd_i40e Jijiang Liu
2014-10-11  5:55 ` [dpdk-dev] [PATCH v5 6/8]app/testpmd:test VxLAN packet filter API Jijiang Liu
2014-10-11  5:55 ` [dpdk-dev] [PATCH v5 7/8]i40e:support VxLAN Tx checksum offload Jijiang Liu
2014-10-16 20:34   ` Thomas Monjalon
2014-10-17  5:20     ` Liu, Jijiang
2014-10-11  5:55 ` [dpdk-dev] [PATCH v5 8/8]app/testpmd:test " Jijiang Liu
2014-10-11  7:28 ` [dpdk-dev] [PATCH v5 0/8]Support VxLAN on Fortville Liu, Yong
2014-10-11  7:56   ` Liu, Yong
2014-10-16 20:18     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3781474.dkZOSRuQuF@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jijiang.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).