* [dpdk-dev] [PATCH] eal/bsd: fix return value when mapping device resources in secondary process
@ 2014-10-30 12:23 Pablo de Lara
2014-11-05 21:51 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Pablo de Lara @ 2014-10-30 12:23 UTC (permalink / raw)
To: dev
On FreeBSD, when initializing a secondary process,
EAL was complaining if there were ports not bound
to nic_uio module, exiting the application, which
should not happen, as this is expected behaviour,
and not an error
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
index 54fcaf0..74ecce7 100644
--- a/lib/librte_eal/bsdapp/eal/eal_pci.c
+++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
@@ -183,7 +183,7 @@ pci_uio_map_secondary(struct rte_pci_device *dev)
}
RTE_LOG(ERR, EAL, "Cannot find resource for device\n");
- return -1;
+ return 1;
}
/* map the PCI resource of a PCI device in virtual memory */
--
1.7.4.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/bsd: fix return value when mapping device resources in secondary process
2014-10-30 12:23 [dpdk-dev] [PATCH] eal/bsd: fix return value when mapping device resources in secondary process Pablo de Lara
@ 2014-11-05 21:51 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2014-11-05 21:51 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev
> On FreeBSD, when initializing a secondary process,
> EAL was complaining if there were ports not bound
> to nic_uio module, exiting the application, which
> should not happen, as this is expected behaviour,
> and not an error
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-05 21:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-30 12:23 [dpdk-dev] [PATCH] eal/bsd: fix return value when mapping device resources in secondary process Pablo de Lara
2014-11-05 21:51 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).