DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Trahe, Fiona" <fiona.trahe@intel.com>,
	David Marchand <david.marchand@redhat.com>,
	"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
	Anoob Joseph <anoobj@marvell.com>,
	Akhil Goyal <akhil.goyal@nxp.com>
Cc: dev@dpdk.org, "shallyv@marvell.com" <shallyv@marvell.com>,
	"Doherty, Declan" <declan.doherty@intel.com>,
	"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] [RFC] doc: announce removal of crypto list end enumerators
Date: Thu, 06 Aug 2020 18:09:40 +0200
Message-ID: <3785663.8APzvf4N2U@thomas> (raw)
In-Reply-To: <VI1PR04MB31687BF53B2106212A8BD640E64E0@VI1PR04MB3168.eurprd04.prod.outlook.com>

31/07/2020 11:38, Akhil Goyal:
> Hi David,
> 
> > Hi David,
> > 
> > >
> > > On Wed, Jul 29, 2020 at 4:47 PM Arek Kusztal
> > > <arkadiuszx.kusztal@intel.com> wrote:
> > > >
> > > > Enumerators RTE_CRYPTO_CIPHER_LIST_END,
> > RTE_CRYPTO_AUTH_LIST_END,
> > > > RTE_CRYPTO_AEAD_LIST_END will be removed to prevent some problems
> > > > that may arise when adding new algorithms.
> > >
> > > How does it cohabitate with Ferruh notice?
> > > Is it a complement? or redundant?
> > >
> > >
> > https://git.dpdk.org/dpdk/commit/doc/guides/rel_notes/deprecation.rst?id=58245da070289f4b248f15
> > >
> > Thanks for drawing attention to this.
> > It's complementary as far as I can see.
> > Ferruh's doesn't list all enums - but doesn’t appear to cover these crypto ones.
> 
> I feel we can have this deprecation notice as well for crypto specific enums.
> Though I don’t want to push it if somebody has objections on this.
> I am OK if Ferruh's notice looks enough to cover crypto enums as well.
> 
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> If no objections, Thomas or you can pick this directly on master.

I think Ferruh notice would be enough, except it focus on "MAX" values,
not including the similar ones with "END" in their names.

Anyway, too much notices don't hurt.

Applied



      reply	other threads:[~2020-08-06 16:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 14:46 Arek Kusztal
2020-07-29 14:54 ` Kusztal, ArkadiuszX
2020-07-29 15:18 ` Bruce Richardson
2020-07-29 15:22 ` Trahe, Fiona
2020-07-29 15:24 ` David Marchand
2020-07-29 15:32   ` Trahe, Fiona
2020-07-31  9:38     ` Akhil Goyal
2020-08-06 16:09       ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3785663.8APzvf4N2U@thomas \
    --to=thomas@monjalon.net \
    --cc=akhil.goyal@nxp.com \
    --cc=anoobj@marvell.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=shallyv@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git