From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id E87272BB0 for ; Tue, 22 May 2018 16:12:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2018 07:12:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,430,1520924400"; d="scan'208";a="230801556" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.77]) ([10.237.221.77]) by fmsmga006.fm.intel.com with ESMTP; 22 May 2018 07:12:17 -0700 From: Ferruh Yigit To: Thomas Monjalon , Alejandro Lucero , Maciej Czekaj , Wenzhuo Lu , Konstantin Ananyev , Qi Zhang , Xiao Wang , Santosh Shukla , Jerin Jacob , Shijith Thotton , Srisivasubramanian Srinivasan Cc: Andrew Rybchenko , Hemant Agrawal , Shreyansh Jain , dpdk-dev , Beilei Xing , Tetsuya Mukawa , Maxime Coquelin References: <9a1b4500-d354-bdef-45d3-7d6eeacfb54b@intel.com> Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: <37887500-61db-f2d6-d647-0de83cb3860a@intel.com> Date: Tue, 22 May 2018 15:12:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <9a1b4500-d354-bdef-45d3-7d6eeacfb54b@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] Remaining old offloading API usage in PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 14:12:22 -0000 On 5/11/2018 11:45 AM, Ferruh Yigit wrote: > Some PMDs are still using old offloading API related variables, thanks to Andrew > for reporting it. > > Maintainers of related PMDs are cc'ed. > Please check following list and provide a fix ASAP for it, thanks. > > > # git grep header_split drivers/ > drivers/net/i40e/i40e_rxtx_vec_common.h: if (rxmode->header_split == 1) > > # git grep hw_vlan_filter drivers/ > drivers/net/i40e/i40e_vf_representor.c: if > (ethdev->data->dev_conf.rxmode.hw_vlan_filter) > drivers/net/vhost/rte_eth_vhost.c: if (rxmode->hw_vlan_filter) > > # git grep hw_vlan_strip drivers/ > drivers/net/dpaa2/dpaa2_rxtx.c: if > (dev->data->dev_conf.rxmode.hw_vlan_strip) > drivers/net/i40e/i40e_vf_representor.c: if > (ethdev->data->dev_conf.rxmode.hw_vlan_strip)T > drivers/net/vhost/rte_eth_vhost.c: internal->vlan_strip = > rxmode->hw_vlan_strip; > > # git grep hw_vlan_extend drivers/ > drivers/net/i40e/i40e_rxtx_vec_common.h: if (rxmode->hw_vlan_extend == 1) > > # git grep hw_strip_crc drivers/ > drivers/net/nfp/nfp_net.c: rxq->crc_len = (uint8_t) > ((dev->data->dev_conf.rxmode.hw_strip_crc) ? 0 > drivers/net/sfc/sfc_rx.c: rxmode->hw_strip_crc = 1; > Code (almost [1]) cleaned up from old API usage, thanks everybody. But driver documentation still has some pointers from old API usage, Andrew also reported some. Related maintainers are cc'ed, can you please check and fix following usages: doc/guides/prog_guide/poll_mode_drv.rst 331:For an application to use the Tx offloads API it should set the ``ETH_TXQ_FLAGS_IGNORE`` flag in the ``txq_flags`` field located in ``rte_eth_txconf`` struct. 332:In such cases it is not required to set other flags in ``txq_flags``. doc/guides/nics/virtio.rst 237:* ``txq_flags`` is set to ``VIRTIO_SIMPLE_FLAGS`` (0xF01), which implies: doc/guides/nics/ixgbe.rst 105:TX vPMD only works when txq_flags is set to IXGBE_SIMPLE_FLAGS. 110:* ETH_TXQ_FLAGS_NOMULTSEGS 112:* ETH_TXQ_FLAGS_NOVLANOFFL 114:* ETH_TXQ_FLAGS_NOXSUMSCTP 116:* ETH_TXQ_FLAGS_NOXSUMUDP 118:* ETH_TXQ_FLAGS_NOXSUMTCP doc/guides/nics/fm10k.rst 109:TX vPMD only works when ``txq_flags`` is set to ``FM10K_SIMPLE_TX_FLAG``. 113:* ``ETH_TXQ_FLAGS_NOMULTSEGS`` 115:* ``ETH_TXQ_FLAGS_NOVLANOFFL`` 117:* ``ETH_TXQ_FLAGS_NOXSUMSCTP`` 119:* ``ETH_TXQ_FLAGS_NOXSUMUDP`` 121:* ``ETH_TXQ_FLAGS_NOXSUMTCP`` doc/guides/nics/thunderx.rst 323:``rxmode.hw_strip_crc`` member is set to 0 in ``struct rte_eth_conf``. 329:is fixed and cannot be changed. So, even when the ``rxmode.max_rx_pkt_len`` doc/guides/nics/ixgbe.rst 71:To guarantee the constraint, configuration flags in dev_conf.rxmode will be checked: 133:In the configuration, ensure that port_conf.rxmode.hw_ip_checksum=0. 139:As in the case of l3fwd, set configure port_conf.rxmode.hw_ip_checksum=0 to enable vPMD. doc/guides/nics/fm10k.rst 82:To guarantee the constraint, the following configuration flags in ``dev_conf.rxmode`` 153:``rxmode.hw_strip_crc`` member is set to 0 in ``struct rte_eth_conf``. 160:is fixed and cannot be changed. So, even when the ``rxmode.max_rx_pkt_len`` doc/guides/nics/octeontx.rst 169:``rxmode.hw_strip_crc`` member is set to 0 in ``struct rte_eth_conf``. 175:is fixed and cannot be changed. So, even when the ``rxmode.max_rx_pkt_len`` doc/guides/nics/liquidio.rst 205:interface. So, CRC will be stripped even when the ``rxmode.hw_strip_crc`` [1] Waiting nfp.