From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Ziye Yang <ziye.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] pci: Add the class_id support in pci probe
Date: Thu, 28 Jan 2016 22:38:54 +0100 [thread overview]
Message-ID: <3789219.tMSa25XPXU@xps13> (raw)
In-Reply-To: <56964186.1060800@redhat.com>
2016-01-13 14:22, Panu Matilainen:
> On 01/13/2016 01:55 PM, Bruce Richardson wrote:
> > On Thu, Dec 31, 2015 at 09:12:14AM -0800, Stephen Hemminger wrote:
> >> On Tue, 29 Dec 2015 10:53:26 +0800
> >> Ziye Yang <ziye.yang@intel.com> wrote:
> >>
> >>> This patch is used to add the class_id support
> >>> for pci_probe since some devices need the class_info
> >>> (class_code, subclass_code, programming_interface)
> >>>
> >>> Signed-off-by: Ziye Yang <ziye.yang@intel.com>
> >>
> >> Since rte_pci is exposed to application this breaks the ABI.
> >
> > But applications are not going to be defining rte_pci_ids values internally, are
> > they? That is for drivers to use. Is this really an ABI breakage for applications that we
> > need to be concerned about?
>
> There might not be applications using it but drivers are ABI consumers
> too - think of 3rd party drivers and such.
Drivers are not ABI consumers in the sense that ABI means
Application Binary Interface.
We are talking about drivers interface here.
When establishing the ABI policy we were discussing about applications only.
I agree we must allow 3rd party drivers but there is no good reason
to try to upgrade DPDK without upgrading/porting the external drivers.
If someone does not want to release its driver and keep upgrading DPDK,
it is acceptable IMHO to force an upgrade of its driver.
next prev parent reply other threads:[~2016-01-28 21:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 2:53 Ziye Yang
2015-12-31 17:12 ` Stephen Hemminger
2016-01-13 11:55 ` Bruce Richardson
2016-01-13 12:22 ` Panu Matilainen
2016-01-28 21:38 ` Thomas Monjalon [this message]
2016-01-29 9:21 ` Panu Matilainen
2016-01-29 9:34 ` Thomas Monjalon
2016-01-29 10:10 ` Panu Matilainen
2016-01-29 12:47 ` Panu Matilainen
2016-05-11 6:08 Ziye Yang
2016-05-11 15:21 ` Stephen Hemminger
2016-05-11 15:34 ` Richardson, Bruce
2016-05-19 10:33 ` Thomas Monjalon
2016-05-19 12:18 ` Yang, Ziye
2016-05-19 12:57 ` Thomas Monjalon
2016-05-19 13:14 ` Yang, Ziye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3789219.tMSa25XPXU@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
--cc=stephen@networkplumber.org \
--cc=ziye.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).