From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82CDD42486; Wed, 25 Jan 2023 14:21:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AD6342D3E; Wed, 25 Jan 2023 14:21:25 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2076.outbound.protection.outlook.com [40.107.244.76]) by mails.dpdk.org (Postfix) with ESMTP id 0CED142D31 for ; Wed, 25 Jan 2023 14:21:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kfg/0a39lfvq737AMrjXcKiQ8sVQhmo1kuPAK9/lhx6XmVKb1hWIO5HYSYSo2OfqcjiaJPdrQtYdg7zYHpM+AyrxhRA+wJiL/WSpT1NIDROhX/rtbkZrPI5xNIfqpx+BfOwiBTqcWIpzAd9ZTLuBR0d+qeVkISpKXyZ9NkOCuWKW/4rWc3aTdoN3UgvLuoqJ3/pR5cYFMhhTKPxA4HgyAYmVfcC8bIWS6rMB9JPaqlc93wOsXtQVv8MozdAsscEgPYf1Uuflhsi2pgzQEuFDOOcnyWoTMul9izVG5isx+Fmm9KUTY6ScIoxTIZxk1P3peh8GbYr8zhVqk7jYc0MHDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AEw4GKnuyh1ks9lL00oJjoJVuvD4l1XSlFLm9m3ex/8=; b=UFqBqZ6O0QcTIVuo1n+OC9rq69JKWXPYNRZk/7mxgmY+P1orXN8NpiU5pAXbROeTxWMBZleSFu8XdsdAxpgcwMolWrQdcy3gJNmtJdujw0Qdy0EmDBeoyHOFFcYNDOO5vL4DADdaKW2iEd9z2vSvwuljIYwT6/wcd7kbR60lR7GQwEhcm2Y6iInL2Bg0ElY6GiLBs//uz+2iB/9lqtveWZYSEiLMgzQNfUXqQZFM3DbuGGkOAuD3JRbcYHtk6wpNQRoejVh3P+aiLagKt5VyjTsRLRAdSbj9Zb7YGacu4wwMiaU7dFpM/IYDFzbaDQwkwGHKnZZ2yS5TJsvjyMQujA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AEw4GKnuyh1ks9lL00oJjoJVuvD4l1XSlFLm9m3ex/8=; b=Vtoc8vvRdhRFvgr3vl9UfjtPKre8A68z4c0R7axuMFYqrpBcDmTYJVIBKjvF83DpO0RHl6NaGONETvb8WvpSt1zARGCO9fYhh7Ym6PDXTXH07d8p3halBWBdEDJ+cBZAVLMp2y9oY/ZB5nsF0k5GmPrtkfn1NODSNoA3w2289m0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB7568.namprd12.prod.outlook.com (2603:10b6:208:42c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Wed, 25 Jan 2023 13:21:21 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%7]) with mapi id 15.20.6002.033; Wed, 25 Jan 2023 13:21:21 +0000 Message-ID: <378c66a1-ccf0-a6db-58fc-7bc8c20df9a4@amd.com> Date: Wed, 25 Jan 2023 13:21:15 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation Content-Language: en-US From: Ferruh Yigit To: Hanumanth Reddy Pothula , Aman Singh , Yuying Zhang , Ivan Malov , Andrew Rybchenko , Thomas Monjalon Cc: "dev@dpdk.org" , "viacheslavo@nvidia.com" , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram References: <20221220200250.2413443-1-hpothula@marvell.com> <20221221020713.2803232-1-hpothula@marvell.com> <20221221020713.2803232-2-hpothula@marvell.com> <11fa3448-7348-09d6-b7e0-321aef1d8953@amd.com> <1cc09d94-cd90-e60a-27c1-4a0b7a6a3c02@amd.com> In-Reply-To: <1cc09d94-cd90-e60a-27c1-4a0b7a6a3c02@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0485.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB7568:EE_ X-MS-Office365-Filtering-Correlation-Id: 90e4b015-1415-4779-566f-08dafed70cb9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QfPrBeTyaCOmQ2USYsofmDrqwNW5FTkeJ+RpD37SS6KHTf8i26UgSRlb817Umvie5+fHzYTwHKLRvwUZwDJhC/xcqg/Y/Cr7RUEbzl+UvCJJDkLaAE1FvRaQobSbCZ+w/PxzYGKxsyCXT5Dw0Ml7xD4p+4EOgPNIKhprS9cL98q4MKpYq44eUO5/lmW2qKWMGfndV7CG6vgAbJnA884GgWk8+ImZT2ocUsBvAFu+mp1/HkK87usWk7iKROLHb/e1R577cTms7Ra4Ics5mqrsSGOj/lpY5/ZnrOhny4fQCjOL1a/bCnu7OntoodNU5UnO3KyeHLpXkff6+248arrmu4vKc3RFMZcUpHHd00pxuHBqgUKaOw+9ISKUMlRzmHL9s+Ze8LH4dD18x/AWW06pZrZcdan9caB/dviksYZhFHm+CSgYc6d9KXgGjBpE3sG5uL3kNsHUd8b4+Se94ArC9zWliZX4cIgy8UYxfXf7ZaZiOkemCPk3uxdUC0poJRZ1ZjOQlgqJrVQzoD7e4v68+OSP2mu7e9vvzhkA71DrV4/pF+0M0IOCNX/RciODSxh4ijk3Y+t47k8SGqFHCnM30tqcF8IOp2FQ/fHfSldNLzwWt8qxD0nXZZTAJROYF0a+bIQRXmbTD3h1JCYARMNt9Xy4PDFwg9Vwr2Tyr75D32bwmLN+9s6kktMZEWkTBFprOY3QAwNWCrlHFK7CF+swl1vNr4Uv/7wspAbHwSVsia7qrBOeJiN9ZJMZz0WKhN0a6I7rr3lQBbpJqK+6/DqJxQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(346002)(39860400002)(136003)(396003)(376002)(451199018)(38100700002)(36756003)(110136005)(966005)(6486002)(31696002)(478600001)(316002)(83380400001)(66556008)(44832011)(66476007)(8676002)(4326008)(2616005)(54906003)(2906002)(31686004)(6506007)(53546011)(86362001)(186003)(8936002)(41300700001)(26005)(66946007)(7416002)(5660300002)(6512007)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDlUNEdVZlliOEZEL0gzSHdrSC9CM1dia1k5a0RUakdqcjk3LzZITVQ4YVRH?= =?utf-8?B?akM5RlQxSktjWmlDU3VNQlpKTzR6Q25LYXdMT0xjUUpQSFdGOUF3WEJRVFlY?= =?utf-8?B?WnN5ZDNHTHEyd0s1MTlXcGdBc0J0ODR1dHRGaS8yTE9UVlkwak1OV3R5QU00?= =?utf-8?B?aXN2U25kWDF6OSsyMG9nWFdJckVKM2RscmpHZk4weGZVcTRsaVhBZGlwNFlR?= =?utf-8?B?dGN0azJZaWd6VitsT1YweXhmc0tIVDlEcUI4d1l6aTkxVFhpNU83QURsY1Vk?= =?utf-8?B?YmZLMXgwWm9nWnNEMms5MnQ4aFF6M1VaTDJvYWxxU0FvZFRTZGJIeVZSMDNO?= =?utf-8?B?WGVFWXorTG9xUzk2Zy8zbUhPc0c2enVJemdYU3BJUWJrVU9veWxZdFRIZXdi?= =?utf-8?B?ZWJYVXBIRnNYdENmQmR2NVJOaXBVVnRNQWUwY1ZtY3pBSFdWSkhQVFRubGho?= =?utf-8?B?R3VKUEFxcGV0ZXpHS3oxc0hkTkYvTEFuRzRhRWMwL0wraU1zREovQ1lYaU40?= =?utf-8?B?bzJLVlJHMkk2YlFqVnFYMlNQcjdLQksxWTZGSEFEZmMwZDNsd2prb21kSFdW?= =?utf-8?B?VFNMazg1cUR0OWlCY3BwV1YyTjZwVk8wdFB0THdiUktHSGdOSjJOS2hzTnJq?= =?utf-8?B?VHg5S0lPTTNvajhXQndkWDcydkxja0dmbnRucG5DV256ckZOckFoWmk1ZmFQ?= =?utf-8?B?UVRaMU45T2Izc0tIMmlRTlJwWU5qQkY0MS9lL1YwUmVhSVVXWnp1Z2hkV1hC?= =?utf-8?B?Sko0OGxJSHJUSUJ4SGZveHQzT0c1TWlEWk9XUmFreG5sc0o3YmpKRi9RWlVE?= =?utf-8?B?VTFXTFhDZEx0bHJ2TlJISmtBYnpVdzZHK0I4Q3I0bjVrdTN4WkdjVjcwZ3BM?= =?utf-8?B?ZEJTZ2dFYWhDbHhaRUtlRmd5TUx1STJvNlBsL1VGVjlkMzlLc2xxRzZmdHBh?= =?utf-8?B?cDg2b2M1cEtZc251clN0U0pMeFRoQ2JTVC9GQVQ2dEZCaUtkaDRsbk9ud1Iv?= =?utf-8?B?cXBHR3Nha09tSHFXRWIrZkFldUxOUDlxcnhGcFA5dVg0MGZhWVl2VTN5ZDc1?= =?utf-8?B?L3d2YSszT0t5VzYvMVA3VEx3TDdOVThWZ04zR3ZHRTA4a0VhVytBY0FrRGl0?= =?utf-8?B?ZUpXWHNadjdUMEJYdlRTU2poeFhOaDRqelg5N3ZUckU5K2FscU9qWEgvT2lR?= =?utf-8?B?ei9nZVpjRGJiMEJkeVNyMDRCdDYvY1B0eGdncXlBV1NPRnlVeEdOQlI0Q3VD?= =?utf-8?B?blh5TFlmSWJjQ0JtYkNQc0hZeTY1dUZQa0tNdmRTV0M0NSszK2dUTDlQd0lF?= =?utf-8?B?WVlPNWVjWEs0YzVPN2xHTzFjQ0NWMXgxcFA4ejVHdjRrNGVoRDBYWGtVcGh0?= =?utf-8?B?ajExRWxHd1hhelJzSVlranBVb3JNUWhXK2ovZTR2WmtxeXJoNURrZ1J5TFlH?= =?utf-8?B?VmRrOURaZTZrNUZBU1g2OGhrWTRWV01QNTVTdGxpeHBxbTNoQkxDRWdTbFlk?= =?utf-8?B?cmhiUGZ1Y2R5OW15YnVieTFsdzYvb3ZQNm9GRHcwdi9taStYSlpYeFFPRE94?= =?utf-8?B?VHZha094b01nMzUyQWw2dkF1OEt6cytoVlVLVEdSeUphYW0vclJVRTJUcGhi?= =?utf-8?B?SjNsMFppeWw4QkdLN2M3R1FSem51RmRJRGVTMWVMSjVYT2lvbGpJd0h1RVFF?= =?utf-8?B?QkRzNmtibjVCTkVQR1JudUkvQm1ZZlFiTTRucUpnZzZTT3phZGVlZEFUdXZu?= =?utf-8?B?NWJXRUZBd2dSQ2NrdkhJTmpSZ1FIZzRoNmo3dkdhOUFEa0RGeWlINms0Q0M3?= =?utf-8?B?WjNFeE5xWnBjamhWOG9XK0JZaXQ2R2xra3hCZ0QxOUxud1NIZXppOTNIbTlz?= =?utf-8?B?SG1QNkVRQytxbWd6TFYxZ2lBb0pZc0lMRitNUmQ0dE02cXpBNmxaVEF2RmxB?= =?utf-8?B?NG84c29KaG5tTWVJbXZ1VlBtNzU0RXRqN0hnYUFEMytLK1FqNThxOGN6bHor?= =?utf-8?B?YjY1enJBWnEvR2hjQXFGbXREOXRLRjIvQzlWSlpCLzJ0YlJpQS92Z3kwaThC?= =?utf-8?B?SHlFVlJRa3o3Y211VjdYS1JpZktzcVhEVXIwcXNSSXlrSWFWdHJnS2F4ejc1?= =?utf-8?Q?85vlXeRV8riMtTxPEZlTa5cBC?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90e4b015-1415-4779-566f-08dafed70cb9 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 13:21:21.3742 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3qaIl0I8WdHGDAQloVyP7uVNKpJIHKgORQsaF3TQAHkLQaUOs0L09xy48z0F6jbS X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7568 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/25/2023 1:17 PM, Ferruh Yigit wrote: > On 1/25/2023 9:30 AM, Hanumanth Reddy Pothula wrote: >> ++ Ivan Malov and Andrew Rybchenko >> >>> -----Original Message----- >>> From: Ferruh Yigit >>> Sent: Tuesday, January 24, 2023 11:34 PM >>> To: Hanumanth Reddy Pothula ; Aman Singh >>> ; Yuying Zhang >>> Cc: dev@dpdk.org; andrew.rybchenko@oktetlabs.ru; >>> viacheslavo@nvidia.com; Jerin Jacob Kollanukkaran ; >>> Nithin Kumar Dabilpuram >>> Subject: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process >>> Rx metadata negotiation >>> >>> External Email >>> >>> ---------------------------------------------------------------------- >>> On 12/21/2022 2:07 AM, Hanumanth Pothula wrote: >>>> Presently, Rx metadata is sent to PMD by default, leading to a >>>> performance drop as processing for the same in Rx path takes extra >>>> cycles. >>>> >>>> Hence, add new testpmd command, >>>> 'enable port nic_to_pmd_rx_metadata' >>>> >>>> This command helps in sending Rx metadata to PMD and thereby Rx >>>> metadata flow command requests are processed. >>>> >>>> Signed-off-by: Hanumanth Pothula >>> >>> Hi Hanumanth, >>> >>> I agree with Thomas for the patch. >>> >>> 'eth_rx_metadata_negotiate_mp()' requests all Rx metadata offloads to be >>> enabled, but at this stage if there is no flow rule for Rx metadata why it is >>> consuming extra cycles? >>> >>> Can you update driver code to process Rx metadata when it is enabled by >>> application (via 'rte_eth_rx_metadata_negotiate()') AND there is at least >>> one flow rule for it? >> >> #1 What is the purpose of rte_eth_rx_metadata_negotiate() API if it is always called by testpmd. >> We thought it was added so that when that metadata is not needed, application need not call this >> thereby saving cycles/bandwidth. >> > > Purpose looks like to 'negotiate', so it is both ways: > a) To learn Rx Meta capability of HW > b) To configure Rx Meta feature for HW > > So it is both to help application to learn what flow rule is supported > and to help driver to improve performance. > > Before this API application assumed all Rx metadata flow rules are > supported, so why enabling all causing performance drop, that was the > default without this API. > > But other-way around can be true, to disable some offloads can improve > driver performance. > > Looking again, > please ignore this email, it has unfinished draft reply by mistake, I will send a new one. > >> #2 We use this API similar to Rx/Tx offload flags so that we can set things up before device is >> configured. We thought that is the purpose of having this negotiate API and avoid depleting offload flags. >> >> #3 Generally any new offloads added to DPDK would be in disabled state in testpmd and we would have >> an option to enable it. In this case, testpmd is by default calling this negotiation. >> >> We can update the driver if the purpose of this API is clear. > > > Hi Hanumanth, > > After looking the history of the API again, you may be right. > > One of the previous version commit log describes the intention better > [1], because of negative performance impact of enabling Rx metadata > offload by default and difficulty to switch configuration dynamically, > there is a desire to learn application intention before configuration. > > Although I have some concerns with this API [2] it is already there as > stable API. > > So it sounds reasonable to make this configurable for a test > application, indeed intention of the API is to get this configuration > from application and operate based on it. > > Next question is what should be the default value, I am not sure about > it, there are only a few drivers impacted from this overall. > For the Thomas' point, it helps to test the feature of its impact if it > is enabled by default. > > Will it work to enable them all by default and add capability to disable > it in testpmd, which helps to run performance tests also to verify the > impact of the API? > > Thanks, > ferruh > > > > [1] > https://inbox.dpdk.org/dev/20210902142359.28138-2-ivan.malov@oktetlabs.ru/ > > > [2] > API does two things: > a) Learn Rx Meta capability of HW > b) Configure Rx Meta feature for HW > > Functionality (a) conflicts with rest of the flow rules that capability > checked via `rte_flow_validate()` API. > > Functionality (b) conflicts with configuring flow actions, this > configuration should be controlled by flow rule not with a specific API, > although I understand the reasoning behind the API. > > RSS_HASH offload seems given example in the discussions but it is still > controlled via offload flag, there is no specific API to configure RSS > hash functionality, same could be done here. > [/2]