From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D64E9A0544; Mon, 10 Oct 2022 16:52:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4A2A4021E; Mon, 10 Oct 2022 16:52:24 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2067.outbound.protection.outlook.com [40.107.237.67]) by mails.dpdk.org (Postfix) with ESMTP id C074740146 for ; Mon, 10 Oct 2022 16:52:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XTlatpC6XmMIdyLfixJ/R8SFBlJfklDQy/1aXtgpoDREE+tCMHGdwG8gJYpm3Q67IV5xKsMmeNaQrjN7AO9EyF7uXM9VyVifS9nn+dn25SoaxpeRCX94C64SzAoKLTdWvVIqzx1GdFM7PjBYiPTqGHtwaHum1o1WtBEtPZwb8LFUHiPLNE2O4ehebdQQRNhGs/i0aLTUJZi0kpgZ3cRb5zPMi+82QUCo3Nmk4hej+fJJqMOdKlHQxWylCMzsvhhaBNKa8zaUs1b9akBXRvBD1DT0Jrwdhr30rrrnc0s6zBijf3lkYyW4S8qK768Up+BojjT2kylVdaYEr7cQU9eB4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=brD1CXywV1KfTWwzQUD29fBn8g/3oAkTBlHI5hRtwgw=; b=luEJbFHtyIXc5umUbXyunEToSpm2vO86O8fewL9asY6t+e0WX4ObIFKAdSo+wmvCjXY8aF16dAtGK5pCFh4RNR6e7oN8B9Vb8opLYYEZoVdjuho09MMwO3fcqpRAmTQL7qg+wJyXIIngMGcKI5p8it8kw34dMtCvtK+ZBgoQsrXpb5cj60xwV+V4TGXIlL1wwHyLboDgXHUa2vtjXmkxipVDTXceb30lFEd81QXJxFGHwWhDEWubCwYWxrLpkluYWleYdwe9/FB0hHrG/KgCkbUTIKuUE6yy5jyr7waBlUqwAhsWQqyohAAjxzGID8JjOaHB55m0nKjGETawin/LiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=brD1CXywV1KfTWwzQUD29fBn8g/3oAkTBlHI5hRtwgw=; b=XzkO90dg9OXRJDsGe3JLLgzshysMpfuQ1tAIgeVjncdScnoLBduEdopZ13oCXhHKy08l3KVJRc21D2I7kAxTJnU4mYvjr0pZP17BJUxqUTPM2R1WiOjk+fanoJrAJe+OYHm/hDVfyA7RVu3Kmxc4yiI6MO3RgTqMHGW66lxmQRI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by LV2PR12MB5727.namprd12.prod.outlook.com (2603:10b6:408:17d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.36; Mon, 10 Oct 2022 14:52:22 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c%7]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022 14:52:22 +0000 Message-ID: <378d8349-19de-b952-67ba-32243e40cca8@amd.com> Date: Mon, 10 Oct 2022 15:52:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2 05/24] net/nfp: add the offload support of basic actions Content-Language: en-US To: Chaoyong He , dev@dpdk.org References: <1665382142-21684-1-git-send-email-chaoyong.he@corigine.com> <1665382142-21684-6-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com In-Reply-To: <1665382142-21684-6-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0239.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::10) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|LV2PR12MB5727:EE_ X-MS-Office365-Filtering-Correlation-Id: 71cdba91-58b8-4ded-8ae8-08daaacf095c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0I7bkojobSV2ipM8km8Z1m4/TL5MJkPDRmz56tUZwGeKHtJRCSnL3QZT7Bvp+PEc9Ll1aF7Yot8B0uA5kJ7++Oks35OXlWX42MDE+ONRSkhDLrAf76n45RbeVGsfb1V+CvVwVsLRlcHsQDawLu1sJ3qN2zQJz39iaMwEWtOF5eTfRcXvNM13e1ZGNs7WkUP/VOvD4CDW0PDE88ObMsheLxb2fEw0UrpcW8hT1lkF3BmA1SC9SRx2PXbALUBJazV/t/ykLKcJy2rRIbQvCxwNSYaU6qj7uQ8mRWbP/S/En5DdLNAxdYgIED9PrY6Pb6Fb3fNDYDo2FYX0i6PGKF3tpc5MPZMRAEq/fWLa37zDkx/LYwCpJwEdl/7b1auFWSp4lXqJKQ62AY7RcLgAwuXLzhPMEEcRt4x/JmIT3je6exdEy4pOmeuThbZWBOUzOu+pzi59aYDDknq3PIVuuGp+tcmiZZa5NYCPYPKPniWwgqH+Pa06IXogxjQr7wSV1XKWchmeLwyoWqN7QSMMtb5p6tPW/XgqfDte0S/m1ffUIkCJaI2DtEqV3uL1d7tPeLHSwbaTRju8t6Xrqu1x3fHpDlk6116MjOvkQZaU76vf2ztyFOfsS9tw0KcNebecZwiAy60GcLyUFGCclDxWQytvZ5gSLTvivtoh8xGSZk5Qu+uOQZaKdMssWKdRWzS+yL1TWXcyO9QW7+qQxZEhOo8gyAmiTDCKV/EarzEPG9Gp8jWnov4RkB0IAH7WpAuVKTX/KT3yx2E4ZEQgHhYlLzEtzg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(451199015)(186003)(2616005)(83380400001)(4326008)(44832011)(66946007)(8676002)(8936002)(6506007)(5660300002)(26005)(66476007)(66556008)(53546011)(6666004)(36756003)(2906002)(41300700001)(6512007)(31696002)(316002)(478600001)(6486002)(38100700002)(31686004)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXh2KzJLTU9ZTkZoa21WNCsrUWNuOU8rU1UrTEQ2Z2lqd1h0UjhVWC92OS9B?= =?utf-8?B?OThwUE5iQ1F2dmJzVFErUVEvRnZkTkVNZSt1dXFnS2lrUncxTE9ET1MxTzcz?= =?utf-8?B?Y05XNTR5eW5kbXNjY3hic3g5UHROM3dPMjA5QThUVDlYQmEyVjdSMnVJYWw1?= =?utf-8?B?aDNQSTRZM1dmOFlxcGU0eUhZUkp5QUozMUxJZ2dGbWdjeVRqVFJXd0pNeTZI?= =?utf-8?B?Y0pnOTBRYm9jckFrR2h3M0VOdit1N1pvMy92R0tFZGZWQlBYZFpKK2tSam8v?= =?utf-8?B?RTgxRVQxUzFyd05ZR2hubmxzSmZ1RGRRbVd6dUdOVTQ1R1ovUTlMVm0wVWI1?= =?utf-8?B?UVRDUzRnVU5MaEFxUUpzVCs0ejY1aHdhZ2dkZ295aThJd2ROcERzb3ltcHNo?= =?utf-8?B?UU1MWUpPQ3F5YS9MdFFrUE0zNEtWVjNqN1ZxNk95aWRTVU93U1Zibitod01Y?= =?utf-8?B?Q0dJNnp6djliallCdFhhQk9jTFk5bmFCUXkwcy9kVTBhNkRpOVZlWW9XbU16?= =?utf-8?B?aERvekJ1RndjMG8wanNoVVNWQmhBNnNCY09aa2kyczRKcUJyQjZWSm50SEp6?= =?utf-8?B?dUtJcnRYWHF6K05RRlcyMkFjUWtXUmlNQXRpd2dhbWgyU2JsSCt2a09KZXhL?= =?utf-8?B?QTUwUC9NbmFwcndmV205M1pYeEpMOXFLWWpaMEIvQ2xmMmhOaWxoeG9yOUNn?= =?utf-8?B?eWl6UmlmU0VhUWpSTWkvOEpRK1cxd1N4cFYySmhHQzlGT2NKNys2MnludWRz?= =?utf-8?B?Q1VkVlRmempqRGdxa2FLU0ViRHdacTFDNnUxWWpWY3gxVDFVUDkwVC9CMHpT?= =?utf-8?B?eEpaYm5mSUFRZ2N6WDJZV2pXOGk0SVJFdjJZMEU0SlZORTAyK3NPR2UzaDND?= =?utf-8?B?QS96Zk1jRE82RzhXaE9qNVN4U2VBQkV0UU1UaTFTbW1JdUk2Zy9WdEtFTXFx?= =?utf-8?B?dWZJYzJPbnl1cVhlcFdKM3orcUtndk9ETW4rMUVObkMyYVh3T2ZlNXVVSTNu?= =?utf-8?B?cGtrNm9jNUI1TFBEeGlkajl0d0taZWdLUS8xaW5LOXE0TzE3NFlFbHJqcmRt?= =?utf-8?B?SkZUZm1aQU91OVJiNmNRVHVlbGFYb1hTSktHZHBxS3RGSWR5OWtxaFVnN2FN?= =?utf-8?B?RjdsV0t2dWsxbUhqZU5QcHVoNGJwbUVZYk5IcnA5NEs4TVArLzQ1elpOWExv?= =?utf-8?B?Y00wTnhRVlFZVmJ3Qk5obllzemxWZFpKQ05LRzZVWUozOHd0NnhacWRZOE1W?= =?utf-8?B?SllmT3BCSTY5b3RHdHkwYkRVQmZlK0NSRWRHWm1VN1FROXVJNEpsRVBQcG9M?= =?utf-8?B?OTE1RElRbDFrUFVERmdoanA3QmRJbmpKQ1BOMzU4eXd6V1d4QmdLSXdtem9T?= =?utf-8?B?cE5oVFh2bUJ1QzVvRlByMzdWOGdpcnQ5d0JhSVk4VWJ0T2hLbzJxcTJPb3oz?= =?utf-8?B?OUxvck1GSmdMRDRJbzdkczVWa0RnNlpSNjBIL3FQVGw2ZVBxcGZNVWhWR1Fv?= =?utf-8?B?Zk4vUmVoQUc5aGJvUVFwR2YrUjlWMG5jYWhpS3UwWXowbElXTGkyWmNtZTQx?= =?utf-8?B?K1FxYm5walBEVjhQcFFXc2EwZVpZWVJobUlyM0hvQS9MYSt1S0VkNzdaMTNX?= =?utf-8?B?aE02bzZ4dFJLb1BjYnZJOVpBWWhSREJOcDFjQ2FqUHk3Z3pXRDg5ZXVnWStu?= =?utf-8?B?bE11aHlGY2NSV1FSS3YxNFJ4bFlJa3A0YU5GZVA5cy9tRGQ4VVllc2JCWjJN?= =?utf-8?B?b0xJWXByS2JGVmIzVDNvZ21sVVpoK2hmalJjWEtwaTdKaXJwVENBd1ZEcjVo?= =?utf-8?B?Q2tHemxvenhyTk9IWC9EY0paWDZtTW52UitIbXJFdnFxbW1NNkNvY214and6?= =?utf-8?B?TGF6VVdjTllyVi9odjJEakZSR05jZ0xuUXpSOHB5MUxtcTRBN2tTWEdueTBM?= =?utf-8?B?QzNld3dtcmxJYzZyRXk4ajRURm1GSGpldkhjM1VBaEdDcFJzTkxnMDBaT1dW?= =?utf-8?B?Y2drMFg0aGxWRnh6WHVsS0lIMzZOT1VQbklJRy9XVkJ5QmRMOUozeFdTaG9S?= =?utf-8?B?RWVXTDV3T1hXL1FBTmRsZzVCQ3NoRFJPc253N214Ulkwa0N5VmtRY3IzQXN2?= =?utf-8?Q?dBGg=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71cdba91-58b8-4ded-8ae8-08daaacf095c X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 14:52:22.0857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /0cTA9gq6G7aAhDaf4K1ygIaRs2znxWPlDCY7iDVcLLGNMn9IICUKJuImec++NMn X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5727 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/10/2022 7:08 AM, Chaoyong He wrote: > Add the offload support of very basic actions: mark, rss, > count, drop and output. > > Signed-off-by: Chaoyong He > Reviewed-by: Niklas Söderlund > --- > doc/guides/nics/features/nfp.ini | 6 ++ > doc/guides/rel_notes/release_22_11.rst | 6 ++ > drivers/net/nfp/flower/nfp_flower_cmsg.h | 11 +++ > drivers/net/nfp/nfp_flow.c | 112 +++++++++++++++++++++++++++++++ > drivers/net/nfp/nfp_flow.h | 37 ++++++++++ > 5 files changed, 172 insertions(+) > > diff --git a/doc/guides/nics/features/nfp.ini b/doc/guides/nics/features/nfp.ini > index 4460cf0..194fe64 100644 > --- a/doc/guides/nics/features/nfp.ini > +++ b/doc/guides/nics/features/nfp.ini > @@ -29,3 +29,9 @@ Usage doc = Y > [rte_flow items] > eth = Y > port_id = Y > + > +[rte_flow actions] > +count = Y > +dec_ttl = Y > +drop = Y > +port_id = Y Are these actions supported? As far as I can see all done in the code is print log when these actions detected. For 'dec_ttl' even logging seems missing. I think better to document them as supported when actual support is added. > diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst > index cd22d95..ac0223f 100644 > --- a/doc/guides/rel_notes/release_22_11.rst > +++ b/doc/guides/rel_notes/release_22_11.rst > @@ -155,6 +155,12 @@ New Features > > * Ethernet > > + Add the support of rte_flow actions as follow: > + > + * Count > + * Drop > + * TTL decrement Not sure if this level of details is required in release notes, it can be sufficient that driver flow API support is added.