From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 42DDF5A6F for ; Mon, 19 Jan 2015 18:16:26 +0100 (CET) Received: by mail-wi0-f182.google.com with SMTP id n3so16207360wiv.3 for ; Mon, 19 Jan 2015 09:16:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=VMBgMq/yPdWeSHqlC4XRaBRVZ0g/3qmryI2PM2b6KJI=; b=TT+EOFjuaJg1dVYLCplGiFNe4WnUq3m7zAu050REzQ236qbjtTr+soYvLm0cCj/HKz Hf907DqD6814RBTH9HE+Ombfo7ePpGV4g6EKcIWnrBBtMkiPRurSctMkW1YqvjOalKRc mXytaYG508ANGYxO5p4IQYK1IL4r2icHLJYMzbOQKnzhpTUpyYCFJyfORNTpX6+p+AeX nxDC5NYd4Dk555Vj6rcvDjoqzEt3+xTyZ0J/4nfJqq9yiU8nAZuB1Zoy7DynommmBNvl A8bT6fd7gUg4RIGJXAF0v1Aex0rvxmH90UaloXknYcui9h2BfshBTswhfMVXotFqwmsQ JZRw== X-Gm-Message-State: ALoCoQmt3pmHg07ebVrrPB980BRbj1nXkbn75/S2wFiH3xE6herIKdY1VMgEf39IGoUoBiRqFUzT X-Received: by 10.194.142.234 with SMTP id rz10mr62384971wjb.118.1421687786075; Mon, 19 Jan 2015 09:16:26 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id dc1sm14917147wib.18.2015.01.19.09.16.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Jan 2015 09:16:25 -0800 (PST) From: Thomas Monjalon To: Konstantin Ananyev Date: Mon, 19 Jan 2015 18:16:02 +0100 Message-ID: <3790092.dknD3Zd4cr@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <20150114183928.GA28492@hmsreliant.think-freely.org> References: <1421090181-17150-1-git-send-email-konstantin.ananyev@intel.com> <20150114183928.GA28492@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 00/17] ACL: New AVX2 classify method and several other enhancements. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jan 2015 17:16:26 -0000 2015-01-14 13:39, Neil Horman: > On Mon, Jan 12, 2015 at 07:16:04PM +0000, Konstantin Ananyev wrote: > > v2 changes: > > - When build with the compilers that don't support AVX2 instructions, > > make rte_acl_classify_avx2() do nothing and return an error. > > - Remove unneeded 'ifdef __AVX2__' in acl_run_avx2.*. > > - Reorder order of patches in the set, to keep RTE_LIBRTE_ACL_STANDALONE=y > > always buildable. > > > > This patch series contain several fixes and enhancements for ACL library. > > See complete list below. > > Two main changes that are externally visible: > > - Introduce new classify method: RTE_ACL_CLASSIFY_AVX2. > > It uses AVX2 instructions and 256 bit wide data types > > to perform internal trie traversal. > > That helps to increase classify() throughput. > > This method is selected as default one on CPUs that supports AVX2. > > - Introduce new field in the build config structure: max_size. > > It specifies maximum size that internal RT structure for given context > > can reach. > > The purpose of that is to allow user to decide about space/performance trade-off > > (faster classify() vs less space for RT internal structures) > > for each given set of rules. > > > > Konstantin Ananyev (17): > > fix fix compilation issues with RTE_LIBRTE_ACL_STANDALONE=y > > app/test: few small fixes fot test_acl.c > > librte_acl: make data_indexes long enough to survive idle transitions. > > librte_acl: remove build phase heuristsic with negative perfomance > > effect. > > librte_acl: fix a bug at build phase that can cause matches beeing > > overwirtten. > > librte_acl: introduce DFA nodes compression (group64) for identical > > entries. > > librte_acl: build/gen phase - simplify the way match nodes are > > allocated. > > librte_acl: make scalar RT code to be more similar to vector one. > > librte_acl: a bit of RT code deduplication. > > EAL: introduce rte_ymm and relatives in rte_common_vect.h. > > librte_acl: add AVX2 as new rte_acl_classify() method > > test-acl: add ability to manually select RT method. > > librte_acl: Remove search_sse_2 and relatives. > > libter_acl: move lo/hi dwords shuffle out from calc_addr > > libte_acl: make calc_addr a define to deduplicate the code. > > libte_acl: introduce max_size into rte_acl_config. > > libte_acl: remove unused macros. > > > > app/test-acl/main.c | 126 +++-- > > app/test/test_acl.c | 8 +- > > examples/l3fwd-acl/main.c | 3 +- > > examples/l3fwd/main.c | 2 +- > > lib/librte_acl/Makefile | 18 + > > lib/librte_acl/acl.h | 58 ++- > > lib/librte_acl/acl_bld.c | 392 +++++++--------- > > lib/librte_acl/acl_gen.c | 268 +++++++---- > > lib/librte_acl/acl_run.h | 7 +- > > lib/librte_acl/acl_run_avx2.c | 54 +++ > > lib/librte_acl/acl_run_avx2.h | 284 ++++++++++++ > > lib/librte_acl/acl_run_scalar.c | 65 ++- > > lib/librte_acl/acl_run_sse.c | 585 +----------------------- > > lib/librte_acl/acl_run_sse.h | 357 +++++++++++++++ > > lib/librte_acl/acl_vect.h | 132 +++--- > > lib/librte_acl/rte_acl.c | 47 +- > > lib/librte_acl/rte_acl.h | 4 + > > lib/librte_acl/rte_acl_osdep_alone.h | 47 +- > > lib/librte_eal/common/include/rte_common_vect.h | 39 +- > > lib/librte_lpm/rte_lpm.h | 2 +- > > 20 files changed, 1444 insertions(+), 1054 deletions(-) > > create mode 100644 lib/librte_acl/acl_run_avx2.c > > create mode 100644 lib/librte_acl/acl_run_avx2.h > > create mode 100644 lib/librte_acl/acl_run_sse.h > > > Series > Acked-by: Neil Horman Are you sure there is nothing to change or add in the documentation? Maybe that explaining the space/performance trade-off would be a good idea. > Nice work Yes, great work! -- Thomas