From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 80AAE1B1FE for ; Wed, 3 Oct 2018 21:18:54 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2018 12:18:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,336,1534834800"; d="scan'208";a="79627381" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga006.jf.intel.com with ESMTP; 03 Oct 2018 12:18:22 -0700 To: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= , Jerin Jacob Cc: dev@dpdk.org References: <20181003081353.6679-1-mattias.ronnblom@ericsson.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <37910565-67d7-ff1e-aaea-65418be890a7@intel.com> Date: Wed, 3 Oct 2018 20:18:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181003081353.6679-1-mattias.ronnblom@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] event/dsw: avoid supplying -Wno-format-nonliteral to icc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 19:18:54 -0000 On 10/3/2018 9:13 AM, Mattias Rönnblom wrote: > Make the -Wno-format-nonliteral flag conditional, and only set in > clang and gcc builds, since this flag is not supported (nor needed) > when building with icc. > > Signed-off-by: Mattias Rönnblom perhaps simply: "event/dsw: fix icc build" Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system") Reviewed-by: Ferruh Yigit