From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nk11p03mm-asmtp002.mac.com (nk11p03mm-asmtp002.mac.com [17.158.232.237]) by dpdk.org (Postfix) with ESMTP id C828D255 for ; Mon, 3 Aug 2015 11:12:10 +0200 (CEST) Received: from [192.168.31.134] (250.229.126.124.broad.bjtelecom.net [124.126.229.250]) by nk11p03mm-asmtp002.mac.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NSI003031K39G50@nk11p03mm-asmtp002.mac.com> for dev@dpdk.org; Mon, 03 Aug 2015 09:12:10 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-08-03_01:2015-08-01,2015-08-02,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1412110000 definitions=main-1508030152 MIME-version: 1.0 (Mac OS X Mail 8.2 \(2098\)) From: HePeng In-reply-to: <6A0DE07E22DDAD4C9103DF62FEBC0909D1A660@shsmsx102.ccr.corp.intel.com> Date: Mon, 03 Aug 2015 17:12:01 +0800 Message-id: <379327D6-D2AB-467E-9F95-88F449B7EF4E@icloud.com> References: <1438392394-19653-1-git-send-email-xnhp0320@icloud.com> <6A0DE07E22DDAD4C9103DF62FEBC0909D1A508@shsmsx102.ccr.corp.intel.com> <179B898C-F03A-4250-8857-236CFC5274BA@icloud.com> <6A0DE07E22DDAD4C9103DF62FEBC0909D1A59D@shsmsx102.ccr.corp.intel.com> <470BDF91-6FAE-4605-885E-78F02F0F0FBF@icloud.com> <6A0DE07E22DDAD4C9103DF62FEBC0909D1A630@shsmsx102.ccr.corp.intel.com> <9375FD93-28D0-47AD-9CBB-CD099E3CD488@icloud.com> <6A0DE07E22DDAD4C9103DF62FEBC0909D1A660@shsmsx102.ccr.corp.intel.com> To: "Lu, Wenzhuo" X-Mailer: Apple Mail (2.2098) Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] [new]ixgbe:set txep.mbuf to NULL when calling ixgbe_tx_free_bufs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2015 09:12:11 -0000 Hi, wenzhuo, Have to check that because I really had the panic when compile = my code with dpdk 2.0.0.=20 Also I checked the code in the dpdk git repo. It does not check = the reference count, it just only calculate=20 the begin positions of mbufs that really needs to be recycled.=20 my code is retrieved from git://dpdk.org/dpdk = .=20 Thanks for reviewing. > =D4=DA 2015=C4=EA8=D4=C23=C8=D5=A3=AC=CF=C2=CE=E74:42=A3=ACLu, Wenzhuo = =D0=B4=B5=C0=A3=BA >=20 > Hi Peng, > There=A1=AFre 2 versions of ixgbe_tx_queue_release_mbufs. One in = ixgbe_rxtx.c, the other is in ixgbe_rxtx_vec.c. > What you shown is the one in ixgbe_rxtx.c. You can find the one in = ixgbe_rxtx_vec.c already has the sanity check for reference count. > Thanks.