From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 329FBC518 for ; Tue, 28 Apr 2015 11:58:40 +0200 (CEST) Received: by wiun10 with SMTP id n10so22356714wiu.1 for ; Tue, 28 Apr 2015 02:58:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=nJqY6hrwY8TJtVKC7a2yz0VZ99I34uKXzFR3yJztgSs=; b=Y6juM+lax2VtrjFpuwezpWMqlm/Lk1ZpYrcdLhElG/NzdsJ4T0DGWFIyTIanawaPqZ O9AMBsXd8cMLJjvkQPKuhBUiJN0meptHL5gVKWICfDGgy0My1h66nLdM0KgJupb+x82O 8cRFyjb4TypE5HqazHcVWtmeD6RDsau4cMEY9mzCH9pwCV0UIjRCgzt3maTtPZsYFhBu U7LzCnre9lUaQw6qumwz/RcI10t1ODSY1MdafKtOPy6JcsBSVVCLzfgvxarMN9z3IjVZ UVG5HUIxB16hOxUUckwzVcyfhvreYOp/7qwlURL6oXN7c5dPXopSIbLG46CdSUZhAnoy D+Hg== X-Gm-Message-State: ALoCoQliN8udTjMFrzWQD+yPOdQe0Th17dp2SdKoV6tZ+oivuE6W3ffX6MsBWaw3wjwhJpL7+9Uf X-Received: by 10.180.78.135 with SMTP id b7mr28013004wix.65.1430215120014; Tue, 28 Apr 2015 02:58:40 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id ez19sm15570103wid.19.2015.04.28.02.58.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Apr 2015 02:58:39 -0700 (PDT) From: Thomas Monjalon To: Konstantin Ananyev Date: Tue, 28 Apr 2015 11:57:58 +0200 Message-ID: <3795174.R42ZdTLc8c@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1424367859-28122-1-git-send-email-konstantin.ananyev@intel.com> References: <1424367859-28122-1-git-send-email-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ACL: use setjmp/longjmp to handle memory allocation failure at build phase X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Apr 2015 09:58:40 -0000 > During build phase ACL doing quite a lot of memory allocations > for relatively small temporary structures. > In theory each of such allocation can fail, so we need to handle > all these possible failures. > That adds a lot of extra checks and makes the code harder to read and follow. > To simplify the process, made changes to handle all such failures > in one place. > Note, that all that memory for temporary structures > is freed at one go at the end of build phase. > > Signed-off-by: Konstantin Ananyev Applied, thanks