From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA711464E8; Wed, 2 Apr 2025 10:29:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD741402B5; Wed, 2 Apr 2025 10:29:04 +0200 (CEST) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id 269C64029A for ; Wed, 2 Apr 2025 10:29:03 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4ZSJ2D1nZWz27hJH; Wed, 2 Apr 2025 16:29:40 +0800 (CST) Received: from kwepemo500011.china.huawei.com (unknown [7.202.195.194]) by mail.maildlp.com (Postfix) with ESMTPS id 2C8DF1402D0; Wed, 2 Apr 2025 16:29:01 +0800 (CST) Received: from [10.67.121.193] (10.67.121.193) by kwepemo500011.china.huawei.com (7.202.195.194) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 2 Apr 2025 16:29:00 +0800 Message-ID: <37b79e80-71a7-4a2e-b877-523c22504d07@huawei.com> Date: Wed, 2 Apr 2025 16:28:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] eal: fix uncheck worker ID To: =?UTF-8?Q?Morten_Br=C3=B8rup?= , CC: , , , , , , References: <20250321040316.104126-1-huangdengdui@huawei.com> <20250327090116.3357137-1-huangdengdui@huawei.com> <20250327090116.3357137-2-huangdengdui@huawei.com> <98CBD80474FA8B44BF855DF32C47DC35E9FB7A@smartserver.smartshare.dk> Content-Language: en-US From: huangdengdui In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9FB7A@smartserver.smartshare.dk> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.193] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemo500011.china.huawei.com (7.202.195.194) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2025/3/27 17:32, Morten Brørup wrote: >> From: Dengdui Huang [mailto:huangdengdui@huawei.com] >> Sent: Thursday, 27 March 2025 10.01 >> >> The worker_id may come from user input. >> So it is necessary to verify it. >> >> Fixes: a95d70547c57 ("eal: factorize lcore main loop") >> Cc: stable@dpdk.org >> >> Signed-off-by: Dengdui Huang >> --- >> lib/eal/common/eal_common_launch.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/lib/eal/common/eal_common_launch.c >> b/lib/eal/common/eal_common_launch.c >> index 5320c3bd3c..76313d5cdf 100644 >> --- a/lib/eal/common/eal_common_launch.c >> +++ b/lib/eal/common/eal_common_launch.c >> @@ -35,6 +35,9 @@ rte_eal_remote_launch(lcore_function_t *f, void *arg, >> unsigned int worker_id) >> { >> int rc = -EBUSY; >> > > Also check the lcore_id: > + if (unlikely(lcore_id >= RTE_MAX_LCORE)) > + return -EINVAL; > + > >> + if (!rte_lcore_has_role(worker_id, ROLE_RTE)) >> + return -EINVAL; >> + > > Although rte_lcore_has_role() checks the lcore_id and returns -EINVAL if invalid, "if (!-EINVAL))" will not take the branch to return -EINVAL here. So this check alone does not suffice. You could change it to "if (rte_lcore_has_role(worker_id, ROLE_RTE) <= 0) return -EINVAL;". > However, I prefer the separate lcore_id check, as mentioned above, rather than changing this check. > >> /* Check if the worker is in 'WAIT' state. Use acquire order >> * since 'state' variable is used as the guard variable. >> */ >> -- >> 2.33.0 > > > While you are at it, please also add "if (unlikely(lcore_id >= RTE_MAX_LCORE)) return -EINVAL;" checks in the other functions in eal_common_lcore.c where lcore_id comes from user input and the check is missing. > > > I'll modify it in v3 based on your suggestions above.