Re: [PATCH 5/5] net/cxgbe: read firmware configuration file from filesystem

[Ferruh Yigit <ferruh.yigit@xilinx.com>]

On 5/5/2022 5:29 PM, Ferruh Yigit wrote:
> On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote:
>> Add support to read firmware configuration file from
>> /lib/firmware/cxgb4/ path in the filesystem.
>>
> 
> Hi Rahul,
> 
> Can you please document the FW config file in the driver documentation?
> Please add:
> - Path of the config file
> - Content of the config file. As far as I can see from the code the 
> config file directly sent to the FW, does this mean config file is binary?
> - What happens when config file is not found
> 
> Also are these values overlap with the devargs that PMD has? If so what 
> happens in that case, which one is used, devargs one or config file one?
> 
> Previously there was 'cxgbtool' tool to send the config file, is this 
> method replacing it? Why not keep using 'cxgbtool'?
> 

cc'ed more folks.

This patch introduces a userspace config file for runtime FW config.

What do you think about this approach?
Should we formalize this method more, like introducing an ethdev level 
config option to hold the config file, which can be used for driver 
and/or FW. And perhaps with a defined syntax (yaml?).
Can this be an alternative to PMD devargs?

Cheers,
ferruh