From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6E13A09D3; Thu, 12 Nov 2020 16:06:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 152865928; Thu, 12 Nov 2020 16:06:39 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1E44856A3 for ; Thu, 12 Nov 2020 16:06:35 +0100 (CET) IronPort-SDR: QyZFqXICYrhkHFvmA6dHal+yJgmh3PoCyCTfXH7jwg5xhCl1UuFDTJS4eQifrS4gyyVPTB3Onj glgVEbmUXNNA== X-IronPort-AV: E=McAfee;i="6000,8403,9802"; a="170486042" X-IronPort-AV: E=Sophos;i="5.77,472,1596524400"; d="scan'208";a="170486042" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 07:06:06 -0800 IronPort-SDR: jo2uvvRbUNEtntG8xg6ZUAEkLIQ+dw8F/2HZvedr9aQ6Oz7cxLvtHaUZwVHsoL7uIOHdkD2O2P TkGjJFe15ezA== X-IronPort-AV: E=Sophos;i="5.77,472,1596524400"; d="scan'208";a="542288221" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.194.206]) ([10.213.194.206]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 07:06:03 -0800 To: Conor Walsh , jiawenwu@trustnetic.com, jianwang@trustnetic.com Cc: dev@dpdk.org, linglix.chen@intel.com References: <20201111130542.1949894-1-conor.walsh@intel.com> <20201111153933.1951384-1-conor.walsh@intel.com> From: Ferruh Yigit Message-ID: <37df8dd7-6bf4-374a-11b5-8373246e6dbf@intel.com> Date: Thu, 12 Nov 2020 15:05:58 +0000 MIME-Version: 1.0 In-Reply-To: <20201111153933.1951384-1-conor.walsh@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/txgbe: return changed to fix gcc compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/11/2020 3:39 PM, Conor Walsh wrote: > When DPDK is compiled with gcc 7.5 with the optimization level set to 1 > gcc sees the offset variable in txgbe_ethdev.c as possibly being > uninitialised. To correct this the final return statement in > txgbe_get_offset_by_id was simplified to return -1. > > Signed-off-by: Conor Walsh Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.