From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0A04A0545; Mon, 20 Jun 2022 17:05:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 465204069C; Mon, 20 Jun 2022 17:05:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9147340151 for ; Mon, 20 Jun 2022 17:05:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655737516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RCqDkNp2Lu4oAIemem7Bbl8ta9J/365becRwEaZlOL4=; b=SPM+k/V1dK/0x1LYyLFQwF5WI8gkAlwhFLJJg2N5117yZ52VanmHXrkyk/5WRutH3bLpTE 0FyD7uGIfGLvypQ0dHeCqa13pyO2/L7RxjFLSukZM4bS25sVNNR3LwkbxKV791GVc/n5Kt C+6hDd4t0/p+ensQaVW4aEjOLtNJBmc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-528-do7FjbM_MSWz5PXSEXc5tQ-1; Mon, 20 Jun 2022 11:05:11 -0400 X-MC-Unique: do7FjbM_MSWz5PXSEXc5tQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 368C629AB3E1; Mon, 20 Jun 2022 15:05:11 +0000 (UTC) Received: from [10.39.208.29] (unknown [10.39.208.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 938E7141510C; Mon, 20 Jun 2022 15:05:09 +0000 (UTC) Message-ID: <37e2554c-7b1d-4e30-8731-6cc6b468dea1@redhat.com> Date: Mon, 20 Jun 2022 17:05:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 09/15] vdpa/mlx5: add task ring for MT management To: Li Zhang , orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com, shahafs@nvidia.com Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com, roniba@nvidia.com References: <20220408075606.33056-1-lizh@nvidia.com> <20220618090258.91157-1-lizh@nvidia.com> <20220618090258.91157-10-lizh@nvidia.com> From: Maxime Coquelin In-Reply-To: <20220618090258.91157-10-lizh@nvidia.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/18/22 11:02, Li Zhang wrote: > The configuration threads tasks need a container to > support multiple tasks assigned to a thread in parallel. > Use rte_ring container per thread to manage > the thread tasks without locks. > The caller thread from the user context opens a task to > a thread and enqueue it to the thread ring. > The thread polls its ring and dequeue tasks. > That’s why the ring should be in multi-producer > and single consumer mode. > Anatomic counter manages the tasks completion notification. > The threads report errors to the caller by > a dedicated error counter per task. > > Signed-off-by: Li Zhang > Acked-by: Matan Azrad > --- > drivers/vdpa/mlx5/mlx5_vdpa.h | 17 ++++ > drivers/vdpa/mlx5/mlx5_vdpa_cthread.c | 115 +++++++++++++++++++++++++- > 2 files changed, 130 insertions(+), 2 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime