From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 19D2C6D45 for ; Mon, 11 Sep 2017 14:44:30 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2017 05:44:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,377,1500966000"; d="scan'208";a="899098173" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 11 Sep 2017 05:44:28 -0700 To: Stephen Hemminger , dev@dpdk.org References: <20170823154445.19494-1-stephen@networkplumber.org> Cc: Thomas Monjalon From: Ferruh Yigit Message-ID: <37f971b8-cae3-f486-a6d4-ff00bfab99a6@intel.com> Date: Mon, 11 Sep 2017 13:44:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170823154445.19494-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 0/6] remove unncessary void cast X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 12:44:31 -0000 On 8/23/2017 4:44 PM, Stephen Hemminger wrote: > There are many places that cast away the return value from > rte_memcpy(). This was a common practice in the Unix BSD days because > lint would complain about unused return values, but it is not done > in modern Linux style because it clutters the code. > > Maybe it was done for some Coverity warnings. If so, that issue > should be addressed with Coverity overrides not more code clutter. > > Stephen Hemminger (6): > testpmd: remove unnecessary void casts > bnx2x: remove unnecssary void cast of rte_memcpy > sfc: remove unnecessary cast of rte_memcpy > e1000: remove unnecessary cast of rte_memcpy > i40e: remove unnecessary cast of rte_memcpy > ixgbe: remove unnecessary cast of rte_memcpy My concern is if coverity complains about return value not checked and someone starts fixing them adding void casts back. So I will evaluate the patchset for next-net, so that I can run coverity on them before merged into main tree, and see the result.