From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43C984374A; Wed, 20 Dec 2023 14:46:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 353E2402DD; Wed, 20 Dec 2023 14:46:44 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 8208F402CD for ; Wed, 20 Dec 2023 14:46:43 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 33FAC5C01D0; Wed, 20 Dec 2023 08:46:40 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 20 Dec 2023 08:46:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1703080000; x=1703166400; bh=2q1rr1EsfuXO+GwDJpE1erWaYolKPYS3/JLvhoZfXB4=; b= S1gtWxZbylzJ0B3Md1tbSnNgxZJyx+W8Lf99kl4PE/hTPtbPWq5rUWfoezuGdYJN FDTtr9NU/+tmqKSh8KTioUjazZLApRIAtnHl5Udq3DymupjiD/8brfPt1OHyWAEI O5ms6aBLIqEMZwsOM6k9NWH4eiAN1ljrZJkFFXx7Pgc4UjSRGjvdQ8MLtBn3wi3X bYbugkEoM/d1KESy936pJgM/sWmjF0NvWQemeI1EO0/fi/myCwcNgzSFVW8YgeDB Zi8n/uihYlzLNBxAb48xe6s7P7+IK4DQmHXAHXQMPHj62ukGaBmqabuiWtUOVnNl ymbizapLWS40KZ8zrYurIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1703080000; x= 1703166400; bh=2q1rr1EsfuXO+GwDJpE1erWaYolKPYS3/JLvhoZfXB4=; b=5 cNZYF7e/nk5CK1RRt5dR5iQeAkPgfQdvd1YWmuqM4ivqPHwLdjKcSYSr5Q2jvMUM lwrPBAPP9i+V62ByGRLK3R29XXCpvLy40Ivpp1ymS9po00odSzqdLURCL/k7oKCy KbK1gb6R2ayAUfXWaLywY7UgL407dB/m1M6wsBGg/cQGS7dQHuHIjGCs1A7AlyMF voT+4WX2DILNQVn4wWv9dKKcgEwrB3EAoYAlzIqHs7hntcoOusHsDNiPzrJRArZ+ 82sTaxyi4DsZeICZgyVaw+oUiBROz0bJNa0wxqR/gDB9uryDGyQG029CfUE3VHih LlRB/VpcAnKnADb9e/2Jw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdduvddgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Dec 2023 08:46:35 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, ferruh.yigit@amd.com, bruce.richardson@intel.com, stephen@networkplumber.org, mb@smartsharesystems.com, Andrew Rybchenko , Konstantin Ananyev , Anatoly Burakov , Harman Kalra , Jerin Jacob , Sunil Kumar Kori , Harry van Haaren , Stanislaw Kardach , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Byron Marohn , Yipeng Wang , Vladimir Medvedkin , Sameh Gobriel , Reshma Pattan , Cristian Dumitrescu , David Hunt , Sivaprasad Tummala , Honnappa Nagarahalli , Volodymyr Fialko , Maxime Coquelin , Chenbo Xia Subject: Re: [PATCH v4 12/14] lib: convert to per line logging Date: Wed, 20 Dec 2023 14:46:33 +0100 Message-ID: <3800186.q0ZmV6gNhb@thomas> In-Reply-To: <20231218143805.1500121-13-david.marchand@redhat.com> References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231218143805.1500121-1-david.marchand@redhat.com> <20231218143805.1500121-13-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 18/12/2023 15:38, David Marchand: > Convert many libraries that call RTE_LOG(... "\n", ...) to RTE_LOG_LINE. > > Note: > - for acl and sched libraries that still has some debug multilines > messages, a direct call to RTE_LOG is used: this will make it easier to > notice such special cases, [...] > 129 files changed, 2280 insertions(+), 2279 deletions(-) It would be nice to keep RTE_LOG() only for multi-line as you do, and use RTE_LOG_LINE only in wrapper macros specific per library. This patch is using RTE_LOG_LINE directly in multiple places in libraries which do not have a dedicated wrapper macro. Would it be possible to introduce new wrappers for these libraries in this patch?