From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 49234A498
 for <dev@dpdk.org>; Wed, 18 Apr 2018 00:00:56 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 83FCB21DD5;
 Tue, 17 Apr 2018 18:00:55 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 17 Apr 2018 18:00:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=cBFsbqd2tXfQG7qjsihEx5szyf
 +GUCv9mEA1PL9AW98=; b=GmprBSpCUHXsbkcluk4VOE8tj+vH4gvX5sSoAYWn+m
 CmDl2O1Kq5HUd//BdZubsaDYmXC656O5/RA0yWiHMVPD7TMO9NqY/GwWYct5u1Zt
 TJ3Vu+Kh9p3n6MvLZECPgmABe5EQjNZLRfN1f8lV1dKtTXeUBv4Eqas9I65cSd3p
 s=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=cBFsbq
 d2tXfQG7qjsihEx5szyf+GUCv9mEA1PL9AW98=; b=PXYBzpfQYy5RVxnlUM43/D
 1ACumuKagfqqVqufelg30cAjsYQoP40rZ2Wv1vjcPpWkgjxgQOg4+ZINcbgclhG3
 4uep3QP7pMlH0CNiQBGvSXgqp6Jnqvvzr31FjIldeRqnwhwqmDC+2Tnv8xqanbPQ
 Du1r0EJEtXKw2gRpTpNIZpwhyxVtiKAsZS0ve1uRUvC4FImnxyDu9mrL9KhbDCkt
 xAu6x5iHLaItFdUrFLoXikt7EHpKWIaMDniO7obCJUpUkb5pcmTrfXjyrHxC14BZ
 UAN0Fv8Ukmf4dSNRrj685rJcQh/CfmSaICwzZWy3RzVM0Z5i3DR1Lstxaz+3g32w
 ==
X-ME-Sender: <xms:l27WWnqAE-BP_bWVi0_mCOMcPWZpe2ksgcndONIy7zCYvRCFvAYeaA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 86B40E43A6;
 Tue, 17 Apr 2018 18:00:54 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Xueming Li <xuemingl@mellanox.com>
Cc: dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>,
 Nelio Laranjeiro <notifications@github.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>
Date: Wed, 18 Apr 2018 00:00:53 +0200
Message-ID: <38100809.DTC8XynbX7@xps>
In-Reply-To: <20180417142425.159378-1-xuemingl@mellanox.com>
References: <20180409121035.148813-1-xuemingl@mellanox.com>
 <20180417142425.159378-1-xuemingl@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add supported hash function
	check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Apr 2018 22:00:56 -0000

17/04/2018 16:24, Xueming Li:
> +	/* Check that device supports requested rss hash functions. */
> +	if ((dev_info.flow_type_rss_offloads |
> +	     dev_conf->rx_adv_conf.rss_conf.rss_hf) !=
> +	    dev_info.flow_type_rss_offloads) {
> +		RTE_PMD_DEBUG_TRACE("ethdev port_id=%d invalid rss_hf: 0x%lx, valid value: 0x%lx\n",
> +				    port_id,
> +				    dev_conf->rx_adv_conf.rss_conf.rss_hf,
> +				    dev_info.flow_type_rss_offloads);
> +		return -EINVAL;
> +	}

Please use PRIx64 and test 32-bit compilation.

Reminder from this recent post:
        http://dpdk.org/ml/archives/dev/2018-February/090882.html
"
Most of the times, using %l is wrong (except when printing a long).
So next time you write %l, please think "I am probably wrong".
"