From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 999EB46A70; Fri, 27 Jun 2025 19:34:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4441A4026D; Fri, 27 Jun 2025 19:34:20 +0200 (CEST) Received: from fout-a8-smtp.messagingengine.com (fout-a8-smtp.messagingengine.com [103.168.172.151]) by mails.dpdk.org (Postfix) with ESMTP id A7877400EF for ; Fri, 27 Jun 2025 19:34:18 +0200 (CEST) Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 1009FEC0192; Fri, 27 Jun 2025 13:34:18 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Fri, 27 Jun 2025 13:34:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1751045658; x=1751132058; bh=X1ZNc37KBPF0AwqnbF4DbGm1zNs/G6Rtu9xlLYX+df4=; b= Bp6xCEpLfwdIvpem0rHR/2iGpwmPoLdXHK04eXqMrQ3622QBytNrOJSF9CUo9Qjg e/rAiiWkMMMuj48VaraBhqUCbCucQlrUif3NEgQC4XbZOQ6QmQlmvRVJWxAw/id+ gwGeerUzkvKTrIfUjxuu/EKKGT4HedL6cUUoW22zgx/H9Re7Cab3uF+wE3LXpKey JNI2QLOPqZ8TrN2yKwHokYnXmqTT6361q/3Z5pZIERsZP8upLBCLBGHMSRylpIym gSvhmKy7OQCCqqQKq53SLPVouvzqLohPcyaS3o/aHP5IP4to2EhU1mCkibaggWRh KHhyw0r+t0p4KJSLQWBApg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1751045658; x= 1751132058; bh=X1ZNc37KBPF0AwqnbF4DbGm1zNs/G6Rtu9xlLYX+df4=; b=P lxdPDhup26O193//hQyinm0nN2tTfMM4o/Dnlg/tqTTr87i12wwn7q6gvcF/97Fe JXu+lJDl2EHBnxPzQqqPD9YmHgxDMcap+YQk77Qcb9yvKtS65N5yanBc7IzYKBM+ w4PwMaNNBx2XRs6hauU47TDvt9O5Bt2baEoteRraLZSpB1rp3GbYWzOJtBuAeuI8 koYRj+Z1gDYNKF93oYP3lZYpRcgW71CtbaVvu+lkp54oILxyILLZ5rgffuL9uDvd KYennzBU2MIOKvnNkVGjJqhXSjInoCdLnIRXFiOVDFug5do/On81fXbTqgQLzeJX b/xtYRylSrmOkJognb+CA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdefieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghsucfo ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrg htthgvrhhnpefftdeuhfehvdekleelveffvdelhfelhedvgedtvddvudeuieevtdfgjedv udegfeenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgv thdpnhgspghrtghpthhtohepledpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepmh gssehsmhgrrhhtshhhrghrvghshihsthgvmhhsrdgtohhmpdhrtghpthhtoheprhhorhgv thiilhgrsehlihhnuhigrdhmihgtrhhoshhofhhtrdgtohhmpdhrtghpthhtoheprghnrg htohhlhidrsghurhgrkhhovhesihhnthgvlhdrtghomhdprhgtphhtthhopegsrhhutggv rdhrihgthhgrrhgushhonhesihhnthgvlhdrtghomhdprhgtphhtthhopehmrgigihhmvg drtghoqhhuvghlihhnsehrvgguhhgrthdrtghomhdprhgtphhtthhopegthhgvnhgsohig sehnvhhiughirgdrtghomhdprhgtphhtthhopehtughushiihihnshhkihesmhgrrhhvvg hllhdrtghomhdprhgtphhtthhopehsthgvphhhvghnsehnvghtfihorhhkphhluhhmsggv rhdrohhrghdprhgtphhtthhopeguvghvseguphgukhdrohhrgh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 27 Jun 2025 13:34:16 -0400 (EDT) From: Thomas Monjalon To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: Tyler Retzlaff , Anatoly Burakov , Bruce Richardson , Maxime Coquelin , Chenbo Xia , Tomasz Duszynski , Stephen Hemminger , dev@dpdk.org Subject: Re: [PATCH v3 1/3] eal/unix: fix log message for madvise() failure Date: Fri, 27 Jun 2025 19:34:14 +0200 Message-ID: <3811264.esFFXGZ24q@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9FD52@smartserver.smartshare.dk> References: <20250610131348.248800-1-mb@smartsharesystems.com> <4027143.U75o6juQT5@thomas> <98CBD80474FA8B44BF855DF32C47DC35E9FD52@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/06/2025 18:47, Morten Br=C3=B8rup: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Friday, 27 June 2025 17.56 > >=20 > > 24/06/2025 10:03, Morten Br=C3=B8rup: > > > In eal_mem_set_dump(), when madvise() failed, an incorrect reason was > > > logged. > > > > > > Signed-off-by: Morten Br=C3=B8rup > > > Acked-by: Anatoly Burakov > >=20 > > We need to track the root cause with Fixes: please. > >=20 >=20 > I already looked into it, and the bug was there from the initial commit o= f this function: > https://git.dpdk.org/dpdk/commit/lib/librte_eal/unix/eal_unix_memory.c?id= =3Dc4b89ecb64eae773337f3b1367dd8b1f09737f2e If we don't track this origin in the commit log, it is difficult to know. > I didn't think the Fixes tag was required if that was the case, but I may= have misunderstood this. Yes we must be explicit and add it. > Also, it's an insignificant bug, so no need to backport. A bug is a bug. LTS maintainers or anyone maintaining his own branch will decide whether to= backport.