From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E9F6C2C6D for ; Thu, 25 Oct 2018 01:14:57 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 780512210C; Wed, 24 Oct 2018 19:14:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 24 Oct 2018 19:14:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=lEDZUC1+WosTNdIOtd7ccoutNIor1tFBZbiKHVeD+vM=; b=MaPAS4ESShZl PB7yep8DPuEE7g3HV+95TqNAYuFIEmFXZy/+tnWIapLYA+YOU2WMbk5sSWfGyb4U ryI2Zq3qng1oIGQYtHc1H/5D4tEHKZax5hToq3bLmj4Gvbv9q/o89I27nW3j2IJx DxJNg6+mw6J9H4jVUgAZg6pM2oYTeqg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=lEDZUC1+WosTNdIOtd7ccoutNIor1tFBZbiKHVeD+ vM=; b=laHhJDfVTZU2o5gBMVHi0g8AolkPipzM5AUV88DSlgdNjCJTlYGHp8hhi zAg95EOmehYiLLYQxIqDknp3Orjor+NFx66qoHkeCiWKO8Q4XUN4NluPb9lPdpXN 9PezAo43h0Skw+nVKOuFCtyhb+sp6tb+PHCHVTKvwsbhiWylkqNLWXwA9hhh4FvD SoLSfgGwOE1aEaVLy9Ria/bZ/kzFDJ6ITmtbqLXEJyi8CqVUVsW+NDcrHKVVEAzW +IGP1Bs/rwOWsFFk5p0TgjnQG9VjsLI28wztEF1vdXq/IeuEtBAmolXPHf5ptZaw j2gOiA/FO2MNN5wIX/0Ye79Etmjjw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DD990E4122; Wed, 24 Oct 2018 19:14:55 -0400 (EDT) From: Thomas Monjalon To: Jeff Guo Cc: dev@dpdk.org, Ferruh Yigit , stephen@networkplumber.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, shaopeng.he@intel.com, helin.zhang@intel.com Date: Thu, 25 Oct 2018 01:14:58 +0200 Message-ID: <3811387.JjXV5aRat7@xps> In-Reply-To: References: <1534502916-31636-9-git-send-email-jia.guo@intel.com> <33442113-1445-21a4-3c1b-6ddd5e7586d4@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] igb_uio: fix unexpected removal for hot-unplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 23:14:58 -0000 22/10/2018 13:13, Ferruh Yigit: > On 10/19/2018 9:35 AM, Jeff Guo wrote: > > > > On 10/19/2018 12:06 AM, Ferruh Yigit wrote: > >> On 10/18/2018 7:27 AM, Jeff Guo wrote: > >>> When a device is hot-unplugged, pci_remove will be invoked unexpectedly > >>> before pci_release, it will caused kernel hung issue which will throw the > >>> error info of "Trying to free already-free IRQ XXX". And on the other hand, > >>> if pci_remove before pci_release, the interrupt will not got chance to be > >>> disabled. So this patch aim to fix this issue by adding pci_release call > >>> in pci_remove, it will gurranty that all pci clean up will be done before > >>> pci removal. > >>> > >>> Signed-off-by: Jeff Guo > > Acked-by: Ferruh Yigit Applied, thanks