From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2825841C49; Tue, 14 Feb 2023 12:03:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B786940EE4; Tue, 14 Feb 2023 12:03:22 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 9802C40ED9 for <dev@dpdk.org>; Tue, 14 Feb 2023 12:03:20 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 5C6D73200907; Tue, 14 Feb 2023 06:03:19 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 14 Feb 2023 06:03:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676372598; x= 1676458998; bh=3LVXINuaPOjm1bdl0+nS2teymXX0mwS5hwWmftTXwwE=; b=h fDCUU+07rP8RVSAKkxPmP9mBndwhVyC/+eNFR2DJY518sKVQHv/j4FYLgqo5gTpF 7d4zOwRF1vP3dPirZ/8w9RFG9Vmy/15wdiAIZ9CkB70NGU1Nd78sg+Ghcmr3kAsl kS8Vki48G6WlO0vYvUdT4Y2d3LSuaTOT/JzfX8YyTHAMs+lm5Pp4xJttn07Xy6Mg C9oAKysjrX7Ime8BJxPn4xQDqN4rnyY2ZI6C565pkhZr073AJC2rx0JFuslzDyj1 YAfRpLYDFbEVbZxZSk/znHs7kmTQyh1Q7oopMiDPcDDaHyoFqW9ljI0ChqyZd6Lj kdMn5EzgP2IYkXEHe9c8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676372598; x= 1676458998; bh=3LVXINuaPOjm1bdl0+nS2teymXX0mwS5hwWmftTXwwE=; b=L pJrQG/h3Tw9qHz9j2c8Zlv6EuVqBPdQxrB5aRTqbHLPUelJAbwSFaVSPr5nv5iFC e6rE8Oce4uqX/t8TW+axpPwWUGtq9XIZmjlIb/DiAKooSypYzdavhTqnjxx1jmb5 WAZEj6i0ZGUBypXiq1M62ErrKYCqseDsrGz0wPibgiQYDLh8F8UyOPA19ai8j2tj 4S3e+zmd2KAT4Lg/qMQSXLJayiPFbFHpgQCQvTgi3r0o3OogZwtffMbNip972wDW JeNOCpprzH4fIlBos+b4BCZ9MfNK72VU7ktHgwMWarrSovg1C11fahMVWgVwEtAs FA/Vhb9KOXVWWKk2sckLg== X-ME-Sender: <xms:dmrrY7PUt9IlGtFm0oUxXrE7aQsgOI4FY0PjW5KRdoBp0a2cWbtodA> <xme:dmrrY19-WHid4aGmRl2Mc2UsUzE0BG64Ko6N-9Yvx57_7t89ndlASd-KZShYrjpRW 85_be23UWIiielRCQ> X-ME-Received: <xmr:dmrrY6SAK5j1lkRVw68JFbxe5GfbmGNyAcPimsw7FepgTerUN82o15-vOLGYTjNDSEwRmNhU5qGYBL6MZvS08mrANw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeifedgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:dmrrY_uJLPTlO1KYnt8UqnVIDwU3vKP7jC2Bvfr3Q3prnucUD7LG8g> <xmx:dmrrYzcGlhRyIYd10COKuj53jwJnfzeECX1yOd6woFbCfnsvHSljBA> <xmx:dmrrY72rEHtNvIlaYR0t00-yN2dF82WoXNQDueO5rgVGQ8XJBerMDQ> <xmx:dmrrY_7ryVI-aBEdnZsW7TfKQV4wXj735W8v5Y36idnV_KO4KklkTA> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Feb 2023 06:03:17 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Ke Zhang <ke1x.zhang@intel.com> Cc: qi.z.zhang@intel.com, qiming.yang@intel.com, dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com> Subject: Re: [PATCH v2] net/ice: fix ice dcf control thread crash Date: Tue, 14 Feb 2023 12:03:15 +0100 Message-ID: <3820540.fW5hKsROvD@thomas> In-Reply-To: <20230213071648.326123-1-ke1x.zhang@intel.com> References: <20230208083005.290571-1-ke1x.zhang@intel.com> <20230213071648.326123-1-ke1x.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 13/02/2023 08:16, Ke Zhang: > --- a/lib/eal/windows/include/pthread.h > +++ b/lib/eal/windows/include/pthread.h > +static inline void > +pthread_exit(__rte_unused void *__retval) > +{ > +} Please don't add more shim layer. There is a new layer rte_thread_* in lib/eal/include/rte_thread.h