From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D852454EF; Tue, 25 Jun 2024 13:27:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED946432DC; Tue, 25 Jun 2024 13:18:56 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mails.dpdk.org (Postfix) with ESMTP id 3AF9842D2B for ; Tue, 25 Jun 2024 13:17:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719314261; x=1750850261; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tHE3XUSN5ATfol0iqZnjeKfCEqBwrH1u/PjLzMLAsrg=; b=D+rd8a7+DHMIvR6f3xLuhcvYPzNMJKya8fKF3XEHz3Y3IXz7++21fcN2 Td7rp9vMcucKSvDX1amuMjaLn4Z8V13SZJ3wtZ4yeNpvfJLsw/wnGeVXh /1npnBvPUycKevLs8rYNx4o8zccvMxQ6WpvL3uS7VTtB6y9cAN6uUZJ6d FpmI1Q/n5IYJ59NXDFeFtQXLYQmQYBW+yRP81WJGzi7GTJwnujGNKhoW3 Kr7ipn1cQWNX2ySdovXwKHvPf6caUl6pcFuoRG60ABuJsau/cPe1hXJgd ddSjROB2PKwIHN+peFENC7ny9ZPareHdQYcRN3DilnFUT9sbGFyypiXK9 w==; X-CSE-ConnectionGUID: jDvc46AcSUuaUagvaijOOQ== X-CSE-MsgGUID: 9nkQSkxFS1ODs7yIvEwMag== X-IronPort-AV: E=McAfee;i="6700,10204,11113"; a="16080542" X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="16080542" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2024 04:17:40 -0700 X-CSE-ConnectionGUID: U9ARzZwcS/GUdlUM3PtC/A== X-CSE-MsgGUID: 7xZK17HGQU+Y258YeMy6Dg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="43719649" Received: from unknown (HELO silpixa00401119.ir.intel.com) ([10.55.129.167]) by orviesa009.jf.intel.com with ESMTP; 25 Jun 2024 04:17:40 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Dan Nowlin , bruce.richardson@intel.com, ian.stokes@intel.com Subject: [PATCH v3 099/129] net/ice/base: support E830 in Topology AQ command Date: Tue, 25 Jun 2024 12:13:44 +0100 Message-ID: <3820809585209d3113eab5ea04c3d85c7e038b8d.1719313663.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Dan Nowlin In E830, regarding the Get Tx Topology AQ command, there is a change in the way that the RD bit must be set. For E830, the RD bit must be cleared. Setting the RD bit for the E830 device was causing the Get Tx Topology command to fail. Fix it to clear RD bit for E830 device. Signed-off-by: Dan Nowlin Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ddp.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/base/ice_ddp.c b/drivers/net/ice/base/ice_ddp.c index d5d81db949..f82e5a387f 100644 --- a/drivers/net/ice/base/ice_ddp.c +++ b/drivers/net/ice/base/ice_ddp.c @@ -2298,11 +2298,16 @@ ice_get_set_tx_topo(struct ice_hw *hw, u8 *buf, u16 buf_size, if (buf) cmd->set_flags |= ICE_AQC_TX_TOPO_FLAGS_SRC_RAM | ICE_AQC_TX_TOPO_FLAGS_LOAD_NEW; + + desc.flags |= CPU_TO_LE16(ICE_AQ_FLAG_RD); } else { ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_get_tx_topo); cmd->get_flags = ICE_AQC_TX_TOPO_GET_RAM; + + if (!ice_is_e830(hw)) + desc.flags |= CPU_TO_LE16(ICE_AQ_FLAG_RD); } - desc.flags |= CPU_TO_LE16(ICE_AQ_FLAG_RD); + status = ice_aq_send_cmd(hw, &desc, buf, buf_size, cd); if (status) return status; -- 2.43.0