From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54BDF423B8; Thu, 12 Jan 2023 17:28:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B42042D4F; Thu, 12 Jan 2023 17:28:36 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 858EB40FAE for ; Thu, 12 Jan 2023 17:28:34 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id E4D773200911; Thu, 12 Jan 2023 11:28:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 12 Jan 2023 11:28:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1673540912; x= 1673627312; bh=SFHmiV5EywEgl4pe9JuC+8fiKP/4Xpuuz7S0ouN097c=; b=l 12JpP52zHeposlOW/CmhLiuSdVrAZMrlPskYHj1caNXMNHb8FAmguZUTrWrvMtvP jAH+P+MgNiDQHP+MTrix8D0a3GpX3IvkEQxT/dxwx1St9+wD6kEjCbpvDjX3bo2O WM3nhzZJbZ6nCauJM2TGRRXwJw9VGZuH112eSlH0C1dNUEQdE2+s/pexJ1vMmQ9W tIn8TQx+xKxSn+PTFBM+qAJIiB6Mkjt0jJ3CwlQAh46ZYZyHUGtq/ZjWfQhS7VYZ JhiUfXyst9ZKEOHi90IDraWlVgvYcmvzZk+yEMUAdOZlNhSxb8ylB6Z0yDn084jy exrvjyQX0E9WTqVgg9NZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673540912; x= 1673627312; bh=SFHmiV5EywEgl4pe9JuC+8fiKP/4Xpuuz7S0ouN097c=; b=a KBq+DkP0dU//j9URlpFE56mOeTkTavKc+Gzmmkw4fC4ypZgeH0F1ZoEY3eHCk8up mB4PxuT+BZbjbDsByN/APRygtmQk14M2Zod824FIdnnpdQvUkq/otSBkDwdPmv1B u5n+P07nEdgCveQ7zNt6esSDtOPmIJouLuNqAWVpfpYLiadoAt9jcH0wYZ0POAN/ CAaK4e9lTYR0pxL95AMqyrw/dE7NZ1jiL/cNdI1EPDcLlYxxSoNN2zh/y5JOk62D 8KPXkxnRsjTy/EoVjcD+2EnrDVhFPjTJxpW5z2JMcmIiijW/LwvKFaebWRE07ybn 7V+/eSdNgzIRGfV+86BvQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleeigdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Jan 2023 11:28:30 -0500 (EST) From: Thomas Monjalon To: Akhil Goyal , "Ji, Kai" , "De Lara Guarch, Pablo" Cc: "dev@dpdk.org" , Tyler Retzlaff , "dev@dpdk.org" , David Marchand , "Dooley, Brian" , "Power, Ciara" , "Mcnamara, John" Subject: Re: [PATCH] crypto/qat: fix build Date: Thu, 12 Jan 2023 17:28:29 +0100 Message-ID: <3821853.R56niFO833@thomas> In-Reply-To: References: <20221230210728.86920-1-thomas@monjalon.net> <23216321.6Emhk5qWAg@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/01/2023 17:16, De Lara Guarch, Pablo: > From: Thomas Monjalon > > 12/01/2023 14:22, De Lara Guarch, Pablo: > > > Hi Thomas, > > > > > > From: Thomas Monjalon > > > > 12/01/2023 11:32, Ji, Kai: > > > > > Ok, a long story short, this issue should only occurred when > > > > RTE_QAT_LIBIPSECMB is enabled. > > > > > It was intend to remove Openssl lib dependency in QAT replaced > > > > > with ipsec_mb lib, but the work was partially done due to > > > > > limitation of ipsec_mb by the time (FIPS certification) > > > > > > > > > > I'm happy with current fix and please cc: stable@dpdk.org > > > > > > > > I'm not happy with this fix. It is a dirty workaround. > > > > It would be better to have an #ifdef in ipsec_mb. > > > > > > > > Also I would like an answer to the question below. What triggered this > > error? > > > > Is it a new thing in the lib ipsec_mb? > > > > Why defining AES_BLOCK_SIZE while IMB_AES_BLOCK_SIZE can be used > > and > > > > have a proper prefix? > > > > > > Apologies for the late response. > > > > > > This macro was renamed to IMB_AES_BLOCK_SIZE, as you already know. > > > The problem is that, for compatibility reasons, we had to keep the old > > macro as well. > > > However, we added a compile time flag to remove these legacy macros, > > > for exactly this reason (NO_COMPAT_IMB_API_053). > > > > > > I think a solution could be to use this flag in QAT, so the legacy macros are > > not defined. > > > > > > I will send a patch to fix this. > > > > OK good, so we can reject this patch? > > > > Well, this patch is merged already, but mine will revert it and add the new flag > (pointing at the other commit to be fixed), so that should be OK, right? The patch was merged in the crypto tree but we can discard it. Akhil, please remove this patch from your tree, thanks.