From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9C5242C44; Tue, 6 Jun 2023 23:37:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A78B4067B; Tue, 6 Jun 2023 23:37:16 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2073.outbound.protection.outlook.com [40.107.93.73]) by mails.dpdk.org (Postfix) with ESMTP id 2093F40223 for ; Tue, 6 Jun 2023 23:37:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RutIeDx3x0+iokthS9qjpHfMCeImNYoJFTdw42+pmV3jM+WlR87FChUKs96007nkvIPJYCfh0wr0UV0zOGw5HIEKAmDGF2eqajuEAmPP4yQoHCUAyEAUr71EkmE+I0qCdHENmDEdbYOPtkRL4L1jT1MQ1yAfCPDxYF9pZgPVhGgiLPMDn6YTdqUczteDAjve+wcnRYjR5uytgTJGLoLAW0ax6P/yIt5XdUO6FnIJ3CqLRqKcrc5r74TEWzzEsVlA7wV7hL6mzs/3Yqe7YFQ5V9Rxtn7AbQO0/AjrLW3a1gbwY+lNKeqqwSxbQEbWCo8kSODRnNyEG2oCknOh51vQ1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N/6KC4bZRhaEg5qhp/EevX9m1zHx9uQDVMqmbCaBpGg=; b=O4Vp30+IL+iQq4DS4qwSbfE6LkGMFAdoSbQZBZ+zIAS7J1o2vAAP7cF1Wn5vf2S/xHcFUKYEKowwMTLirE15q9oCAKDvxvGHBnzfP4VLdwOnXmbu14vhghE7Ty1Yirj+k+BIBN50cpZ69/89zvuA22ubsrAVsQL4zZH6hqdxBYX97VNzx89LUGLqyVnRxjzk9bNCo3xLEQpz8OsacYyDauv3CVU6J5KUoRD4hEGhr2dd0PSNPNtCldOOIsXOBLV05xg5T6Sm8mEKSe+IkBxDB5/6nbJCMwD0ndb/oWHIb7Et+G6/rOWZzQsrb8PMurtGuoJfWBbsCdWHcavXAquQZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N/6KC4bZRhaEg5qhp/EevX9m1zHx9uQDVMqmbCaBpGg=; b=WZ9ZpZkhl1b2VGq2WEO2ilQWon6uIOXueFvCOd4cMNuwB7fWWMGKrfu2XEyj2E5o9k59kz4YkKA0hKxSqEpRN5aRUaalKOqD7p7wa9Ng4zbLGhGYRoJnMvIEtQRXSKbyM5NZYvak9g8cavtrX5XdyKzaW0kQsbOnQ72xy0QmPYY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB7353.namprd12.prod.outlook.com (2603:10b6:510:20c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.22; Tue, 6 Jun 2023 21:37:10 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::cf07:30f7:a92a:c53b]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::cf07:30f7:a92a:c53b%4]) with mapi id 15.20.6455.030; Tue, 6 Jun 2023 21:37:10 +0000 Message-ID: <3825b2b1-c40f-6bdd-4271-7b56c60795ac@amd.com> Date: Tue, 6 Jun 2023 22:37:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v5] app/testpmd: expand noisy neighbour forward mode support Content-Language: en-US To: Mike Pattrick , Aman Singh , Yuying Zhang Cc: ktraynor@redhat.com, dev@dpdk.org References: <20230602182928.1717802-1-mkp@redhat.com> <20230606211242.2855795-1-mkp@redhat.com> From: Ferruh Yigit In-Reply-To: <20230606211242.2855795-1-mkp@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0043.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::31) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB7353:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b67cc09-9d3e-48a2-0b3e-08db66d62ef0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gbcYMYTFTyzD7MOkZxiVjJA50YUA/5KDZh2SdRjsNrG6V50cyJruPJdRvGpBazXmEQJ+oWdLYK5yNSbgIp5YzbrHFXDONyJhh/5Zq+VzHUCQ8aU9MRGbp5XMIEOs6KBHCYm4LgObJ96ydNkfaf9wSMgnGQxVydD12LT/OEfodzbwZHqqmTMul+l8UZorAZXqPhqjEYasAJLHT7+cqYyuzI8ivg/f8Yx38gl5HCiAXCaS6EyV/ZaTsrKK6U+bObxfV5oUJu9U2ZLCcSsdr+4KDWrFM95fEC6vgHhb1qwtOowH07mWFy2QAv+9zxqOTNSA/Wa6NdOmcoorAx6OkBXl8mX6faGwd5g2iCzWGycCjGZp9XDV06ER7NJ14Gw1KxHKTrVttvDT1qU9QqNoqwSvf9FCYKKmxpW633cWhQYbRNNnG8r3xMbpD5/O9WrQhPuwXmR0CfBr+bFuc1W10YHsPo3S9yqyU3Wa9rkwU7aJXejRjzmyk4ZHUffU5XLj9GFGu7idykh255c51ot35EC0KOPO7M3x2+K8qCrCq/9MPfljaJbR63qr1jjugbjrRWs35pYiQc6PN68MuoDjTzCpLk9Jkc1QUPVv1gGXUT4YGGScWYO5LMg488Q6WryghTIA8yZzFfZoWlV4n9M3++hWOg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(376002)(366004)(396003)(39860400002)(451199021)(478600001)(186003)(110136005)(36756003)(6486002)(6666004)(26005)(53546011)(6506007)(6512007)(41300700001)(83380400001)(316002)(38100700002)(4744005)(2906002)(5660300002)(8936002)(8676002)(44832011)(31686004)(31696002)(86362001)(4326008)(66476007)(66556008)(66946007)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a21OdXFWNnluT1cyTkhBemprTmJKMzVPUktWZ2xvZU5xSVh5cFJzdnRpUU5Z?= =?utf-8?B?eCtFeUFtMGVEQmw5QjN4bzV2VWlBdENCMlFpSjY1WXJpbFBoMWhlTWlMRjh6?= =?utf-8?B?YmNZeTFVT21aaVJ1a2d5ZDJaZ0l3NE9sWUlUQ2drU09kZFRtbjJqbVRGMWpK?= =?utf-8?B?dFlQWlZTTFVidjBDUXQ4ZVV1MGxDbkVBejhuc0ZYM0tOcHlWQzZGS3ZwTThZ?= =?utf-8?B?YlNDYnpPWDROSUhCU3VrR3pjUll5OFdrZkVIdXIrRnNsOHR6TDRUbmFxZUdN?= =?utf-8?B?Uit1TVZyQzZKbDMzMlBiSE40UVdHNHAxbUZwYUVlZ1BseGMwNmJBK241VXVG?= =?utf-8?B?S0ZwMEI0UzNuR1J1anZ5THdpOG5EODJDSzlhTnQ5T0pWYkZLZFV0YWdDVkp5?= =?utf-8?B?V28vRnM5a0FNNVFERk5iMVd1SlBKWTQyV0NxQWZXRWc0M2ZhUXVtYkZxQ0R4?= =?utf-8?B?eFRTdmJwQU9NMDZETzhSdHNKbGlzcHlPY3dWa0JVa1ZXbGNUOGhSUHFoTkFY?= =?utf-8?B?emQ2Zmtia0w4VkcvYjN0TkpYTXpaTGhiRmt5SzYzV3NyVTQrOW1YSWF3SnM4?= =?utf-8?B?MUt2ZTVScEVlRlZWWGF3ZXEwTTdPSGlrTnFMUlFGVUZxM2xXd2lnVEVnVk5a?= =?utf-8?B?SzBZaEYyREtRS0RxVGxpKy90ZzQyc0J0aXRqSmlvR3EvVkJTdmNWeGdHMlJD?= =?utf-8?B?c3NyYThKc3QyM25KWTlDZnhhN05PcFBVeUxzd3JZQTNXMlVMdG8wRUtlR0JM?= =?utf-8?B?NHhKTEFQUTNLb3kzZHdYejlvRUo3LzhpcHBqNUJUUzNMTWlnbzNXRWNVOUtN?= =?utf-8?B?V01kMmxaZHlPcStJV2R5d1dqM2JyenRwWXFCSkhxRE5na2ExaTgyL0M4TTdE?= =?utf-8?B?QTMyeDJSbW83YjJWVGVYR3hIYlcxRUxPUU03R21Cc1BnSzNQVGpkd0lzbkxv?= =?utf-8?B?NVBQUE5ZZ1JpZ0kzQ2dFRUdEVlFBVS9FMjc4Mlgrd0dHWTc1YndQTHlqTU9B?= =?utf-8?B?VHZKOE1FemVWSGQwdC85Z0o4US91YW42NHJlK0JFajF6OEd4RFZzZlNRbUk4?= =?utf-8?B?a0JXaW0yeGhhUTB6cDlYQnRBaENLelZiNjR0WUErN05aWUtMczNUdmN6b0t5?= =?utf-8?B?aFptSENsNmVlSkVjeFo1dW5LdDBGTnNEUkJZVVk5d2hIVmVINDVabUFjQkVQ?= =?utf-8?B?WUhnQ042UENYVzhzSWliUkwwNUlqNmhRd1RLZUFMZGM5bjBuZlRDVkZzcnFw?= =?utf-8?B?eE1oeEdPYUgzL0xLOUhyNWNkMjJSbUxHNk9Yb0JqWmhtaGxtS3ViR2JjWi9y?= =?utf-8?B?UXJrZVpKNTNUWnBobzlvY3Q0UHg0ZXNVU3EvaHZRUEdYVmNWVmlTdFJCNEdm?= =?utf-8?B?eVY4VENZTmx5SFY1bHdtc2pvNnFYNHZuamdRWi83anVVTWpoSHNvUWQvMUZF?= =?utf-8?B?b2dwNkJvdW42eEVGWXFjRFJxb1VhaHFmTXpjaGIvcmFzVXMyNitIeEdFdEg4?= =?utf-8?B?MmVaRHA1Vng5b1YzNzF4cGczbzI1S0E0ZWk5bm5EQkgxaXBRVWd2QTduRmRz?= =?utf-8?B?eGdWczc4S2lOSmszNjJyVUZ0TnFUaDVZelN1eGs5WmZ4N25qdjg5VEhYWnVC?= =?utf-8?B?QThRNy9TODZWNVUxQWJxR2FITGVQTVlFN2VYdnIzZ1BkS3l6K3hnNzJ4SXRq?= =?utf-8?B?N2dxUmhzYWludCtHRFlsczVsQVhXZnJYTEVCaU41cFFzU015WFVabVljYUxm?= =?utf-8?B?OXFhMElMQ2o4WkZFVkR2ZTJIQk05Y0hzN0YyU09tajgxQnUwRTE3R3pHeWlM?= =?utf-8?B?ZTFmZjhhYm5IRUJSNzM3Z1FHd0pocEk2U0tSWjd1YkxwMEN6RzBzS1hIZ1p3?= =?utf-8?B?REw5b0U2Yjh2Kys5UE1jVVc2L1pzQ3pLTm9oRlBuMGhESkRUL2pFdUttK3VH?= =?utf-8?B?YUtRZU9tRERMcTdhQVBhT0ZocFQ0UjZGMjEyRStnQ2V6cENUZ2RxU045U3o5?= =?utf-8?B?eDVTQkNtM2xrZVJ2M2kxcTFPOXcvUWNyQm85bWgwRWlZVmVPU2QrM2JSQkZ3?= =?utf-8?B?RHZ4YXNPZDExY0J2VGhDSm5lWWxJRnZWd3gvUWxEc3owKzBMdGMyZlJiZWtR?= =?utf-8?Q?dd24qqjlj7WI74QKn0Z9zH0+8?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b67cc09-9d3e-48a2-0b3e-08db66d62ef0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 21:37:10.1697 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nyGA6GvDu92JkyHHiSUWRozyhxTosGdzcGmC2u8m/BEWJORNKP5UOIl2Q//+Jk/a X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7353 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/6/2023 10:12 PM, Mike Pattrick wrote: > Previously the noisy neighbour vnf simulation would only operate in io > mode, forwarding packets as is. However, this limited the usefulness of > noisy neighbour simulation. > > This feature has now been expanded to supporting mac, macswap, and > 5tswap modes. To facilitate adding this support, some new header files > were added. > > Signed-off-by: Mike Pattrick > --- > v2: Reverted changes to random memory lookup > v3: Refactored entire patch > v4: Implemented recommended formatting changes > v5: Corrected copyright statement and formatting changes > Hi Mike, There are some comments in v4 seems missed, can you please check the comments?