From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id D10B05699 for ; Tue, 24 May 2016 11:29:35 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id n129so119415959wmn.1 for ; Tue, 24 May 2016 02:29:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=IwiHnecSqAsRJebmM4eZ4IPqpLkPiQE8vbG67Ek7TUU=; b=LE5f0XzcK48dkplDVF2cFNJtMYMO8IMPtlMkXpNlQ00No2k5W5UPmkPKi1sIOHc2F9 wzEXp2eU09c+wtf0f0lXVApYdbz/uBgpvCrfnJbKy4WI6WZ2uNHpxn73J4/26ngkJI6C sGgJ9viFWtTYcqkvMl6TMSx+YEQeWSJJINYvF5aqJaBZwxo1oBjFUKxwOynEJRjnf2PY 0bpa2hZDquuIGEsw4YLO24L+BrRNHS0LP/gQR1Rprq1R1vStI49BZ/O2IDeLCArnsGCi yiCkdh2izXSR3UiEGXnKJkchWshTDeojzkuRhI5Wuuvv2+SC58RSAaW2AeNouZcgXjX1 AZxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=IwiHnecSqAsRJebmM4eZ4IPqpLkPiQE8vbG67Ek7TUU=; b=C4QakeLAOAPXpvSEvHMPE7G1v5w9kLOZ2Bjzr3Nu8mb+zMkdutERUKPSg2Sh+NQSxh jKAR5q4hPrf1LtpbHGCTy96/Sgwv55sAn3Doh/sg+GZob6i5UrRs9pBIlmMKpeZjOh9T F9xkS1PwenQu7ba1A9PdQHTNfyrxy7c+6szNZNkfli8TjsWnS/ByIap2WLkb0tuVC8ke D9Asp1EPmx1x2IF9ECBImlciLC33rPWP4sTitNXTOSRcPYGfYhkyEKbqOX99STeM/jNW 8DPIg5561QmTZJChBm81I3erAqAEtFDOXZ1p5DXfwaYckAj/KOp0mYzDdW/rZyV9vHis 5SLw== X-Gm-Message-State: ALyK8tLpz01jD1UEwtmAbmqReOSMtpMBIsB4GCFL1p9tmoeYkAENZ3L8IDercRFxXI/T0PN7 X-Received: by 10.194.238.234 with SMTP id vn10mr1804175wjc.127.1464082175562; Tue, 24 May 2016 02:29:35 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id ac2sm2145132wjc.35.2016.05.24.02.29.34 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 May 2016 02:29:34 -0700 (PDT) From: Thomas Monjalon To: Ziye Yang Cc: dev@dpdk.org Date: Tue, 24 May 2016 11:29:33 +0200 Message-ID: <3830854.ocOkRYbjrN@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1463663877-52722-1-git-send-email-ziye.yang@intel.com> References: <1463660700-42992-1-git-send-email-ziye.yang@intel.com> <1463663877-52722-1-git-send-email-ziye.yang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] ci: Add the class_id support in pci probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2016 09:29:36 -0000 Hi Ziye, Please check the title. It could be "pci: add class id". Please try to add a changelog below the 3 dashes when making a new revision. Other comments below: 2016-05-19 21:17, Ziye Yang: > --- a/lib/librte_eal/common/include/rte_pci.h > +++ b/lib/librte_eal/common/include/rte_pci.h > @@ -125,6 +125,7 @@ struct rte_pci_resource { > * table of these IDs for each device that it supports. > */ > struct rte_pci_id { > + uint32_t class_id; /**< Class ID (class, subclass, pi) or RTE_CLASS_ANY_ID. */ > uint16_t vendor_id; /**< Vendor ID or PCI_ANY_ID. */ > uint16_t device_id; /**< Device ID or PCI_ANY_ID. */ > uint16_t subsystem_vendor_id; /**< Subsystem vendor ID or PCI_ANY_ID. */ You moved class_id at the beginning (which looks good)... > @@ -177,14 +179,16 @@ struct rte_pci_device { > (vend), \ > (dev), \ > PCI_ANY_ID, \ > - PCI_ANY_ID > + PCI_ANY_ID, \ > + RTE_CLASS_ANY_ID > #else > /** Macro used to help building up tables of device IDs */ > #define RTE_PCI_DEVICE(vend, dev) \ > .vendor_id = (vend), \ > .device_id = (dev), \ > .subsystem_vendor_id = PCI_ANY_ID, \ > - .subsystem_device_id = PCI_ANY_ID > + .subsystem_device_id = PCI_ANY_ID, \ > + .class_id = RTE_CLASS_ANY_ID > #endif ... but forgot to move these lines.