From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D23EE42C98; Mon, 12 Jun 2023 14:44:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C147F4114A; Mon, 12 Jun 2023 14:44:58 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 2268E41138; Mon, 12 Jun 2023 14:44:57 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 635D15C016A; Mon, 12 Jun 2023 08:44:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 12 Jun 2023 08:44:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1686573896; x=1686660296; bh=q4s+DtjJCTMqFnCFLd/WxoR2v+lZdHkMqUh PDt+CAIA=; b=g3sxH1ljSR0ATDi8X5gKa8STHS0SlATuwGYqv9AeC36zEIbuGHQ VYjyVdnCpyu/Ci3vj+kEUpENFekIHSOICuMrlEqhYvx/r0q7/yhSplD8g8qPd1Cj l/icmvs8lXaPPI8ggZEZ+vRihwNdhMmln5flScwMIoj/wWPUdt05YJlxGq1CK/Jg 3BRKRItOWZGx71HE8U17UBV3VHn9XltV+W3gFnYeg/siS0XF4oxFmEj/dVn5yHXH cWJ484JDS+4MLuIBc89vYRE5koaeweWoOHa95ue5AJlYc4sCo+teN9LoUlS67Pqg 6ThNtLSdUKbwBv3IwivBwRecB3iKaY1NUQA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1686573896; x=1686660296; bh=q4s+DtjJCTMqFnCFLd/WxoR2v+lZdHkMqUh PDt+CAIA=; b=gdHqzK8mei1r0usok2stP1XhsK+KqCVReVnCdEJdMLBQ78rtx4I 4DRwRQs/hH5cUbUUSXkPJtyc9ClbR9YU7mJ5YWtWJ3MRkf9ck4GekkHGi5QZqMBL u1nmHY7rZyknp5vHlKXPzJalP+Tgu2QdaIx68BdwbBy+epyKajdQdh9bcol3Fy7Y 32u6lUZQMeVo3ehReshWlneuoziAptnMiUAQeHbRy6h26D9ILO0R65JIq4jWWEe/ KF1M1NUhq/s0mBe6wMfqg7kg7D4O5CKi4aCGOloP+5F58P+pGyXJsjp98MQFZnoU c6JLaJ6IawU5zx3hqTPNfO6ziUeIUTLE0lw== X-ME-Sender: <xms:RxOHZJr9qpXL3f-6LQP56ZtCY6YrIOE7xGfrtH-lr2pOn-M5oHaTDg> <xme:RxOHZLpylPexsFh8PlEXpj4bqFFtIPFqxQ0XcPhU7tyXnea12jjzt9nUVhIBnE5Lm wa-n9cQElXkYnFGtg> X-ME-Received: <xmr:RxOHZGNNINDWI3wAzi0AezIegj2T7VeovEHAioGM0iyM4CSlvJyRCpsOhDRsl8nXnkIrYV6Jxlbl3jjZsW47vcLjXw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeduhedgheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:RxOHZE5RbxkMWeXBQF6_rnaeNW9-v2uKg7cIKrHpldzB8DOxzTMO-Q> <xmx:RxOHZI52nauJZpHJHD2f5CRiwBgJf071ETpHjX87EcZCjueg0vuMbw> <xmx:RxOHZMiqXXp6i-Iqbz22lzaReJWo-_U1Gn7DD88IS6czgrbWQqlN1g> <xmx:SBOHZDpkwuauEInohHnlDwW0-0dZfTN062-imiWQxibpM_7FiNqDyw> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 12 Jun 2023 08:44:53 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ruifeng Wang <Ruifeng.Wang@arm.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, zhoumin <zhoumin@loongson.cn> Cc: dev@dpdk.org, "mb@smartsharesystems.com" <mb@smartsharesystems.com>, "konstantin.v.ananyev@yandex.ru" <konstantin.v.ananyev@yandex.ru>, "Yang, Qiming" <qiming.yang@intel.com>, "Wu, Wenjun1" <wenjun1.wu@intel.com>, "drc@linux.vnet.ibm.com" <drc@linux.vnet.ibm.com>, "roretzla@linux.microsoft.com" <roretzla@linux.microsoft.com>, "stable@dpdk.org" <stable@dpdk.org>, "maobibo@loongson.cn" <maobibo@loongson.cn>, nd <nd@arm.com>, david.marchand@redhat.com, honnappa.nagarahalli@arm.com, Tyler Retzlaff <roretzla@microsoft.com>, konstantin.ananyev@huawei.com Subject: Re: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions Date: Mon, 12 Jun 2023 14:44:51 +0200 Message-ID: <38333053.10thIPus4b@thomas> In-Reply-To: <d2c842d1-912f-9ab1-4793-0c5521702cdc@loongson.cn> References: <20230424090532.367194-1-zhoumin@loongson.cn> <3202143.AJdgDx1Vlc@thomas> <d2c842d1-912f-9ab1-4793-0c5521702cdc@loongson.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 12/06/2023 13:58, zhoumin: > On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote: > > 15/05/2023 04:10, Zhang, Qi Z: > >> From: Ruifeng Wang <Ruifeng.Wang@arm.com> > >>> From: Min Zhou <zhoumin@loongson.cn> > >>>> --- > >>>> v3: > >>>> - Use rte_smp_rmb() as the proper memory barrier instead of rte_rmb() > >>>> --- > >>>> v2: > >>>> - Make the calling of rte_rmb() for all platforms > >>>> --- > > [...] > >>> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> > >> Applied to dpdk-next-net-intel. > >> > >> Thanks > >> Qi > >> > > Why ignoring checkpatch? > > It is saying: > > " > > Warning in drivers/net/ixgbe/ixgbe_rxtx.c: > > Using rte_smp_[r/w]mb > > " > > > I'm sorry. Should we never use rte_smp_[r/w]mb in the driver's code? No we should avoid. It has been decided to slowly replace such barriers. By the way, I think it is not enough documented. You can find an explanation in doc/guides/rel_notes/deprecation.rst I think we should also add some notes to lib/eal/include/generic/rte_atomic.h Tyler, Honnappa, Ruifeng, Konstantin, what do you think?