From: Thomas Monjalon <thomas@monjalon.net>
To: Aaron Conole <aconole@redhat.com>
Cc: dev@dpdk.org, techboard@dpdk.org,
Abhinandan Gujjar <abhinandan.gujjar@intel.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Akhil Goyal <gakhil@marvell.com>, Alok Prasad <palok@marvell.com>,
Aman Singh <aman.deep.singh@intel.com>,
Amit Bernstein <amitbern@amazon.com>,
Amit Prakash Shukla <amitprakashs@marvell.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Andrew Boyer <andrew.boyer@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ankur Dwivedi <adwivedi@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Apeksha Gupta <apeksha.gupta@nxp.com>,
"Artem V . Andreev" <artem.andreev@oktetlabs.ru>,
Ashish Gupta <ashish.gupta@marvell.com>,
Ashwin Sekhar T K <asekhar@marvell.com>,
Bing Zhao <bingz@nvidia.com>,
Brian Dooley <brian.dooley@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Byron Marohn <byron.marohn@intel.com>,
Chaoyong He <chaoyong.he@corigine.com>,
Chas Williams <chas3@att.com>, Chenbo Xia <chenbox@nvidia.com>,
Cheng Jiang <honest.jiang@foxmail.com>,
Chengwen Feng <fengchengwen@huawei.com>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>,
Christian Koue Muf <ckm@napatech.com>,
Chunhao Lin <hau@realtek.com>,
Ciara Loftus <ciara.loftus@intel.com>,
Conor Walsh <conor.walsh@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
David Christensen <drc@linux.ibm.com>,
David Hunt <david.hunt@intel.com>,
David Marchand <david.marchand@redhat.com>,
Devendra Singh Rawat <dsinghrawat@marvell.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Dongwei Xu <xudw@yunsilicon.com>,
Ed Czeck <ed.czeck@atomicrules.com>,
Elena Agostini <eagostini@nvidia.com>,
Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Fan Zhang <fanzhang.oss@gmail.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Gaetan Rivet <grive@u256.net>, Gagandeep Singh <g.singh@nxp.com>,
Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,
Hanxiao Li <li.hanxiao@zte.com.cn>,
Harman Kalra <hkalra@marvell.com>,
Harry van Haaren <harry.van.haaren@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Howard Wang <howard_wang@realsil.com.cn>,
Hyong Youb Kim <hyonkim@cisco.com>,
Ian Stokes <ian.stokes@intel.com>,
Igor Russkikh <irusskikh@marvell.com>,
Jack Bond-Preston <jack.bond-preston@foss.arm.com>,
Jakub Grajciar <jgrajcia@cisco.com>,
Jakub Palider <jpalider@marvell.com>,
Jasvinder Singh <jasvinder.singh@intel.com>,
Jay Zhou <jianjay.zhou@huawei.com>,
Jerin Jacob <jerinj@marvell.com>,
Jeroen de Borst <jeroendb@google.com>,
Jian Wang <jianwang@trustnetic.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Jiayu Hu <hujiayu.hu@foxmail.com>, Jie Hai <haijie1@huawei.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Jochen Behrens <jochen.behrens@broadcom.com>,
John Daley <johndale@cisco.com>,
John McNamara <john.mcnamara@intel.com>,
John Miller <john.miller@atomicrules.com>,
"John W . Linville" <linville@tuxdriver.com>,
Joshua Washington <joshwash@google.com>,
Julien Aube <julien_dpdk@jaube.fr>,
Junlong Wang <wang.junlong1@zte.com.cn>,
Kai Ji <kai.ji@intel.com>, Kevin Laatz <kevin.laatz@intel.com>,
Kevin Traynor <ktraynor@redhat.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Kirill Rybalchenko <kirill.rybalchenko@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Lee Daly <lee.daly@intel.com>, Liang Ma <liangma@liangbit.com>,
Lijie Shan <shan.lijie@zte.com.cn>,
Liron Himi <lironh@marvell.com>, Long Li <longli@microsoft.com>,
Luca Boccassi <bluca@debian.org>,
Maciej Czekaj <mczekaj@marvell.com>
Subject: Re: [RFC] doc: Document frequency and volume limits on patches.
Date: Wed, 19 Mar 2025 17:47:29 +0100 [thread overview]
Message-ID: <3837048.otsE0voPBg@thomas> (raw)
In-Reply-To: <20250305013351.2209789-1-aconole@redhat.com>
Hello,
05/03/2025 02:33, Aaron Conole:
> The DPDK project has two constrained resources - reviewers and
> public CI infrastructure. These are shared among the entire
> project, and there are true costs associated with using these
> resources. Thus, there are two motivations behind this change:
> - Encourage developers to spend more time ensuring their
> changes are in a state that things have gone through some
> basic testing
> - Encourage people to give reviews by guaranteeing that the
> time between series is long enough that comments will be
> valid.
Thanks for trying to improve our process.
> We want to document the guidelines for submitting to the list
> to encourage more time for reviews, and also encourage
> developers to spend a bit more time to put their submissions
> in a 'default accept' condition.
>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
> +Frequency and volume of patches
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +Please allow at least 24 hours to pass between posting patch revisions.
> +This ensures reviewers from different geographical regions have time to
> +provide feedback.
> +Additionally, please do not wait too long (read: weeks) between revisions
> +as this makes it harder for reviewers and maintainers to recall the context
> +of the previous posting.
Should we recommend to ping after a week of inactivity?
> +
> +Please do not post new revisions without addressing all feedback.
> +Make sure that all outstanding items have been addressed before posting a new
> +revision for review.
Should we remind to reply to all feedbacks?
> +Do not post a new version of a patch while there is ongoing discussion unless
> +a reviewer has specifically requested it.
> +
> +Do not post your patches to the list in lieu of running tests.
> +**YOU MUST ENSURE** that your patches are ready by testing them locally before
Should we be more precise about "testing them locally"?
Or recommend minimal testing like 1 compilation target with unit test or DTS?
> +posting to the mailing list.
> +The infrastructure running the tests is a shared resource among all developers
> +on the project, and many frequent reposts will result in delays for all
> +developers.
> +We do our best to include CI and self-test infrastructure that can be used on
> +an individual developer basis.
This self test infra should be explained a bit more.
> +
> +Your changes are expected to pass on an x86/x86-64 linux system.
This can be moved above with "local test" recommendation.
> +
> +Keep all patch sets to a reasonable length.
> +Too many or too large patches and series can quickly become very difficult
> +for a reasonable review.
To be clear, you recommend to split patches and series appropriately.
Thanks again.
I would love reading more comments and feedbacks about this.
prev parent reply other threads:[~2025-03-19 16:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 1:33 Aaron Conole
2025-03-19 16:47 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3837048.otsE0voPBg@thomas \
--to=thomas@monjalon.net \
--cc=abhinandan.gujjar@intel.com \
--cc=aconole@redhat.com \
--cc=adwivedi@marvell.com \
--cc=ajit.khaparde@broadcom.com \
--cc=aman.deep.singh@intel.com \
--cc=amitbern@amazon.com \
--cc=amitprakashs@marvell.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.boyer@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=anoobj@marvell.com \
--cc=apeksha.gupta@nxp.com \
--cc=artem.andreev@oktetlabs.ru \
--cc=asekhar@marvell.com \
--cc=ashish.gupta@marvell.com \
--cc=bingz@nvidia.com \
--cc=bluca@debian.org \
--cc=brian.dooley@intel.com \
--cc=bruce.richardson@intel.com \
--cc=byron.marohn@intel.com \
--cc=chaoyong.he@corigine.com \
--cc=chas3@att.com \
--cc=chenbox@nvidia.com \
--cc=christian.ehrhardt@canonical.com \
--cc=ciara.loftus@intel.com \
--cc=ckm@napatech.com \
--cc=conor.walsh@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=drc@linux.ibm.com \
--cc=dsinghrawat@marvell.com \
--cc=dsosnowski@nvidia.com \
--cc=eagostini@nvidia.com \
--cc=ed.czeck@atomicrules.com \
--cc=erik.g.carrillo@intel.com \
--cc=evgenys@amazon.com \
--cc=fanzhang.oss@gmail.com \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=g.singh@nxp.com \
--cc=gakhil@marvell.com \
--cc=gmuthukrishn@marvell.com \
--cc=grive@u256.net \
--cc=haijie1@huawei.com \
--cc=harry.van.haaren@intel.com \
--cc=hau@realtek.com \
--cc=hemant.agrawal@nxp.com \
--cc=hkalra@marvell.com \
--cc=honest.jiang@foxmail.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=howard_wang@realsil.com.cn \
--cc=hujiayu.hu@foxmail.com \
--cc=hyonkim@cisco.com \
--cc=ian.stokes@intel.com \
--cc=irusskikh@marvell.com \
--cc=jack.bond-preston@foss.arm.com \
--cc=jasvinder.singh@intel.com \
--cc=jerinj@marvell.com \
--cc=jeroendb@google.com \
--cc=jgrajcia@cisco.com \
--cc=jianjay.zhou@huawei.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
--cc=jingjing.wu@intel.com \
--cc=jochen.behrens@broadcom.com \
--cc=john.mcnamara@intel.com \
--cc=john.miller@atomicrules.com \
--cc=johndale@cisco.com \
--cc=joshwash@google.com \
--cc=jpalider@marvell.com \
--cc=julien_dpdk@jaube.fr \
--cc=kai.ji@intel.com \
--cc=kevin.laatz@intel.com \
--cc=kirankumark@marvell.com \
--cc=kirill.rybalchenko@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=ktraynor@redhat.com \
--cc=lee.daly@intel.com \
--cc=li.hanxiao@zte.com.cn \
--cc=liangma@liangbit.com \
--cc=linville@tuxdriver.com \
--cc=lironh@marvell.com \
--cc=longli@microsoft.com \
--cc=mczekaj@marvell.com \
--cc=palok@marvell.com \
--cc=shan.lijie@zte.com.cn \
--cc=techboard@dpdk.org \
--cc=wang.junlong1@zte.com.cn \
--cc=xudw@yunsilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).