From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B4C846426; Wed, 19 Mar 2025 17:47:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1B37402C4; Wed, 19 Mar 2025 17:47:50 +0100 (CET) Received: from flow-a6-smtp.messagingengine.com (flow-a6-smtp.messagingengine.com [103.168.172.141]) by mails.dpdk.org (Postfix) with ESMTP id 75F0F4026B; Wed, 19 Mar 2025 17:47:48 +0100 (CET) Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailflow.phl.internal (Postfix) with ESMTP id B1E0B201879; Wed, 19 Mar 2025 12:47:47 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Wed, 19 Mar 2025 12:47:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1742402867; x=1742410067; bh=R3cT9auhgwJU/DuESNMFvPikXlObMPmCSbpdW0qn9D8=; b= XYQSZZbrs3AL1scygAwVzINkAyC+tb4uc/y0Xe5DzJS7NU6+rt8vLrAFzoyHeCD9 2rbiP/OrdnCfA/O1NTEccv8PGOEvrgXgYR3faTT57fBVxKxZ1bWenKspYWwvJFfi lKVOxcB8vyrbgxBVAzmRv6LpUH7Uhb7uv0jNxXftDzhC1l4JuFDfi4WkCBFoR/fI sx3gjffcdxPlSCbDN6idG7f9WqMsNIBfFx9BYsCX7N3nomwV1/1006luMoX+qoH3 yUUbeeuHwY4KVn8WZa3OzwjN/4bEsxh3ooQEZnusjz6Hsqe6PA6R/uO+yhZMmg1H KIVUpwJ9B7IMyknh96nStA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1742402867; x= 1742410067; bh=R3cT9auhgwJU/DuESNMFvPikXlObMPmCSbpdW0qn9D8=; b=E Zz0cu3ljzLP41JiXz8IyGuuGTGcylj1Ar2WgbB0oCqt5SvM19kEtxeQUYmUhG6Mh DrKx0hF6jKD+pYfItaSrqr+YX2E4S6cp7tsomrjs2Ra7cDU9bN+ZDqa2KEyrzvI0 A1iwzcyg5n3gWNpMIPUY/zyo5In5QdyswEf044DwPkVeCs0Ko3HKyaDxGK0umyU+ 9HuvBJ+LjUSyLviLt6sKacTTV3YZn445uFdDOIIfBwLn7IR0A1fobBAm173x2JU4 W+c5kNoThDbuGpCrWXPduavxJ8r9H1zqnDoSOZZSCkww5wOBBpl30AZ0ULmi9OK2 /UO0QGBK80hF0/ip2o/5A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddugeehkeehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddt jeenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonh hjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdt geekueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght pdhnsggprhgtphhtthhopeelvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheprg gtohhnohhlvgesrhgvughhrghtrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdho rhhgpdhrtghpthhtohepthgvtghhsghorghrugesughpughkrdhorhhgpdhrtghpthhtoh eprggshhhinhgrnhgurghnrdhguhhjjhgrrhesihhnthgvlhdrtghomhdprhgtphhtthho pegrjhhithdrkhhhrghprghruggvsegsrhhorggutghomhdrtghomhdprhgtphhtthhope hgrghkhhhilhesmhgrrhhvvghllhdrtghomhdprhgtphhtthhopehprghlohhksehmrghr vhgvlhhlrdgtohhmpdhrtghpthhtoheprghmrghnrdguvggvphdrshhinhhghhesihhnth gvlhdrtghomhdprhgtphhtthhopegrmhhithgsvghrnhesrghmrgiiohhnrdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Mar 2025 12:47:31 -0400 (EDT) From: Thomas Monjalon To: Aaron Conole Cc: dev@dpdk.org, techboard@dpdk.org, Abhinandan Gujjar , Ajit Khaparde , Akhil Goyal , Alok Prasad , Aman Singh , Amit Bernstein , Amit Prakash Shukla , Anatoly Burakov , Andrew Boyer , Andrew Rybchenko , Ankur Dwivedi , Anoob Joseph , Apeksha Gupta , "Artem V . Andreev" , Ashish Gupta , Ashwin Sekhar T K , Bing Zhao , Brian Dooley , Bruce Richardson , Byron Marohn , Chaoyong He , Chas Williams , Chenbo Xia , Cheng Jiang , Chengwen Feng , Christian Ehrhardt , Christian Koue Muf , Chunhao Lin , Ciara Loftus , Conor Walsh , Cristian Dumitrescu , Dariusz Sosnowski , David Christensen , David Hunt , David Marchand , Devendra Singh Rawat , Dmitry Kozlyuk , Dongwei Xu , Ed Czeck , Elena Agostini , Erik Gabriel Carrillo , Evgeny Schemeilin , Fan Zhang , Ferruh Yigit , Gaetan Rivet , Gagandeep Singh , Gowrishankar Muthukrishnan , Hanxiao Li , Harman Kalra , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Howard Wang , Hyong Youb Kim , Ian Stokes , Igor Russkikh , Jack Bond-Preston , Jakub Grajciar , Jakub Palider , Jasvinder Singh , Jay Zhou , Jerin Jacob , Jeroen de Borst , Jian Wang , Jiawen Wu , Jiayu Hu , Jie Hai , Jingjing Wu , Jochen Behrens , John Daley , John McNamara , John Miller , "John W . Linville" , Joshua Washington , Julien Aube , Junlong Wang , Kai Ji , Kevin Laatz , Kevin Traynor , Kiran Kumar K , Kirill Rybalchenko , Konstantin Ananyev , Lee Daly , Liang Ma , Lijie Shan , Liron Himi , Long Li , Luca Boccassi , Maciej Czekaj Subject: Re: [RFC] doc: Document frequency and volume limits on patches. Date: Wed, 19 Mar 2025 17:47:29 +0100 Message-ID: <3837048.otsE0voPBg@thomas> In-Reply-To: <20250305013351.2209789-1-aconole@redhat.com> References: <20250305013351.2209789-1-aconole@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, 05/03/2025 02:33, Aaron Conole: > The DPDK project has two constrained resources - reviewers and > public CI infrastructure. These are shared among the entire > project, and there are true costs associated with using these > resources. Thus, there are two motivations behind this change: > - Encourage developers to spend more time ensuring their > changes are in a state that things have gone through some > basic testing > - Encourage people to give reviews by guaranteeing that the > time between series is long enough that comments will be > valid. Thanks for trying to improve our process. > We want to document the guidelines for submitting to the list > to encourage more time for reviews, and also encourage > developers to spend a bit more time to put their submissions > in a 'default accept' condition. > > Signed-off-by: Aaron Conole > --- > +Frequency and volume of patches > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +Please allow at least 24 hours to pass between posting patch revisions. > +This ensures reviewers from different geographical regions have time to > +provide feedback. > +Additionally, please do not wait too long (read: weeks) between revisions > +as this makes it harder for reviewers and maintainers to recall the context > +of the previous posting. Should we recommend to ping after a week of inactivity? > + > +Please do not post new revisions without addressing all feedback. > +Make sure that all outstanding items have been addressed before posting a new > +revision for review. Should we remind to reply to all feedbacks? > +Do not post a new version of a patch while there is ongoing discussion unless > +a reviewer has specifically requested it. > + > +Do not post your patches to the list in lieu of running tests. > +**YOU MUST ENSURE** that your patches are ready by testing them locally before Should we be more precise about "testing them locally"? Or recommend minimal testing like 1 compilation target with unit test or DTS? > +posting to the mailing list. > +The infrastructure running the tests is a shared resource among all developers > +on the project, and many frequent reposts will result in delays for all > +developers. > +We do our best to include CI and self-test infrastructure that can be used on > +an individual developer basis. This self test infra should be explained a bit more. > + > +Your changes are expected to pass on an x86/x86-64 linux system. This can be moved above with "local test" recommendation. > + > +Keep all patch sets to a reasonable length. > +Too many or too large patches and series can quickly become very difficult > +for a reasonable review. To be clear, you recommend to split patches and series appropriately. Thanks again. I would love reading more comments and feedbacks about this.