From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id B11A45A8E for ; Mon, 30 Mar 2015 21:53:01 +0200 (CEST) Received: by wgbgs4 with SMTP id gs4so96084434wgb.0 for ; Mon, 30 Mar 2015 12:53:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=IVo6OiBaoQ4fGTfTJURcTr6B/+qZxOtPSRKd5xMafZA=; b=QBIk412PSM13K6ecOYyd3wREbxjIJHg0ea7SOKOyTlOatwB0hKp+SXspoLf0D6VyzL dR7Oh9hc4YZINXbk+es1upgVEmyIFgWEwVQPXeihBTNm04SQG32lrxop1YF3tX5kUWRl qgHWPrCUQkk2q6BV9CTiER6FQerjxG8hqP0BUtbnKpcpCcBnGjI6ArUWek6Vii/BUxfa 0Eae+0YNA5YPyH6fDdE1B6pfyVisQXNF4LiZhCIYUEHyNdm75kSTsJOPeFvZERyBKJRk 7iXYOTEZhuXv3kq1WuzZLS2d9i2rBbVXtfhbVXdtGoZWxvDiZETBwmBOF5nrLQVCAN/V vM7g== X-Gm-Message-State: ALoCoQlxgaFqYEm+bASVOKuD2gNTJh3vEYx6imppBTB3iU4SPNu8MgUDtw+g1zRHKllBv4xAfJ50 X-Received: by 10.194.61.12 with SMTP id l12mr66582405wjr.139.1427745181558; Mon, 30 Mar 2015 12:53:01 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id w8sm17154974wja.4.2015.03.30.12.52.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Mar 2015 12:53:00 -0700 (PDT) From: Thomas Monjalon To: "Mcnamara, John" Date: Mon, 30 Mar 2015 21:52:19 +0200 Message-ID: <3838676.MhgVrxv5VX@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150323160058.GA5661@hmsreliant.think-freely.org> References: <1426179268-22164-1-git-send-email-john.mcnamara@intel.com> <2572007.3HCLxGSxJD@xps13> <20150323160058.GA5661@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ethdev: additional parameter in RX callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2015 19:53:01 -0000 2015-03-23 12:00, Neil Horman: > On Mon, Mar 23, 2015 at 04:16:36PM +0100, Thomas Monjalon wrote: > > I think John is saying that the API of rte_eth_rx_burst() already includes > > the nb_pkts parameter. So it's natural to push it to the callback. > > I also think Neil is saying that this parameter is useless in the callback > > and in rte_eth_rx_burst() if the array was null terminated. > > In any case, having a mix (null termination + parameter in rte_eth_rx_burst) > > is not acceptable. > > Moreover, I wonder how efficient are the compiler optimizations in each loop > > case (index and null termination). > > > > As the API was using an integer count, my opinion is to keep it and push it to > > the callback for 2.0. > > If null termination is validated to be better, it could be a later rework. > > > > I'm fine with this if thats the consensus, I'm more interested in making sure we > think about these problems in such a way that we're not just running from ABI > issues, because we're eventually going to have to deal with them > Neil Acked-by: Thomas Monjalon Applied, thanks