From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0A8842FA3; Mon, 31 Jul 2023 14:16:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92D3440A89; Mon, 31 Jul 2023 14:16:38 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id B70A84067B for ; Mon, 31 Jul 2023 14:16:37 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id BBC4C32000E5; Mon, 31 Jul 2023 08:16:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 31 Jul 2023 08:16:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1690805795; x=1690892195; bh=OHdr95hoojy1813y3itQjYKaAjCTGJ7r0Wn JMPhlq58=; b=A3bLwP+dCo6uTjsy6TIxBulZY64mJTL9ijCTOTEoXPu4ARRmhFJ G3ZS82hCc4S4tGy7Fyx4PtzOOvSPity1z6BvQmcX2FNUVeAQL6YEK/XHHMAXselU WHOcmHX+GFpXonomdP5PDwRAGY089XmDP7Z2A1CNjdErSf72Grby9rWyd/9z2IDr 0eqig2C3m+XRVakDCJZbNVTwN0tCGhsl3OvBJkwTWHIYXWtau28hYLKsxI3iQqUj nCl4Tk0guTx9RM2zyoo89t37uN287y9Ul3kBrGS4mUFrYzSCyARdzING5egibjFy 2EusY2T9G8QVz3ENoGRL5g/5oMiI8bZihRQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690805795; x=1690892195; bh=OHdr95hoojy1813y3itQjYKaAjCTGJ7r0Wn JMPhlq58=; b=nDkkLq86h+Ozi68+t6lLGvdlNsU/3m261x0B1XPtBaZ0NF7O+V4 iEvc5pl6Ly4RmwuIDQKXt1Wv/TvzX/No077ayxB51zXndM+siYBdWgN8ZpriAjXG ASls8Y/MkVSuMGY59bOuq4kZmlBzOOTe1itvynpPz6TeuiVpsK7lS4fQei28dekx DsxYJ3ZUcbpMLogXxaLi+jkx4LlSOncr/c+ex2JmR2em7VqyoF5VuWOtdFeSh8SE vhW1bHvVZY1Tbk2RugTPvn1wB7FLTq7jJv5RuVIpxegM5XkktF0iZ2lcTDhGCMRs 2T7lRwmTXej8CATZNBlUwL95CAxAyyogKfg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrjeeggddvjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfefhjeeluedvvedtuddtuedtvefhieejtefhffeujefhteduudev tdektdeikeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 31 Jul 2023 08:16:33 -0400 (EDT) From: Thomas Monjalon To: Olivier Matz , Andrew Rybchenko Cc: dev@dpdk.org, nd@arm.com, Morten =?ISO-8859-1?Q?Br=F8rup?= , Kamalakshitha Aligeri , Dharmik Thakkar , Ruifeng Wang , Konstantin Ananyev , Chengwen Feng , Dharmik Thakkar Subject: Re: [PATCH v12 1/2] mempool cache: add zero-copy get and put functions Date: Mon, 31 Jul 2023 14:16:31 +0200 Message-ID: <38429008.J2Yia2DhmK@thomas> In-Reply-To: <20230721162836.1208772-1-dharmikjayesh.thakkar@arm.com> References: <20230705180233.880203-2-kamalakshitha.aligeri@arm.com> <20230721162836.1208772-1-dharmikjayesh.thakkar@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Olivier, Andrew, any comments? 21/07/2023 18:28, Dharmik Thakkar: > From: Morten Br=F8rup >=20 > Zero-copy access to mempool caches is beneficial for PMD performance. > Furthermore, having a zero-copy mempool API is considered a precondition > for fixing a certain category of bugs, present in some PMDs: For > performance reasons, some PMDs had bypassed the mempool API in order to > achieve zero-copy access to the mempool cache. This can only be fixed > in those PMDs without a performance regression if the mempool library > offers zero-copy access APIs, so the PMDs can use the proper mempool > API instead of copy-pasting code from the mempool library. > Furthermore, the copy-pasted code in those PMDs has not been kept up to > date with the improvements of the mempool library, so when they bypass > the mempool API, mempool trace is missing and mempool statistics is not > updated. >=20 > Bugzilla ID: 1052 >=20 > Signed-off-by: Morten Br=F8rup > Signed-off-by: Kamalakshitha Aligeri > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang > Acked-by: Konstantin Ananyev > Acked-by: Chengwen Feng