From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B152343F69; Thu, 2 May 2024 16:51:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31F6B402B2; Thu, 2 May 2024 16:51:51 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2040.outbound.protection.outlook.com [40.107.212.40]) by mails.dpdk.org (Postfix) with ESMTP id B338140299 for ; Thu, 2 May 2024 16:51:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S6abNoeUI1B3LzaMJydq7kVl71Ksr5HVcDIaVWtqZnJwV0t0neu1ccMYKNs7Xw4CRlTWyC6NdTqIO5S3KTSpDXjWOent7w3/X4TFdLGIBtcnBEO1R9KAVHVerhJafZJbGNp8TK8ZUAudXAOsRmfJGFiWMGbr3KGFvfIeyRHuMln1BXUQw/3vs8GZDhBxv6/4OaNIi649Z3MkUcw3oBGHJMlY8CXaUKuUWLAm2VvgnxhwbqfgxeIgUfDwBzzwzEqpTJorP5bsbfHw/XkCz4p0R+ja+VxeCD/8aY2vPy41i1Vvys23k/aHY5P3Dda7baz3NQEswdapcFlcu5nIJPZwbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E3tmpSJg9hhqm2R6wp4JOV0HSoBTn7vg/KnyTAGqXK8=; b=LrW43wor62j1SfntEEWucukCzd5D3kWVyAz598e6L+PYnJoUeaR4oT3RW1WxhyghYpMFBbXXCa3G2Ah50cerBlfa4Wc+8OxsfmtE7dcBnbq0o5UsuUTjniSW0u6huQhEPuZErh15ikK3tEBafKTWz1AoKRBThRCslP7nyvHKLTCKKuuXv0N1g7YTmIlvYEHTNRHbh3O3KW8tEHh7mIh3VJ4IHy2tdAeqjOseLPCfEg+DXfJLGDeSyNh397eMmUar+ewPsSF/6mtPFsRPiCD+AOyeTw8J5OVUFCxCAQta5PEWdKS4Sli1xVCJBU4ArXcYwMpG5QCm9G4i5DGwx2pXiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E3tmpSJg9hhqm2R6wp4JOV0HSoBTn7vg/KnyTAGqXK8=; b=CHjXUgiw7HozPb5UsA7WjSTms/SU+8Qv005MGCqGzJ0p6B2OzPNVvrUjgwxjGrNKel6N0A4pjkFj4MUpunZeuVSs13wkzBNU5l99d4J/y2Uhcsfjwcz+7VeYI5drP7g5Tz3Coeuuy+69e5X/0viK1clrQ7M8V0wIh1TMNT2m7As= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN2PR12MB4238.namprd12.prod.outlook.com (2603:10b6:208:199::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.30; Thu, 2 May 2024 14:51:46 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7544.029; Thu, 2 May 2024 14:51:46 +0000 Message-ID: <38443222-c3ce-41dd-91c9-1038df042b92@amd.com> Date: Thu, 2 May 2024 15:51:43 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 1/9] net/tap: do not duplicate fd's To: Stephen Hemminger Cc: dev@dpdk.org References: <20240130034925.44869-1-stephen@networkplumber.org> <20240426155125.125910-1-stephen@networkplumber.org> <20240426155125.125910-2-stephen@networkplumber.org> <57fcc4d9-211b-4615-b380-2bf4f83926af@amd.com> <20240501165333.3c7ec80b@hermes.local> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240501165333.3c7ec80b@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0056.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:310::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN2PR12MB4238:EE_ X-MS-Office365-Filtering-Correlation-Id: a3f4a48b-6f9a-4548-caa1-08dc6ab763ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|376005|366007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VjZZYmFWUC9NZHZQejFCSDJDREE2RWZwemlxRVpmckdTWWhCbjUzM0NFOGVh?= =?utf-8?B?SzQwVlVML2pPZlIxamxyTGpsbkJGMEFGRE9haERISk9wR1NiWWEvdytqYXow?= =?utf-8?B?OHh2Qk1iSGdSa1pjbm1LUlNPUWZUNnlzUlJnbk9YVFp3Nkd0aWluNFN0Rkhy?= =?utf-8?B?U1NEbW12TGFlcTAwcjc5enFzdnFyd25FUUdkZ3RuTHBPZVc3VjdMQlFQUmdD?= =?utf-8?B?U0JpYVAzNk9HaldLYzVUeC9scTRXaFhwRVpwNmE2bnhMclR4SjFwNHZuNUZh?= =?utf-8?B?QUh1ZzJxRS83Y3gvbzFTSmpBSmlKeDdtZWc3YlJhZllCcHZHNlJVa1ljSVJj?= =?utf-8?B?V2lEVkZJN2o3UTQzTloycXptZlU1UHVkZ0kwMjZGbnVqbEEyaXlaQjEwY0tU?= =?utf-8?B?QnY0UjJJSENiZzNvU1BVZnZOaUtBMm93TVJtWFpFcFhqR3dBeUpjZEQ5UDB1?= =?utf-8?B?NDYzQmhMOEpUa2VLZ1EzWllSbHNpcjR0Q2hGRmlPM3FHeHNjY1c2U0RMbkNQ?= =?utf-8?B?RUFCakY1MndWMlExYVdZOEZBRDVYVjQ3N0lxYjhITzVDR1NhOVQwTGtNYXVq?= =?utf-8?B?WGZ1eW9hS1pweThLc0tqaGwvN1ZFb1VhN0wyTzNtbzdHdGk1MVcwejB6N3BF?= =?utf-8?B?ME4xZXRmYkxXTis5T0lsM2FTZXdhT0VCWiswSEF3SnA5cmwraEkzY0F1YWcr?= =?utf-8?B?T3RmU3FoQzFZMjNFMTJIRmZTN0ZsNGhJeU4xcGdja0s3azRkeTFmdWpPaGJE?= =?utf-8?B?RWF6K2xuOWN6ejdteDh5clpKTDIvYTZGV21za1g0dGhSNjZ1K0VDWG9BQzI2?= =?utf-8?B?dzRINFNJNm5MTVFpZjJWUFZQKys0d1ZsSitUQXlTL0ZsZzk5L3lqTTN0TXNt?= =?utf-8?B?L2lBYzZPeVo1emVuV2t4eFBSYk1rSjZ6Tkt4YzRlODBuOEI5ajFVa091Tm5y?= =?utf-8?B?cGt4NFhJY3pKRFQ5RVM4V1V1N1pwa3ZwbEdnMXpLTERBN0dGbEJ1Ym04ckF3?= =?utf-8?B?T05HUkxobnBVc2IvTTBlQ0UwUDI0SEY1aWpVdUJ5T043VURyTm9YSm5MQTJo?= =?utf-8?B?TWlYc01aWkVJTWVQSVV5QmhUUUR1bTdmWmk4bnBHbWdXMTdidXBGOEdIdkR2?= =?utf-8?B?bnFQUmdXTWZOdWgxc2g5WFlDWHpLcDNVVmtGeTVzK1BvV0FkNkxpaUFtSjE1?= =?utf-8?B?VEdZQzRtcHJ0MUtDMGNNUnYwZjdPR3BjSlQvc0trck80NGY0ODQzWmRiOEZ0?= =?utf-8?B?bHhKbWFtc3JEaDB5WVphV2ZtT05rdnN0ZHBsbkdVVlVvaUk4eXdRTStKMzY4?= =?utf-8?B?enhJQWxDUE9hNTZWbFRYV0VyKzA5SmFROUFuTytaa3A2SUg1VEEzSGFqMzBL?= =?utf-8?B?MHRPQStzbnd1RUhlcmhjc2FvTitIbmFPRDdwU2R0QURnWVQ4eWZjOEhpYkda?= =?utf-8?B?emxNTmYveUlQa0g2UGZBRGRjUmxIOWY1bm5JcUVLbG1qZVJKK0tDa2VROTF2?= =?utf-8?B?dHF1MjJSS0JhSEdWV1ZSK2VOMWx4K2lqRUo0Z1FaZkRNYUJYOG5pcTVxMnJp?= =?utf-8?B?QURaUko5R2tmeVhKcnVmVDBHSDk1TkdESEZRMkg4aExtK3NvOEpVUFdncklW?= =?utf-8?B?NTJKM1A3amdENFlhbnF5M2cyY2hXT3pBMGQ4TXByTkdpdm1mOEF1dDIyZWFq?= =?utf-8?B?alpxaVA4dTJuVWhTVmZObnUzVlhGR0JCRnJNeXR1UEMzSnA2bHA4eHB3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlFkdTFweUUvZ0dab3JqbDBYR0NCTXNwVFpTRDRSYjEwclVjRzRSc3Nmc0Yw?= =?utf-8?B?QUhVQ0ltRnhibGkxaCtYcElNaUZBZmZtbjBCY3VDa0tzTmkrdCthWkpIMk5Y?= =?utf-8?B?ZS9qekpUOS9KMVZnb0ZuY1RRSHpORWlIa3ZxUEZDY0dpT3FlSC9sUkZYQlBo?= =?utf-8?B?dVpnclIzdlg0ZW03Zmp1SWFWRHllOFF4NFVHdzdYQkhxb1VHS0V0WElqRk9x?= =?utf-8?B?MUkyY0Jkb2Ywb1RhUEJJWHh2YXJ2S2RzQVdYLytmRkhpaXpPc3RHRUp6c1Vz?= =?utf-8?B?RXlCcWEzMkROcmNwdi9jOHkwc2tVYS9JcGZDS2J3eDc5MjAwQ1hyWWhmaWpN?= =?utf-8?B?b2tQSzhEUkIvUUxiQVRCTVgvT3ZtMzBWNEMwUUZmN21NNUpOR1k3ODFFZzlM?= =?utf-8?B?Ty9tYkNzRDUxN0hPWTU4dWdXUnNrbGM1bGlLUE1qNVZ0SXorTVc2aTZMTXN1?= =?utf-8?B?NGlxUHBscTBFa01KV21EamVxMlNzY0ovK0VDcFB0alBSNUloSURvTGc1blpY?= =?utf-8?B?dDlBUE00ZThSV1NKTXJXb01EUWtYdVlhcnp0TThpV0xTc2VRSmpXM0JvdVpa?= =?utf-8?B?dlhLOEhFZFV5ajNJWkppTDBtMHpnUHlQMnVJWGVmMnVTTDlvZWhENXgycjZZ?= =?utf-8?B?NG1aV0cwZFlIMlJtUXNQVThYUG9NQjhwcFhKbFFIUk5rWnd2Z2E5UlhXVmNR?= =?utf-8?B?cFpTaDJxOHFZUXdlRHRmTmhFdEdVK3BzL0NxWGI2bkJqOHR0YzhQQVozcjZ1?= =?utf-8?B?TllnTDFQT05jYWc4eE1XVGowN3YxaXM1L0NyQlJGNTlSYm8rMEpaR09ubVJZ?= =?utf-8?B?em5GQlFxRWd5ZDdEWk55S0ExRHpoU2lQZEV3ZTh6cU5QZkxxTk9aUW9kQTEr?= =?utf-8?B?My91ZTRueFZoYm1BK1JJMkVneWZKWDc0K2ErWnBwRXRmY1U4TktQd3lZemxI?= =?utf-8?B?L3VSSnk0bTVoY3lDRVNLTFdXZnZDTlF5aUN5eGJIclZGbVJhaFlVbmRDRjBZ?= =?utf-8?B?YmtTdEJQaVpVUjFpZzNHczhVNXBCY1VEQ1pWWTFWRzNhb0tlR1A5Z2ZIYldR?= =?utf-8?B?VXRGMkltK2JRbllpZStqOFIzYkNXNDJZQWE0ZVFWVUNjcEVMbzRqTEd5eVhY?= =?utf-8?B?NlBvK2UxNU1RV0VRMU5PWVRrV3lMS2cvaWVtR3I4aG9YNTBDaHgyTldaa0kv?= =?utf-8?B?TkJ0aE44RXplNzlVcU4wZVpRTjY4M01jS0MyaGUwTnRMb3gyQXlvR3h1cEd6?= =?utf-8?B?bzFGL0pKQXRremVFMmN5bVVUM0k2cjBKOWQyN01VY0lydElmVGQxdE0yUnFR?= =?utf-8?B?dmI1RTZtOU40L042UHZEb1A0d3FidlQ4VUwyWXVhQW5pa3pCK3JRaGw1Q0My?= =?utf-8?B?RE1qTTBxTU05dHoxMjJlc1I4TE4yZWU4NW1vZkNWZ21KT3ZoN04wa2tEZ1Nj?= =?utf-8?B?TTFJYktRZUpMM2ViOW5URWIyYmtQcURNcU5rY284YXRtWDlhOGZVaUV1UnBx?= =?utf-8?B?NVR6Y1dseEY4RFQrSDBVbEZHVkFGa25Nb3JmMVZSL1dKOGs0UExoVjdoQ3pM?= =?utf-8?B?MFEyNGNvWmdmWXNYOFA0ZU9MeitaZWdQZ0h2enExZEtYU29SN3pQM2xiQUZn?= =?utf-8?B?ZDVBOGtDU1BDc3A1OHJPaHVTcHBxeEVjTGhyd2h2cFUwaFU3TWxpT1ZLWU0z?= =?utf-8?B?RkZIVlVrMWR3dUZhTlJ0OWo4eU5zTS9RNytlSStwNW9Ia3VyL0NGeFVZUGdX?= =?utf-8?B?K0pCV1hSUGZMa3N4cS9iMStKQ2taOUgwOUNTaEJPWklKZG05OUUxMjNCaUtV?= =?utf-8?B?dTY2ZkhzSG9vaFp4ai9tSWFVMFlzU2U5eDF2cUNvUmNDYlBGbVZzNHZOQmpl?= =?utf-8?B?Z0R3Z3lzY0FpdVdUclF4N0laTUVjaWhKd3M2R240ZDFaSS9HVXR4ek9NM1pj?= =?utf-8?B?S0lWRmkxbEJsVFpZeFhoVUd0dnZZdWk2VnhVRTYzY3NjOGFJYkFRdmU2KzQ0?= =?utf-8?B?Z2poT3VvckFZVTM0Sk5ZeXFyYVpMZFZZaDFjWFFJZk1iZXZ5dzhyZHNpQnJt?= =?utf-8?B?bnNlZHBnT0R0bHdTdlYyZ2V1UWd3Q0VINHFYSDFlOTNTanh6R29xdlo1QStw?= =?utf-8?Q?JQHHqphkTAfm3GOO0iCtIeb5D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3f4a48b-6f9a-4548-caa1-08dc6ab763ac X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 14:51:46.8948 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N/G09s4qIETcmq2AOKMyZPWHLQVZvtmJpoKftAUOl0IkVI4oNPsfg0uE5o3V5BaO X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4238 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/2/2024 12:53 AM, Stephen Hemminger wrote: > On Wed, 1 May 2024 12:13:45 +0100 > Ferruh Yigit wrote: > >>> diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c >>> index fa50fe45d7..a78fd50cd4 100644 >>> --- a/drivers/net/tap/tap_flow.c >>> +++ b/drivers/net/tap/tap_flow.c >>> @@ -1595,8 +1595,9 @@ tap_flow_isolate(struct rte_eth_dev *dev, >>> * If netdevice is there, setup appropriate flow rules immediately. >>> * Otherwise it will be set when bringing up the netdevice (tun_alloc). >>> */ >>> - if (!process_private->rxq_fds[0]) >>> + if (process_private->fds[0] == -1) >>> >> >> change in the condition looks reasonable but not directly related with >> the change, does it require its own patch? > > In this case, the array of fds is moving from the rxq to being global. > The old code worked because rxq_fds[] was initialized to zero. > With shared fd's the fds are now initialized to -1. > > Using zero as sentinel fd is bad practice, because it is a valid fd; > but POSIX says it always is stdin. > I agree on the fix, only I don't think it belongs to this patch. As far as I can see 'rxq_fds' was already initialized to '-1' and original code was already wrong. This patch merges 'rxq_fds' & 'txq_fds' to 'fds', but this patch doesn't do anything that requires updating the above condition, or if I missing it please show me. I think better to fix condition first in a separate patch.