From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8595DA0487 for <public@inbox.dpdk.org>; Tue, 2 Jul 2019 16:57:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 52F2D1B9CA; Tue, 2 Jul 2019 16:57:11 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 991441B99A; Tue, 2 Jul 2019 16:57:09 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id ADECD1C55; Tue, 2 Jul 2019 10:57:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Jul 2019 10:57:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=N+C+uPvyuZZNbo5bYDdMkXrZhae2brZhbMKI5P0NE4Q=; b=IV4PXz1/QiLA n6tZgHMV6UbaKpiJDRThhE6dZG3X/IXaljkWRYZltmfzakx6S9uOhseQn8avGbGk g+HORojHoe35W0hpX9SiOJV8VIi2zKPvsJg9MvgLaqADeG/uHbayZfwGvHIV+DCP YFuhKfD1fzqyl8lA2W55OXYSKmMn7lc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=N+C+uPvyuZZNbo5bYDdMkXrZhae2brZhbMKI5P0NE 4Q=; b=PGwZ4CQIhJeMJl2B4jqrFjljrTYnIS6f1LjawvaEQyf3R1vS/275GzBJj BfHyR2V64YTLg4+eZAGvBRq28a+PvoEJVQX5PoSedMdD+WlP07gdYYH+Niz8F20r nWgjb0GfO5Dos9N2/UTeiDtiUHBFN/BbZ+0dpu9ezhjOdKrVaFve3mBNI9Bzu2Gu VVLOuDuMUZIO83ae9EbrfH8TpY8JE8bXmajnXAPhQ2rGJfJvNAXTCmrJh3Tyq0mc 5fE5tNr52qpVKvj/I1un+GaVRLGzxT2z3bIQsc/+dAIZ2/G/vDkd3V2eadzIDT/A XqLbk+l2OyyuL/IKZgK6DKXjxwLcQ== X-ME-Sender: <xms:w3AbXUb1l7FC7l4aa7s9mwOCro4qUXvYs2b2gBbIcR-ZKKJ-xJFK_A> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrvdekgdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:w3AbXb85ZGxa34fvEoV4B05e3rvsfUNejmXDaRxi8BJdVL69ZU61ow> <xmx:w3AbXTZpSIT9eEQ5GvEk084WgglvDTntw3tgGL6KvbPt9XnIIUuiEQ> <xmx:w3AbXVdRmGMbpwKTQgqTliHTkdhUzahWP0WYmhXPj49UddYZhLVPYQ> <xmx:xHAbXQJOJRU-1rBDebWl31zXB2b7TAdAUxDF0hVAnsPf1dVJXqYXlg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 062418005A; Tue, 2 Jul 2019 10:57:05 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Anoob Joseph <anoobj@marvell.com> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>, Mattias =?ISO-8859-1?Q?R=F6nnblom?= <mattias.ronnblom@ericsson.com>, Nikhil Rao <nikhil.rao@intel.com>, Erik Gabriel Carrillo <erik.g.carrillo@intel.com>, Abhinandan Gujjar <abhinandan.gujjar@intel.com>, Bruce Richardson <bruce.richardson@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>, Narayana Prasad Raju Athreya <pathreya@marvell.com>, Lukas Bartosik <lbartosik@marvell.com>, Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, Nipun Gupta <nipun.gupta@nxp.com>, Harry van Haaren <harry.van.haaren@intel.com>, Liang Ma <liang.j.ma@intel.com>, "techboard@dpdk.org" <techboard@dpdk.org> Date: Tue, 02 Jul 2019 16:57:04 +0200 Message-ID: <3848960.f2llPjXIeu@xps> In-Reply-To: <BYAPR18MB24241C91784C4F80E71EB933C8F80@BYAPR18MB2424.namprd18.prod.outlook.com> References: <BYAPR18MB2424505627F28A84D9674D63C8E30@BYAPR18MB2424.namprd18.prod.outlook.com> <MN2PR18MB2877B01AD5B320214DFBAA47DFF80@MN2PR18MB2877.namprd18.prod.outlook.com> <BYAPR18MB24241C91784C4F80E71EB933C8F80@BYAPR18MB2424.namprd18.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 02/07/2019 16:26, Jerin Jacob Kollanukkaran: > From: Anoob Joseph > > Hi Thomas, Jerin, > > > > Is there any consensus on how we should proceed? Can this be taken up by > > techboard? OK, let me give my detailed opinion. Summary: I don't like this situation at all. I think eventdev should be simple to use and could be added to any example like l2fwd. The idea of forking an example, where we should be able to have an unified API, is a proof of failure. About the copy of the example itself, you are copying it as first patch of this series and then do improvements only to the copy, leaving the original behind. About the helper, I see some command line processing and other things which have nothing to do in a library. Actually I fail to understand the global idea of this helper. There is no description of what this helper is, and even no name for it. > For me it make sense to move these helper functions to examples/.. and make it as standalone(not as library) > Suggested directory(In the order of my preference). No strong preference on the directory name though > 1) examples/helper or > 2) examples/common or > 3) examples/utils If we are not able to give it a better name than "helper" or "utils", it is like moving it in a trash folder. And last but not least, there is not a lot of reaction to this series. So my suggestion is to do your PoC in a standalone example, improving the original example at the same time, and try to improve the eventdev library if possible. Then we should not propagate this design to more examples until we have a proof that it is a progress.