From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/6] testpmd: remove unnecessary void casts
Date: Mon, 11 Sep 2017 13:44:43 +0100 [thread overview]
Message-ID: <384bad9a-3941-3b1f-3d68-68787ad6ae39@intel.com> (raw)
In-Reply-To: <20170823154445.19494-2-stephen@networkplumber.org>
On 8/23/2017 4:44 PM, Stephen Hemminger wrote:
> The testpmd was doing old BSD lint style casts of rte_memcpy
> to (void). This is unnecessary.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
<...>
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2173,7 +2173,7 @@ init_port_dcb_config(portid_t pid,
> * Set the numbers of RX & TX queues to 0, so
> * the RX & TX queues will not be setup.
> */
> - (void)rte_eth_dev_configure(pid, 0, 0, &port_conf);
> + rte_eth_dev_configure(pid, 0, 0, &port_conf);
>
> rte_eth_dev_info_get(pid, &rte_port->dev_info);
According cover letter, intention seems as removing void casts for
rte_memcpy, and all other updates except this one is for rte_memcpy.
Is above change intentional?
next prev parent reply other threads:[~2017-09-11 12:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 15:44 [dpdk-dev] [PATCH 0/6] remove unncessary void cast Stephen Hemminger
2017-08-23 15:44 ` [dpdk-dev] [PATCH 1/6] testpmd: remove unnecessary void casts Stephen Hemminger
2017-09-04 11:39 ` Rybalchenko, Kirill
2017-09-07 8:36 ` Wu, Jingjing
2017-09-11 12:44 ` Ferruh Yigit [this message]
2017-08-23 15:44 ` [dpdk-dev] [PATCH 2/6] bnx2x: remove unnecssary void cast of rte_memcpy Stephen Hemminger
2017-09-04 11:50 ` Rybalchenko, Kirill
2017-08-23 15:44 ` [dpdk-dev] [PATCH 3/6] sfc: remove unnecessary " Stephen Hemminger
2017-09-04 12:39 ` Rybalchenko, Kirill
2017-08-23 15:44 ` [dpdk-dev] [PATCH 4/6] e1000: " Stephen Hemminger
2017-09-04 12:40 ` Rybalchenko, Kirill
2017-08-23 15:44 ` [dpdk-dev] [PATCH 5/6] i40e: " Stephen Hemminger
2017-09-04 12:45 ` Rybalchenko, Kirill
2017-09-09 3:24 ` Wu, Jingjing
2017-08-23 15:44 ` [dpdk-dev] [PATCH 6/6] ixgbe: " Stephen Hemminger
2017-09-04 12:49 ` Rybalchenko, Kirill
2017-09-11 12:44 ` [dpdk-dev] [PATCH 0/6] remove unncessary void cast Ferruh Yigit
2017-09-11 13:32 ` Ferruh Yigit
2017-09-11 13:00 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=384bad9a-3941-3b1f-3d68-68787ad6ae39@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).