From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1FF711AF03 for ; Mon, 11 Sep 2017 14:44:45 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2017 05:44:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,377,1500966000"; d="scan'208";a="899098217" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 11 Sep 2017 05:44:44 -0700 To: Stephen Hemminger , dev@dpdk.org References: <20170823154445.19494-1-stephen@networkplumber.org> <20170823154445.19494-2-stephen@networkplumber.org> From: Ferruh Yigit Message-ID: <384bad9a-3941-3b1f-3d68-68787ad6ae39@intel.com> Date: Mon, 11 Sep 2017 13:44:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170823154445.19494-2-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/6] testpmd: remove unnecessary void casts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 12:44:46 -0000 On 8/23/2017 4:44 PM, Stephen Hemminger wrote: > The testpmd was doing old BSD lint style casts of rte_memcpy > to (void). This is unnecessary. > > Signed-off-by: Stephen Hemminger <...> > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2173,7 +2173,7 @@ init_port_dcb_config(portid_t pid, > * Set the numbers of RX & TX queues to 0, so > * the RX & TX queues will not be setup. > */ > - (void)rte_eth_dev_configure(pid, 0, 0, &port_conf); > + rte_eth_dev_configure(pid, 0, 0, &port_conf); > > rte_eth_dev_info_get(pid, &rte_port->dev_info); According cover letter, intention seems as removing void casts for rte_memcpy, and all other updates except this one is for rte_memcpy. Is above change intentional?