DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Reshma Pattan <reshma.pattan@intel.com>
Cc: dev@dpdk.org, longtb5@viettel.com.vn,
	konstantin.ananyev@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] latencystats: fix timestamp marking and latency calculation
Date: Thu, 25 Oct 2018 10:31:43 +0200	[thread overview]
Message-ID: <38519281.CEthSRxIAY@xps> (raw)
In-Reply-To: <1537887086-19960-1-git-send-email-reshma.pattan@intel.com>

25/09/2018 16:51, Reshma Pattan:
> Latency calculation logic is not correct for the case where
> packets gets dropped before TX. As for the dropped packets,
> the timestamp is not cleared, and such packets still gets
> counted for latency calculation in next runs, that will result
> in inaccurate latency measurement.
> 
> So fix this issue as below,
> 
> Before setting timestamp in mbuf, check mbuf don't have
> any prior valid time stamp flag set and after marking
> the timestamp, set mbuf flags to indicate timestamp is
> valid.
> 
> Before calculating timestamp check mbuf flags are set to
> indicate timestamp is valid.
> 
> With the above logic it is guaranteed that correct timestamps
> have been used.
> 
> Fixes: 5cd3cac9ed ("latency: added new library for latency stats")
> 
> CC: stable@dpdk.org
> 
> Reported-by: Bao-Long Tran <longtb5@viettel.com.vn>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> Tested-by: Bao-Long Tran <longtb5@viettel.com.vn>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 
> ---
> v3: style related fix
> v2: remove check for mbuf->timestamp
> ---

Applied, thanks

      reply	other threads:[~2018-10-25  8:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 16:01 [dpdk-dev] [PATCH] " Reshma Pattan
2018-09-22  2:58 ` longtb5
2018-09-24 13:07   ` Pattan, Reshma
2018-09-25 15:22     ` longtb5
2018-09-24  7:10 ` longtb5
2018-09-25 12:24 ` [dpdk-dev] [PATCH v2] " Reshma Pattan
2018-09-25 14:30   ` Ananyev, Konstantin
2018-09-25 14:51 ` [dpdk-dev] [PATCH v3] " Reshma Pattan
2018-10-25  8:31   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38519281.CEthSRxIAY@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=longtb5@viettel.com.vn \
    --cc=reshma.pattan@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).