From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF2814247D; Tue, 24 Jan 2023 16:25:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFAF240150; Tue, 24 Jan 2023 16:25:37 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 55A98400EF for ; Tue, 24 Jan 2023 16:25:37 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B8F715C0595; Tue, 24 Jan 2023 10:25:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 24 Jan 2023 10:25:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674573936; x= 1674660336; bh=/TSinvZsRNXnZpIePSWPZcr+WX0/ztKp3gRuYp23tao=; b=S Hb//HMnA0sff1MbbKFk2Ht8n2rx6tmtwzyg3AyzKUrGAvEY1nK6gr5363eButTZO AoDax5K//tBW3swvIhBVr8MAgahEz/cBKyW69Ysir3EkqPJTPCdWvq2ot9yM/xzr d1hE5pR2ll2Dhm8dEuL3BfagG/7kZQ/Ifu36mYIj5kLyJiVDoNGysGXkvMf5dJcF c8vckq28j8ifPQcBckPsJrZxChgs+elhL4AuchVJc1rIbNrm7U59hCGyyxTT+ArT FKjr72LtfmeKgvXia33c/NUh23LHSPA1k4fbSwE5GDk2ecnmX5xaAzbadN5SUr5I J1kdzpkjWUH60MfTMJbtA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674573936; x= 1674660336; bh=/TSinvZsRNXnZpIePSWPZcr+WX0/ztKp3gRuYp23tao=; b=Z XEWKG08HCsf5kFZUUMP9x/l2lNBO09aJBtktxJZcr9Nx0i9Ya3HAzsRDDhpabeqy mnLHqX2RbTGXXEdFO3HlIMcXYH7DT+BUhO1fSEudb1u8ib4XmftNdmiAGTMEBS0y Ci0X0pGpNkz+3eG6iQpCzjvK/RPkFX0fSbcMyD+N+p/2vWVddhQUFpSSPZGwqYfN tJD3G8ZM5auoxjD+XO7QuqKFlYVfc1p1z9ettTxrrZl6C8I6nSvhUUjQtRTBD730 FhyBB9wQjocC0QlQq6z3c5GwRQUo/Zg/TAX6A6c4j/KsLz04vzpifbCpWepboIjX 1Y4MPDqsTtNcMObka4Lvg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvtddgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkfgjfhgggfgtsehtqh ertddttddunecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepfefhjeeluedvvedtud dtuedtvefhieejtefhffeujefhteduudevtdektdeikeffnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonh drnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 Jan 2023 10:25:35 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, david.marchand@redhat.com, jerinjacobk@gmail.com, mb@smartsharesystems.com Subject: Re: [PATCH v7 3/5] eal: set thread name on Windows worker threads Date: Tue, 24 Jan 2023 16:25:34 +0100 Message-ID: <3854099.WbyNdk4fJJ@thomas> In-Reply-To: <1674502774-20253-4-git-send-email-roretzla@linux.microsoft.com> References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com> <1674502774-20253-1-git-send-email-roretzla@linux.microsoft.com> <1674502774-20253-4-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/01/2023 20:39, Tyler Retzlaff: > Bring Windows EAL worker thread initialization in line with linux & > freebsd by setting the worker thread name using the new > platform agnostic rte_thread_set_name API. >=20 > Signed-off-by: Tyler Retzlaff >=20 > Acked-by: Morten Br=F8rup >=20 > --- > lib/eal/windows/eal.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c > index b9f95ed..e561f87 100644 > --- a/lib/eal/windows/eal.c > +++ b/lib/eal/windows/eal.c > @@ -282,6 +282,7 @@ enum rte_proc_type_t > enum rte_iova_mode iova_mode; > int ret; > char cpuset[RTE_CPU_AFFINITY_STR_LEN]; > + char thread_name[RTE_MAX_THREAD_NAME_LEN]; > =20 > eal_log_init(NULL, 0); > =20 > @@ -437,6 +438,12 @@ enum rte_proc_type_t > if (rte_thread_create(&lcore_config[i].thread_id, NULL, > eal_thread_loop, (void *)(uintptr_t)i) !=3D 0) > rte_panic("Cannot create thread\n"); > + > + /* Set thread_name for aid in debugging. */ No need of underscore in "thread name". > + snprintf(thread_name, sizeof(thread_name), > + "rte-worker-%d", i); > + rte_thread_set_name(lcore_config[i].thread_id, thread_name); Thanks for making implementations more uniform.